Repository navigation
omamobile-modem-sit: fail the status probe on incomplete replies - #569
Conversation
The read-only probe previously exited successfully after missing status replies. Return failure for malformed SIM status, malformed mandatory states, empty replies and request errors while always closing the client. Keep the legitimate no-SIM SMSC error 11 exception and the existing first USIM timeout. Add eight tests against the real service.probe with inert replies and advance the package version. Co-Authored-By: OpenAI Codex <noreply@openai.com>
|
Thank you, this is a tidy change and the tests call the real I also checked the Pixel 7 Pro's own probe logs from the modem bring-up: with no SIM they show card state 0 and "SMSC unavailable: error 11", which your exception keeps as a pass. The only callers of I'm merging it now, as omamobile-modem-sit 0.3.33: it's the first of the open modem PRs to land, so the other PRs that claim 0.3.33 will take later numbers. One small follow-up whenever it suits you: a line in the docstring saying why a present SIM with no SMSC counts as a failure. |
|
Thank you for checking the old behavior and the no-SIM logs on the Pixel 7 Pro. I added the requested docstring rationale in #583: a failed or empty SMSC reply with a present SIM leaves SMS configuration unverified, while error 11 without a SIM remains expected. That follow-up changes documentation only; the probe behavior and package version are unchanged. |
Document why a failed or empty SMSC reply is incomplete with a present SIM, while the no-SIM error remains an expected result. Follow up on the review of #569 without changing probe behavior or its package version. Co-authored-by: OpenAI Codex <noreply@openai.com>
Main took 0.1.17 (derekross#568) and 0.3.33 (derekross#569) for other changes and omamobile-device-tegu 0.2.11 (derekross#591), so this branch's packages move to the next numbers and the README names the modem package version the stop command comes with.
…es (derekross#569) The read-only probe previously exited successfully after missing status replies. Return failure for malformed SIM status, malformed mandatory states, empty replies and request errors while always closing the client. Keep the legitimate no-SIM SMSC error 11 exception and the existing first USIM timeout. Add eight tests against the real service.probe with inert replies and advance the package version. Co-authored-by: OpenAI Codex <noreply@openai.com>
…#583) Document why a failed or empty SMSC reply is incomplete with a present SIM, while the no-SIM error remains an expected result. Follow up on the review of derekross#569 without changing probe behavior or its package version. Co-authored-by: OpenAI Codex <noreply@openai.com>
Make the read-only SIT status probe return failure when replies are incomplete. Previously, malformed SIM status or unavailable status requests could still produce exit status 0. Malformed mandatory states, empty replies and request errors now fail, with the client closed in every path. A missing SIM's legitimate SMSC error 11 remains accepted, and the existing 20-second initial USIM timeout is preserved.
The package advances from 0.3.32 to 0.3.33. Eight tests call the real
service.probewith inert replies, covering the six GETs, malformed and empty data, unavailable states, client closure and the no-SIM SMSC exception. The eight direct probe tests pass. An independent complete package-suite run also passes with the public base’s SIT simulator explicitly enabled (140.50 seconds), including staged installation, configuration and unit checks. The existing reference check against the sibling Cheetah package is skipped in this isolated package copy; simulator checks are enabled. This is offline validation, not a phone or 5G result.tools/pr-checkpasses against main09b7eb222f9e208a394cbe03fddffb78de448023.This extends the existing MIT-licensed SIT service and preserves its original attribution. It adds no request types or modem configuration writes and does not duplicate the merged telephony integration from #371.
Upstream CI passes the policy gate,
tests/allandtests/packages.