Repository navigation
docs/review: round 45's lessons (L-562 to L-597) - #551
Merged
Merged
Conversation
Round 45's confirmed-candidate lessons from the omarchy-mobile and linux-omarchy-mobile reviews, plus five from the maintainer session of 2026-11-08 (the four build steps a test kernel needs for push, reboot-to and the modem's clean-stop marker, pacman steps on a non-Arch build host, a new dependency's example config and the identifier scan, and checkdepends). Six candidates that were second instances of existing lessons became "Again in round 45" sentences on L-333, L-427, L-430, L-454, L-532 and L-547. C-32 and C-33 correct round 44 on #420's 0029 (applies to omarchy 4.5.0-3 at fuzz 0) and on kernel #219's test phone (the cover letter names it). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
derekross
added a commit
that referenced
this pull request
Nov 9, 2026
Round 46's confirmed candidates from the reviews of the open omarchy-mobile and linux-omarchy-mobile pull requests, the round's own process slips (shared refs and scratch files deleted by glob, a maintainer fixup that skipped the package's test/all, an amend on a contributor branch) and the 2026.11.08 release PRs (#547, #548, #549, #550, #560). Repeats of existing lessons extend them instead: L-45 (kernel #222), L-183 (#409), L-426 (the round's version collisions, now set by hand at merge) and L-550 (#471 with #420). C-34 and C-35 correct our #290 shell suggestion and round 45's claim that tests/dipper-probe guards anything. Stacked on #551 (round 45's lessons). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
derekross
added a commit
that referenced
this pull request
Nov 9, 2026
Round 46's confirmed candidates from the reviews of the open omarchy-mobile and linux-omarchy-mobile pull requests, the round's own process slips (shared refs and scratch files deleted by glob, a maintainer fixup that skipped the package's test/all, an amend on a contributor branch) and the 2026.11.08 release PRs (#547, #548, #549, #550, #560). Repeats of existing lessons extend them instead: L-45 (kernel #222), L-183 (#409), L-426 (the round's version collisions, now set by hand at merge) and L-550 (#471 with #420). C-34 and C-35 correct our #290 shell suggestion and round 45's claim that tests/dipper-probe guards anything. Stacked on #551 (round 45's lessons). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
Round 45's confirmed-candidate lessons from the omarchy-mobile and linux-omarchy-mobile reviews, plus five from the maintainer session of 2026-11-08 (the four build steps a test kernel needs for push, reboot-to and the modem's clean-stop marker, pacman steps on a non-Arch build host, a new dependency's example config and the identifier scan, and checkdepends). Six candidates that were second instances of existing lessons became "Again in round 45" sentences on L-333, L-427, L-430, L-454, L-532 and L-547. C-32 and C-33 correct round 44 on derekross#420's 0029 (applies to omarchy 4.5.0-3 at fuzz 0) and on kernel derekross#219's test phone (the cover letter names it). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
Round 46's confirmed candidates from the reviews of the open omarchy-mobile and linux-omarchy-mobile pull requests, the round's own process slips (shared refs and scratch files deleted by glob, a maintainer fixup that skipped the package's test/all, an amend on a contributor branch) and the 2026.11.08 release PRs (derekross#547, derekross#548, derekross#549, derekross#550, derekross#560). Repeats of existing lessons extend them instead: L-45 (kernel derekross#222), L-183 (derekross#409), L-426 (the round's version collisions, now set by hand at merge) and L-550 (derekross#471 with derekross#420). C-34 and C-35 correct our derekross#290 shell suggestion and round 45's claim that tests/dipper-probe guards anything. Stacked on derekross#551 (round 45's lessons). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round 45's review lessons, for the maintainer to confirm before merge.
systemctl stop omamobile-modemtakes 40 s and ends as "failed", with a crash recorded #532, build-packages: sign the index as the container's root on a host without pacman #544, omamobile-shell: nodejs as a check dependency #545, alarm.sh: fetch Omarchy's keyring, signature-checked, on a host without it #547, release: the identifier scan reads /var/lib/omamobile, and skips dnsmasq's example addresses in its one file #550).tools/pr-check origin/mainpasses. Docs only; no phone involved.🤖 Generated with Claude Code