Repository navigation
omamobile-shell: nodejs as a check dependency - #545
Merged
Merged
Conversation
test/weather.py (since 0.2.90, #366) runs plugins/omamobile.home/HomeModel.js under node, but the PKGBUILD never said so. CI's runner and the build image have node, so nothing noticed until tools/phone-install-package built the shell on the Pixel 7 Pro, which has no node: check() failed at "omamobile-weather" and the package wasn't installed (2026-11-08, while installing #420 for its test). phone-install-package installs a package's checkdepends for the build and removes them afterwards, so with this line the phone built and installed it and nodejs was gone again. No version change: the package's files are the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
test/weather.py (since 0.2.90, derekross#366) runs plugins/omamobile.home/HomeModel.js under node, but the PKGBUILD never said so. CI's runner and the build image have node, so nothing noticed until tools/phone-install-package built the shell on the Pixel 7 Pro, which has no node: check() failed at "omamobile-weather" and the package wasn't installed (2026-11-08, while installing derekross#420 for its test). phone-install-package installs a package's checkdepends for the build and removes them afterwards, so with this line the phone built and installed it and nodejs was gone again. No version change: the package's files are the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/weather.pyneedsnode, and the PKGBUILD didn't list it, so the shell'scheck()failed when built on a phone withtools/phone-install-package(found today installing #420 on the 7 Pro; with this line it built, installed, andnodejswas removed again). No version bump: the package's contents don't change.🤖 Generated with Claude Code