Skip to content

omamobile-shell: nodejs as a check dependency - #545

Merged
derekross merged 1 commit into
mainfrom
shell-checkdepends-nodejs
Nov 9, 2026
Merged

derekross merged 1 commit into
mainfrom
shell-checkdepends-nodejs

Conversation

@derekross

Copy link
Copy Markdown
Owner

test/weather.py needs node, and the PKGBUILD didn't list it, so the shell's check() failed when built on a phone with tools/phone-install-package (found today installing #420 on the 7 Pro; with this line it built, installed, and nodejs was removed again). No version bump: the package's contents don't change.

🤖 Generated with Claude Code

test/weather.py (since 0.2.90, #366) runs plugins/omamobile.home/HomeModel.js
under node, but the PKGBUILD never said so. CI's runner and the build image
have node, so nothing noticed until tools/phone-install-package built the
shell on the Pixel 7 Pro, which has no node: check() failed at
"omamobile-weather" and the package wasn't installed (2026-11-08, while
installing #420 for its test). phone-install-package installs a package's
checkdepends for the build and removes them afterwards, so with this line
the phone built and installed it and nodejs was gone again.

No version change: the package's files are the same.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@derekross
derekross merged commit 29a6df0 into main Nov 9, 2026
2 checks passed
@derekross
derekross deleted the shell-checkdepends-nodejs branch November 9, 2026 00:36
robertzas pushed a commit to robertzas/omarchy-mobile that referenced this pull request Nov 14, 2026
test/weather.py (since 0.2.90, derekross#366) runs plugins/omamobile.home/HomeModel.js
under node, but the PKGBUILD never said so. CI's runner and the build image
have node, so nothing noticed until tools/phone-install-package built the
shell on the Pixel 7 Pro, which has no node: check() failed at
"omamobile-weather" and the package wasn't installed (2026-11-08, while
installing derekross#420 for its test). phone-install-package installs a package's
checkdepends for the build and removes them afterwards, so with this line
the phone built and installed it and nodejs was gone again.

No version change: the package's files are the same.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant