Repository navigation
device-coral: descriptor, direct ABL bring-up notes and device matrix - #52
Conversation
da7bf92 to
c0375d7
Compare
|
Thanks, @HemangKumawat, and welcome. This is a lot of hardware on a phone none of us has here, and the write-up is careful: the backups listed before anything ran, The descriptor is safe: every tool here refuses it before touching a phone, and I ran the checks and tests on your branch (all pass). Before I can merge, though, I need a few things, mostly because DEVICES.md is published on omamobile.org as our status and I have to be able to stand behind each cell.
Smaller things, none blocking:
Thanks again. This is a great start for the Pixel 4 XL, and I'd like to get it in. |
…device descriptor Document direct Android Bootloader (c2f2-0.5-8906123) header-v2 boot, slot history, kernel patches, read-only UFS storage guard, and subsystem bring-up findings for the Google Pixel 4 XL (coral, Qualcomm SM8150) on 6.17.0-sm8150, and link the published kernel/userspace/initramfs sources in HemangKumawat/omarchy-mobile-coral (tag v0.1.0). Assisted-by: AI Agent (on behalf of @HemangKumawat) Signed-off-by: Hemang Kumawat <HemangKumawat@users.noreply.github.com>
c0375d7 to
7b9b02e
Compare
Thanks for the thorough review and kind welcome, @derekross! I have rebased the branch onto the latest Here is the point-by-point breakdown: 1. The Sources (
|
…lags as a named exception Two decisions the Qualcomm ports (#17/#55-#59 flame, #52 coral, #25 alioth) were waiting on: - AGENTS.md said never to run an unsuffixed fastboot flash, but our own tools/install-phone already flashes userdata that way behind its guards. The rule now says so: userdata has no slots, and it is flashed only through install-phone. - On the Pixel 4 family the A/B slot flags live in GPT attributes, so marking slot B bootable is a partition-table write the storage guard can't block. It is allowed only as a narrow exception named per device in CONTRIBUTING §3.1 (LUN, sectors, bit, CRCs), done by hand once per boot-image install, with the flags recorded before and after, a rollback for a corrupted GPT and a way back. Never automatic. No device has an entry yet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks, @HemangKumawat, for such a thorough reply, and for publishing the companion repository. Most of my questions are answered well. The charger's SMB5 step fix, with stock's JEITA register left alone and the 4.447 V overcharge you found written down, the kernel-side recovery latch, the touch patch (I read it, and each path you list really is blocked), and the kernel-enforced speaker ceiling are exactly what I hoped to see. Thank you also for being straight about the modem backups. Your slot write-up, though, tells me things I need settled before this goes in as our documented method:
Smaller things, none blocking:
I'll approve the CI run on this head. Thanks again: the hardware coverage here is remarkable, and I'd like to get it in once the slot and backup questions are settled. |
…lags as a named exception (#60) * AGENTS, CONTRIBUTING: userdata through install-phone; Qualcomm slot flags as a named exception Two decisions the Qualcomm ports (#17/#55-#59 flame, #52 coral, #25 alioth) were waiting on: - AGENTS.md said never to run an unsuffixed fastboot flash, but our own tools/install-phone already flashes userdata that way behind its guards. The rule now says so: userdata has no slots, and it is flashed only through install-phone. - On the Pixel 4 family the A/B slot flags live in GPT attributes, so marking slot B bootable is a partition-table write the storage guard can't block. It is allowed only as a narrow exception named per device in CONTRIBUTING §3.1 (LUN, sectors, bit, CRCs), done by hand once per boot-image install, with the flags recorded before and after, a rollback for a corrupted GPT and a way back. Never automatic. No device has an entry yet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * DEVICES: the PinePhone Pro's codename and starting point The Wanted row had "-" as its codename, which omamobile.org prints next to the SoC ("-, Rockchip RK3399S"). It takes mainline's board name, pinephone-pro, and names that device tree, already in our kernel, as the starting point (promised on #47). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Two decisions you were waiting on from my side, both now in AGENTS.md §1 and CONTRIBUTING §3.1 (merged on the 26th):
For this PR that means: the slot record stays as the honest account of what was written, the plan's install section points at the guarded installer and the manual exception rather than at a tool of its own, and the matrix row says "in review" until a coral entry exists. The rest of my earlier points stand; nothing else changed. |
Thanks for the detailed Round 2 review ( We have updated Here is the point-by-point summary of what changed: 1. Companion repository (
|
- device/coral/BRINGUP-M1.md:
- Cite public SM8150 commit 6963e3800a8e (3 commits past tag v6.17.0-sm8150 at
379d8fe35c7c) and link HemangKumawat/omarchy-mobile-coral v0.2.1 (PROVENANCE.md
and ordered kernel/series/ patches reproducing git trees 21eb1828b205 for
Kernel derekross#30 Image and 6d4115553ae5 for the 12-entry DTB and modules).
- State plainly in section 2 that the development handset state (boot_a/dtbo_a,
disabled vbmeta_a, ext4 userdata leaving no stock fallback slot) is a
historical record and must not be copied.
- Document the historical one-shot 2026-10-18 sfdisk --part-attrs command that
set GPT bit 54 on boot_a over SSH and mark it not to be repeated.
- Point to the guarded installer (tools/install-phone) and pending coral-specific
CONTRIBUTING.md section 3.1 entry; mark the slot B recipe untested on this
unit, note the untested stock vbmeta verification behavior with unsigned
boot_b, and document the 3-unmarked-boots ABL fallback and stock userdata
factory-reset prompt.
- Document the staged read-only PARTNAME backup gate before the next mpss boot,
the early tethered vs 22 October standalone initramfs health loop, and the
physical-access root shell warning on ttyGS0.
- device/coral/NOTES.md:
- Move the 'coral (Pixel 4 XL) in detail' table from docs/DEVICES.md into
device/coral/NOTES.md.
- Document the aftermarket replacement battery on the test handset (missing OEM
Maxim fuel-gauge IC at 1-0036 returning -ENXIO, as on stock Android, while
PM8150B ADC5 VBAT_SNS voltage and FG SRAM thermistor temperature telemetry and
bounded 4.20 V / 500 mA charging work via tools/battery-status.patch).
- docs/DEVICES.md:
- Keep only the matrix row and Wanted entry for Pixel 4 XL (coral), marked
in review (derekross#52) pending coral's CONTRIBUTING.md section 3.1 entry.
Co-Authored-By: AI Agent <noreply@users.noreply.github.com>
Signed-off-by: Hemang Kumawat <HemangKumawat@users.noreply.github.com>
|
Thanks, @HemangKumawat. This head does what I asked: the handset's state is written down as a record and not a recipe, the bit-54 write is spelled out with the tool, the node and how the guard was lifted and marked not to be repeated, the install section points at Three small things to fix, then I'll merge:
Two notes, not blocking: "probes I'll approve the CI run on this head now. What stays open after the merge, and outside this PR: coral's own §3.1 entry (your before/after flags are the raw material for it), |
- DEVICES.md: lead each coral cell with a legend word (WIP/testing) and move the qualifier into the parentheses; note that the Wi-Fi and Modem radio sessions ran before the modem baseline. - BRINGUP-M1.md: restore the Gates and rollback table as section 7, corrected for this unit (Fastboot and a factory image; slot B untested). - BRINGUP-M1.md, NOTES.md: fix the companion tag id and the three public kernel commits between v6.17.0-sm8150 and 6963e3800a8e; point at companion tag v0.2.2 (v0.2.1 plus the corrected PROVENANCE.md list). - NOTES.md: the 1-0036 probe on an OEM pack is expected, not tested. Assisted-by: AI Agent <noreply@users.noreply.github.com> Signed-off-by: HemangKumawat <HemangKumawat@users.noreply.github.com>
Thanks, @derekross. All three are fixed in c573f04, and both notes are taken in.
On the notes: the
|
|
Thanks, @HemangKumawat. All three are in, and I checked each one rather than the summary:
The Thanks for sticking with this through four rounds: the coral notes are now a record someone else can follow and check. |
@derekross, please hold the merge for a moment. Sorry, this one is on us. Before you merged, we ran your own reviewer agent (
There are also two dead ids: the long form of the We're fixing all of these now and will push one commit with a full list. Then I'll write properly. Thank you for your patience. |
Round 4: we ran the omamobile-reviewer agent with docs/review/LESSONS.md on c573f04 and checked every claim against the logs and the build trees. Several statements were wrong; this commit corrects them. - Kernel derekross#30 was built from both series (coral-30 and coral-fec40357, git tree 6d4115553ae5), not coral-30 alone. Point at companion v0.2.3 (78f77e861cfe), whose PROVENANCE.md and build-kernel.sh now say and do the same. - No raw copy of persist or any other partition was taken before the first flash; the owner approved skipping it. The earlier text said persist was backed up. The read-only dump in BRINGUP-M1 section 5 is now a tested runbook and will be the first copy. - Section 2 records the slot history as logged: slot A bootloader only, the 18 runs of the bit-54 procedure (18-20 Oct, kernels derekross#6 to derekross#30, attribute 48,49,50,52 to +54), the sfdisk sectors saved, and the getvar readback. It is marked as history, not current state. - NOTES.md: each dated entry names its kernel build; dates fixed (the Wi-Fi/display/GPU/touch entry is 18 Oct, cameras 19 Oct); camera counts, torch LED names and the torch measurement from the logs; the charger float-voltage formula; a new 22 Oct entry for the boot without a USB data link, Wi-Fi, SIM and the persistence test. - DEVICES.md: USB cell names CDC ECM + ACM; battery cell says the aftermarket pack gives no reply at 1-0036; companion v0.2.3. Not run on the phone: it has been unreachable since 22 Oct. Checked with tools/pr-check and tests/all. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: HemangKumawat <HemangKumawat@users.noreply.github.com>
# Conflicts: # docs/DEVICES.md
@derekross, the fixes are in, and the merge can go ahead when you're happy. First, sorry. Too many things in these notes were wrong, and you had to check them one by one. This is the first time I've built something together with someone on GitHub, and I let text go out that we hadn't checked against our own records. Your reviews showed us how it should be done. What changed
What we had wrong
My comments from 26 Oct 22:28Z and 27 Oct 16:01Z repeat some of these. I've added a pointer to this comment at the top of each. Your reviewer agent's findings (we ran
Still open
A question Thank you for your patience through five rounds. |
|
Thank you, @HemangKumawat, and thank you for stopping the merge yourself. Finding your own records wrong and saying so before the merge is exactly what makes notes like these worth having. I'd much rather merge the corrected version than the confident one. I went through the new push. The ids check out now. Tag Two suggestions for §5.2 before the phone comes back. Neither holds the merge:
On your licensing question: please keep the sensor mode tables decoded from On what to adopt, you've found most of it. CONTRIBUTING (§3 for safety, §6 for submitting), AGENTS.md for the rules and the reasons behind them, |
The Pixel 7a's touch is in the published kernel (kernel #93) and its device package is merged (#88); the Pixel 4 XL's notes and results merged with #52, so its cells drop the "in review" qualifier; the Pixel 7's board device tree, touch driver and package are in review. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The matrix and the Wanted list against what has merged since #140, with each pull request's state checked on GitHub today: - Pixel 7 (panther): the GPU and haptics nodes (kernel #129, #130) were closed because they landed unchanged through kernel #134, merged with the touchscreen node and s2idle by default; device-panther 0.1.1 (#145) carries the GPU's always-on rule, the feedbackd rule and the sleep.conf drop-in. GPU and Haptics stay "testing" and now cite #134, #145 and the 2026-10-28 notes. Touch stays WIP: kernel #134's body records touches driving Hyprland and the PIN screen, but the driver fixes (kernel #133) and the kernel option with the touch notes (#149) are still in review. Suspend: "no" with the s2idle default named, since the notes say it hasn't run. - Pixel 6 Pro (raven): Haptics "no" -> "works": HAPTICS-TORCH-PLAN H5 passed (2026-10-28/29), cs40l25-vibra and the node merged as kernel #114, feedbackd's rule in device-raven 0.1.27 (#113). Display names its open kernel PR, #116. - Pixel 7a (lynx): Bluetooth "no" -> WIP: the merged WIFI-PLAN (#133) records it scanning through its own UART; kernel #98 and #98 are in review. The Wanted line says so too. - Pixel 7 Pro (cheetah) detail: Boot names the AVB footers a chained vbmeta_b needs (NOTES 2026-10-28 and 10-29, #104); Suspend describes the merged tier 1 auto-sleep (#64, off by default behind the omamobile-sleep toggle, P0-P5 on 2026-10-26) in place of the old "until S8" text. Nothing from the open #171, #172, #174-#176. - Wanted: coral's #52 is merged, so its line no longer says "in review"; flame gets a line for its native install in review (#55, #56, #58, #59, split out of #17); the OnePlus 13 (dodge) is listed with #111 and kernel #115, both open. The Pixel 9a row and the Pixel 9 family line are left to #165. Every status word still parses with the website's parseCell. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The matrix and the Wanted list against what has merged since derekross#140, with each pull request's state checked on GitHub today: - Pixel 7 (panther): the GPU and haptics nodes (kernel derekross#129, derekross#130) were closed because they landed unchanged through kernel derekross#134, merged with the touchscreen node and s2idle by default; device-panther 0.1.1 (derekross#145) carries the GPU's always-on rule, the feedbackd rule and the sleep.conf drop-in. GPU and Haptics stay "testing" and now cite derekross#134, derekross#145 and the 2026-10-28 notes. Touch stays WIP: kernel derekross#134's body records touches driving Hyprland and the PIN screen, but the driver fixes (kernel derekross#133) and the kernel option with the touch notes (derekross#149) are still in review. Suspend: "no" with the s2idle default named, since the notes say it hasn't run. - Pixel 6 Pro (raven): Haptics "no" -> "works": HAPTICS-TORCH-PLAN H5 passed (2026-10-28/29), cs40l25-vibra and the node merged as kernel derekross#114, feedbackd's rule in device-raven 0.1.27 (derekross#113). Display names its open kernel PR, derekross#116. - Pixel 7a (lynx): Bluetooth "no" -> WIP: the merged WIFI-PLAN (derekross#133) records it scanning through its own UART; kernel derekross#98 and derekross#98 are in review. The Wanted line says so too. - Pixel 7 Pro (cheetah) detail: Boot names the AVB footers a chained vbmeta_b needs (NOTES 2026-10-28 and 10-29, derekross#104); Suspend describes the merged tier 1 auto-sleep (derekross#64, off by default behind the omamobile-sleep toggle, P0-P5 on 2026-10-26) in place of the old "until S8" text. Nothing from the open derekross#171, derekross#172, derekross#174-derekross#176. - Wanted: coral's derekross#52 is merged, so its line no longer says "in review"; flame gets a line for its native install in review (derekross#55, derekross#56, derekross#58, derekross#59, split out of derekross#17); the OnePlus 13 (dodge) is listed with derekross#111 and kernel derekross#115, both open. The Pixel 9a row and the Pixel 9 family line are left to derekross#165. Every status word still parses with the website's parseCell. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
What and why
The first
coral(Pixel 4 XL, SM8150) PR, as CONTRIBUTING §5 describes: a descriptor and notes, plus the matrix row.device/coral/device.conf:BOOT_METHOD=android-v2, so every tool in this repository refusesDEVICE=coralbefore it touches a phone.device/coral/BRINGUP-M1.md: how the development handset boots our kernel directly from Google's ABL (c2f2-0.5-8906123), the slot history on that handset (a record, not a recipe), backups, the storage guard, the watchdog andqcom-ponlatch, kernel provenance, and the gates.device/coral/NOTES.md: dated results per subsystem, each naming the kernel build it ran on.docs/DEVICES.md: the coral row and a Wanted entry.Kernel, device trees, userspace patches and initramfs are in
HemangKumawat/omarchy-mobile-coralv0.2.3(78f77e861cfed7cbb57aea7eedc3c539ae1c8e81), on the public SM8150 tree at6963e3800a8e. Install throughtools/install-phoneand coral's CONTRIBUTING §3.1 entry come in later PRs.Device and build
uname -r):6.17.0-sm8150(build#30, 19 Oct 2026)Checks (no phone needed)
tools/pr-check origin/mainpassestests/allpassestests/packages: no packages touchedversionbumped: no packages touchedCo-Authored-By:orAssisted-by:trailer, never aSigned-off-by:On the phone
tools/phone-smoke; slot B; a cold boot with the cable removed; anything since 22 Oct.userdata, weakens the storage guard, or reads registers from userspace. The slot-A writes on the development handset are recorded in BRINGUP-M1 §2 as history, not to be repeated.tools/phone-smokereportNot run:
coralis not supported bybin/omamobileyet (accepted in round 1).Owner confirmation and AI disclosure
Signed-off-by:and an AI trailer.