Skip to content

AGENTS, CONTRIBUTING: userdata through install-phone; Qualcomm slot flags as a named exception - #60

Merged
derekross merged 2 commits into
mainfrom
policy-flash-rules
Oct 26, 2026
Merged

derekross merged 2 commits into
mainfrom
policy-flash-rules

Conversation

@derekross

Copy link
Copy Markdown
Owner

The two decisions the Qualcomm ports (#17/#55-#59 flame, #52 coral, #25 alioth) were waiting on:

  • userdata: AGENTS.md said never to run an unsuffixed fastboot flash, but tools/install-phone already flashes userdata that way behind its guards (serial pinned, codename typed, allowlist, dry run). The rule now says so: userdata only, and only through install-phone.
  • GPT slot flags on the Pixel 4 family: marking slot B bootable is a partition-table write the storage guard can't block. It's allowed only as a narrow exception named per device in CONTRIBUTING §3.1 (LUN, sectors, bit, CRCs), by hand once per boot-image install, with the flags recorded before and after, a rollback for a corrupted GPT and a way back. Never automatic. No device has an entry yet.

🤖 Generated with Claude Code

derekross and others added 2 commits October 26, 2026 19:40
…lags as a named exception

Two decisions the Qualcomm ports (#17/#55-#59 flame, #52 coral, #25
alioth) were waiting on:

- AGENTS.md said never to run an unsuffixed fastboot flash, but our own
  tools/install-phone already flashes userdata that way behind its guards.
  The rule now says so: userdata has no slots, and it is flashed only
  through install-phone.
- On the Pixel 4 family the A/B slot flags live in GPT attributes, so
  marking slot B bootable is a partition-table write the storage guard
  can't block. It is allowed only as a narrow exception named per device
  in CONTRIBUTING §3.1 (LUN, sectors, bit, CRCs), done by hand once per
  boot-image install, with the flags recorded before and after, a
  rollback for a corrupted GPT and a way back. Never automatic. No device
  has an entry yet.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Wanted row had "-" as its codename, which omamobile.org prints next
to the SoC ("-, Rockchip RK3399S"). It takes mainline's board name,
pinephone-pro, and names that device tree, already in our kernel, as the
starting point (promised on #47).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@derekross
derekross merged commit 10daf5f into main Oct 26, 2026
2 checks passed
@derekross
derekross deleted the policy-flash-rules branch October 28, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant