Repository navigation
AGENTS, CONTRIBUTING: userdata through install-phone; Qualcomm slot flags as a named exception - #60
Merged
Merged
Conversation
…lags as a named exception Two decisions the Qualcomm ports (#17/#55-#59 flame, #52 coral, #25 alioth) were waiting on: - AGENTS.md said never to run an unsuffixed fastboot flash, but our own tools/install-phone already flashes userdata that way behind its guards. The rule now says so: userdata has no slots, and it is flashed only through install-phone. - On the Pixel 4 family the A/B slot flags live in GPT attributes, so marking slot B bootable is a partition-table write the storage guard can't block. It is allowed only as a narrow exception named per device in CONTRIBUTING §3.1 (LUN, sectors, bit, CRCs), done by hand once per boot-image install, with the flags recorded before and after, a rollback for a corrupted GPT and a way back. Never automatic. No device has an entry yet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Wanted row had "-" as its codename, which omamobile.org prints next
to the SoC ("-, Rockchip RK3399S"). It takes mainline's board name,
pinephone-pro, and names that device tree, already in our kernel, as the
starting point (promised on #47).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
derekross
force-pushed
the
policy-flash-rules
branch
from
October 26, 2026 23:40
7e26a20 to
fd07e31
Compare
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two decisions the Qualcomm ports (#17/#55-#59 flame, #52 coral, #25 alioth) were waiting on:
userdata: AGENTS.md said never to run an unsuffixedfastboot flash, buttools/install-phonealready flashesuserdatathat way behind its guards (serial pinned, codename typed, allowlist, dry run). The rule now says so:userdataonly, and only throughinstall-phone.🤖 Generated with Claude Code