Repository navigation
omamobile-omarchy 0.1.34: retain phone-critical migration holds - #469
marselnenaj wants to merge 1 commit into
Conversation
|
Thank you, @marselnenaj. Keeping the phone-critical holds on when someone turns the generic holds off is the right call, and I like that the test fails against the old wrapper. I ran it, and I also ran the wrapper over the real 4.5.0-3 migrations with a fake runner: it holds 23 of the 98 new ones, including the four you named. Three things before I merge:
Two small ones, if you're in there anyway: a value of Phones are on Omarchy 4.0.6 for now, so this is preparation and nothing changes on them when it lands. Thanks! |
Hold the titlebar migration and its exact-Hyprland package dependency, including renamed migrations. Only literal 0 disables generic holds; invalid flag values must not disable phone-critical protection. Print named hold reasons directly. Test the real wrapper with six flag values and semantic/named fixtures. The previous wrapper fails the negative control. Read all packaged 4.5 migration scripts with an inert runner; no phone commands are executed. Co-Authored-By: Codex <codex@openai.com>
b739074 to
1b0447a
Compare
|
Thank you, @marselnenaj. This is everything I asked for: the titlebars migration is held both by number and by package, only an explicit One thing on my side: #478 took 0.1.34 on main earlier today, so I'll merge this as 0.1.35 and fix the title to match. I'll approve the CI run and merge once it's green, and then #471 can rebase onto it. Thanks! |
… the titlebars migration is held (#469) (#486) omamobile-update keeps its phone-critical migration holds on even when OMAMOBILE_HOLD_MIGRATIONS turns the generic holds off, and only an explicit 0 turns those off. Migration 1791403310 (omarchy-hyprland-titlebars, which pins an exact Hyprland and stopped a real 7 Pro's update on #433) is held by number and by pattern: any migration installing a package in rootfs/packages.omarchy-skip. Named holds say why in their own words. Merged as 0.1.35 because #478 shipped 0.1.34. Co-Authored-By: Marsel Nenaj <201385099+marselnenaj@users.noreply.github.com> Co-Authored-By: Codex <codex@openai.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merged through #486 as omamobile-omarchy 0.1.35 (#478 took 0.1.34), you credited as co-author. Thank you, @marselnenaj! #471 can rebase onto main now. |
… the titlebars migration is held (derekross#469) (derekross#486) omamobile-update keeps its phone-critical migration holds on even when OMAMOBILE_HOLD_MIGRATIONS turns the generic holds off, and only an explicit 0 turns those off. Migration 1791403310 (omarchy-hyprland-titlebars, which pins an exact Hyprland and stopped a real 7 Pro's update on derekross#433) is held by number and by pattern: any migration installing a package in rootfs/packages.omarchy-skip. Named holds say why in their own words. Merged as 0.1.35 because derekross#478 shipped 0.1.34. Co-Authored-By: Marsel Nenaj <201385099+marselnenaj@users.noreply.github.com> Co-Authored-By: Codex <codex@openai.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Keep phone-critical migration holds active when only generic desktop holds are disabled. Add migration 1791403310 and the
omarchy-hyprland-titlebarspackage match, because that exact-Hyprland dependency blocked the Pixel 7 Pro update reported in #433. Only the literal value0disables generic holds; empty or malformed values retain the safe default. Named holds now print their own reason instead of “it mentions starts …”.Validation: the actual wrapper passes six flag cases, named and renamed semantic holds, harmless-migration behavior, and unchanged synthetic PAM sentinels. The original published wrapper fails the strengthened negative control. Read-only checks against all 218 scripts in the signed Omarchy 4.5.0-3 package hold all five named migrations with flags
0,1and an invalid value; only an inert runner is executed.The existing updater fixture's free-space mock remains test-only; the production updater and its 10 GiB requirement are unchanged. Phones remain pinned to Omarchy 4.0.6. No phone or migration was run. The proposed package version is provisional; please select the available number at merge.