Repository navigation
omamobile-omarchy 0.1.33: About fits a phone's screen - #431
Conversation
Omarchy's About (omarchy-launch-about, the menu's About) shows the logo (about.txt, 54 columns) beside fastfetch's modules (54 columns), 118 columns in all with the config's padding, and the config turns line wrapping off. A phone's About window is the width of the screen, 63 columns at Omarchy's terminal font on a Pixel 7 Pro, so the logo filled it and every module line was cut to a single character. Patch 0030 gives a terminal narrower than that the logo above the modules (56 columns by 57 rows with Omarchy's logo), and one too small for that as well, such as a phone with its on-screen keyboard up, the modules alone. The room comes from the measurement fit_window already makes (the logo file and fastfetch --logo none), so a window fit_window has sized, as on a desktop, renders as before, and a user's own fastfetch config is left alone. Applies with --fuzz=0 to Omarchy 4.0.6-1 (aarch64); test/patches.py checks the layout chosen at nine terminal sizes against a stand-in fastfetch as big as Omarchy's, and runs About's render loop under script(1) at 61x63, 41x63 and 29x118. Without the patch, the five checks of a narrow terminal fail. The window needs no rule of its own: on Hyprland 0.57 with omamobile-shell 0.2.100, About opens maximized (480x952) and Hyprland refuses the launcher's resize of a maximized window. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TTVics5jHkiz34wzjZWkb9
|
Thank you, @jkjoplin, for a careful, well-tested patch. The measurement reuses what Unfortunately the ground moved under it: Omarchy 4.5.0 landed this week and broke our whole patch series (#434).
Then please take the next free version after 0.1.34 (I'll confirm it at merge) and run About on a phone with |
|
Thanks for checking it against 4.5.0-3, and for the notes on the new launcher. I'll redo 0030 on top of the 0.1.34 port once it's up: through |
|
Thanks, @jkjoplin, and sorry for the back-and-forth. Plans changed the day after my last comment: Omarchy 4.5 turned out to need more than our patch series (the update flow, That makes your patch useful as it is: it's written and tested for 4.0.6, which is what every phone runs. I've checked that it still applies with fuzz 0 to the 4.0.6-1 package and merges cleanly with today's main. So I'd like to merge it as it stands, at the next free version (#469 also uses 0.1.33, so I'll set the number and fix the TOUCH-PLAN line at merge, and leave the session link out of the squash message). No new phone run is needed. For 4.5 later: #471 includes a 4.5 version of 0030 that builds on your patch, and it handles the logo shimmer by skipping it in the compact layouts. I've asked there for it to credit you or leave 0030 to you, so if you'd like to own the 4.5 port, please say so on #471. Thanks again for the careful work and the phone run! |
Omarchy's About draws its logo (54 columns) beside fastfetch's modules (54 columns), which needs 118 columns, and Omarchy's fastfetch config turns line wrapping off. In a phone's About window (63 columns on the Pixel 7 Pro) every module line was cut to a single character. Patch 0030 puts the logo above the modules in a terminal narrower than that, and shows the modules alone in one too small for both, such as with the on-screen keyboard up. A desktop window and a user's own fastfetch config render as before. Checked on the Pixel 7 Pro on 2026-11-04 (Omarchy 4.0.6-1, Hyprland 0.57.0, omamobile-shell 0.2.100): the patch applies through the package's hook, and About shows every box whole at 58 rows by 63 columns and with the keyboard up. The measurement costs one more fastfetch --logo none before the first frame (240-330 ms). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
What and why
Omarchy's About (the menu's About,
omarchy-launch-about) puts the logo (about.txt, 54 columns) beside fastfetch's module boxes (54 columns), 118 columns with the config's padding, and the config turns line wrapping off. On a phone the About window is the width of the screen, 63 columns on the Pixel 7 Pro, so each of the 28 module lines showed only its first character (a box corner or an icon) to the right of the logo. TOUCH-PLAN 3.5: "a compact About layout under 600 px".Patch 0030 has
omarchy-launch-aboutpick the layout from the terminal's size before each draw:--logo-position top, which needs 56 columns and 57 rows with Omarchy's logo;--logo none, the modules alone;fit_windowsizes a desktop window for), a user's own fastfetch config, or no logo file: fastfetch as before.The sizes come from the measurement
fit_windowalready makes (the logo file andfastfetch --logo none), taken again when the logo changes, and the render loop already redraws on every resize, so the layout follows the keyboard going up and down. It costs one morefastfetch --logo nonebefore the first frame: 240-330 ms on the Pixel 7 Pro (three runs). Marked as a candidate for upstream Omarchy: 4.5.0's launcher, reworked since 4.0.6, still has only the side-by-side layout.Numbered 0030 because #420 uses 0029.
No window rule is needed. On Hyprland 0.57 with omamobile-shell 0.2.100, About opens maximized (480x952, 58 rows by 63 columns) through phone.lua's maximize rule, though Omarchy floats it by class. Hyprland also refuses
fit_window's resize and center on that window: sent by hand, they answer "Window is fullscreen" and "No floating window found", and the window stays at 480x952.Device and build
uname -r):7.3.0-rc6-omamobile-push1-g1cb4bd36f3beChecks (no phone needed)
tools/pr-check origin/mainpassestests/allpasses (415 ok; skipped for missing local tools: AOSP mkbootimg twice, dtc, and a root image inout/)tests/packages omamobile-omarchypasses;test/patches.pyapplies the series with--fuzz=0to the real omarchy 4.0.6-1 aarch64 package (28 applied, none upstream), 231 ok, none skippedversionbumped, and the new version is in the commit subjectCo-Authored-By:orAssisted-by:trailer, never aSigned-off-by:The 0030 checks in
test/patches.pyuse a stand-in fastfetch as big as Omarchy's (54x28 modules, a 54x26 logo):--logo-position top,--logo noneand nothing, and a key still closes it.With 0030 moved out of the series, the five checks of a narrow terminal fail and the as-before ones pass.
On the phone
tools/phone-install-package(as 0.1.33-0, so a channel release of 0.1.33-1 replaces it). The package's hook applied 28 patches, and the patched/usr/bin/omarchy-launch-aboutis byte-identical to the one the laptop tests run.fit_windowsizes for; the tests cover 118- and 136-column terminals.fit_windowhas sized the float. If Omarchy's 920x480 float is narrower than 118 columns, the first frame is the stacked layout until the resize redraws it, where it was a cut side-by-side one before.userdata, weakens the storage guard, or reads registers from userspace (AGENTS.md §1)tools/phone-smokereportphone-smoke: cheetah
Kernel
7.3.0-rc6-omamobile-push1-g1cb4bd36f3be, tools ateb5bc2d, 2026-11-04T22:38Z.Packages: hyprland 0.57.0-3.1, libcamera 0.7.2-4.22, mesa 1:26.2.4-1.4, omacam 0.3.3-1, omamessages 0.2.2-1, omamobile-apps 0.2.2-1, omamobile-audio 0.5.13-1, omamobile-device-cheetah 0.1.44-1, omamobile-fingerprint 0.1.15-1, omamobile-firstboot 0.1.3-1, omamobile-gnss 0.2.7-1, omamobile-keyring 20261026-1, omamobile-mirror 0.1.1-1, omamobile-modem 0.1.16-1, omamobile-omarchy 0.1.33-0, omamobile-owl-widgets 0.1.2-1, omamobile-sensors 0.2.1-1, omamobile-shell 0.2.100-1, omaphone 0.2.3-1, omarchy 4.0.6-1, omatel-agent 0.2.4-2, quickshell 0.3.2.r7.g2b4501a-1
"new dmesg errors" is from boot, not this change: every error line in this boot's dmesg is from its first 41 seconds, and the three listed (the AoC mailbox and the modem interface) are at 16-21 s, as the modem stack starts, which it does at boot on a provisioned phone (the 2026.11.03 release notes). About was tested about two hours after boot.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TTVics5jHkiz34wzjZWkb9