Repository navigation
Conversation
…uetooth address rule matches the controller only
80-omamobile-bt-addr.rules matched KERNEL=="hci[0-9]*", which also takes
the bluetooth device each connection adds under the controller (hci0:N,
DEVTYPE link; its parent chain still reaches hci_uart_bcm). So every
connection, such as a pair of headphones or a mouse, started
omamobile-bt-addr@hci0:N.service. The script refuses a name that isn't
hciN ("not a controller"), so nothing changed, but the unit stayed
failed, and tools/phone-smoke reports it.
Match ENV{DEVTYPE}=="host" as well, which only the controller has. Each
package's test checks the rule.
Tested on a Pixel 7, whose local package carries the same rule, with the
new rule loaded from /run/udev/rules.d: udevadm test on hci0 still wants
omamobile-bt-addr@hci0.service. With headphones connected (hci0:11,
DEVTYPE link), udevadm test on the link wants only bluetooth.target, and
no omamobile-bt-addr@hci0:N unit started. Before the change, the same
headphones left omamobile-bt-addr@hci0:6 and @hci0:11 failed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 5, 2026
Owner
|
Thank you, @nesmeck. This is a clean fix with a clear cause: the per-connection devices really are Two things before it goes in, both on my side:
Thanks for spotting this from the smoke reports and fixing it for every phone at once. |
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
80-omamobile-bt-addr.rulesmatchedKERNEL=="hci[0-9]*". That also takes thebluetoothdevice each connection adds under the controller (hci0:N, DEVTYPElink), whose parent chain still reacheshci_uart_bcm. So every connection, such as headphones or a mouse, startedomamobile-bt-addr@hci0:N.service. The script refuses any name that isn'thciN("not a controller"), so nothing changed, but the unit stayed failed, andtools/phone-smokereports it (omarchy-mobile#396's smoke report, and #342).The rule now also requires
ENV{DEVTYPE}=="host", which only the controller has. It's the same one-line change in the three packages that ship the rule, each with a test.Device and build
uname -r):7.3.0-rc6-omamobile-push1-gdb341d1e29e7Checks (no phone needed)
tools/pr-check upstream/mainpassestests/allpassestests/packagespassesversionbumped, and the new version is in the commit subjectCo-Authored-By:orAssisted-by:trailer, never aSigned-off-by:On the phone
/run/udev/rules.d(until the next reboot)udevadm test /sys/class/bluetooth/hci0still givesSYSTEMD_WANTS=omamobile-bt-addr@hci0.service.hci0:11, DEVTYPElink),udevadm teston the link gives onlySYSTEMD_WANTS=bluetooth.target, and noomamobile-bt-addr@hci0:Nunit started. Before the change, the same headphones leftomamobile-bt-addr@hci0:6and@hci0:11failed.hostcomes from the Bluetooth core, not the chip.userdata, weakens the storage guard, or reads registers from userspace (AGENTS.md §1)🤖 Generated with Claude Code