Skip to content

omamobile-modem-sit: opt-in 9a call tuning upload and earpiece audio - #374

Draft
W4HO-ham wants to merge 36 commits into
derekross:mainfrom
W4HO-ham:tegu-call-aec
Draft

W4HO-ham wants to merge 36 commits into
derekross:mainfrom
W4HO-ham:tegu-call-aec

Conversation

@W4HO-ham

@W4HO-ham W4HO-ham commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

On today's main; #371 and #372, which it was stacked on, have merged. This PR's own change is one commit (add opt-in tegu call tuning and earpiece audio); the branch below it holds the earlier forms of what merged, and a merge of main makes the diff that commit alone.

The palmtop's calls work on the speakerphone today, but without echo cancellation the far end hears itself, and there's no way to hold it to the ear. This adds both, off by default.

With [audio] tegu_aec = yes in /etc/omamobile/modem-sit.conf, sitd uploads the owner's own AoC voice tuning (the uplink AEC on/off and downlink protobufs from the phone's factory image) through the AoC's output tuning services before the call's audio starts, waits for each acknowledgement, and turns AEC off again on cleanup. An unknown outcome leaves a marker in /run/omamobile-sit/ and later attempts refuse until a reboot. tools/extract-vendor-firmware -d tegu now copies the six files (speaker and handset, unchanged, checksummed), and extraction fails if any is missing.

tegu_route = earpiece plays through the top speaker at -30 dB with the bottom one at its minimum gain, and needs tegu_aec = yes. Speaker stays the default.

This head by itself has not run on the palmtop. Calls with tegu_aec = yes ran on 2026-11-02 on the heads of #378, which sits on this one: the uploads were confirmed by the AoC and the far end still heard the echo. They are recorded in #378's copy of device/tegu/CALL-AUDIO-TUNING.md ("Results on the palmtop, 2026-11-02"); this branch's copy predates them and still says no trial. The earpiece route hasn't been tried. The plan has the attended runbook (speaker first, the earpiece away from the ear first).

Tests: tests/packages omamobile-modem-sit, tests/extract-tegu-call-tuning, tools/pr-check.

@derekross

Copy link
Copy Markdown
Owner

Thanks for this. It's a lot of careful work, and I like how much of it fails closed: the uncertainty marker for the AoC tuning, the bearer reservations kept for attended recovery, the MMS refusal when the APNs are shared, and the call sink staying muted when cleanup can't be confirmed. Getting audio both ways with the AoC confirming the tuning, and finding the DSP mode, is real progress even though the echo comes back. Since these are drafts, this is direction rather than a merge review, for #374, #375, #376, #378 and #380 together.

Ordering. #356 and my #381 (modem-sit 0.3.20, mmd 0.1.1) are on main now and touch the same files (bringup.py, data_call.py, radio_settings.py, service.py, sit.py, paths.py, mmd's bridge.py), so this chain rebases on top:

#376. The NR-mode part is the same change as in #381; yours also checks the saved file, so keep yours. On the bearer records: your restart test ran on 0.3.9's start-up, which switches the radio off and on, so "the modem lists no bearer" was measured after that cycle. #381 skips the cycle when the radio is already on, so please re-test after the rebase. And clear_stale() also deletes a reservation whose setup never got a reply (including the MMS one #380 says should wait for a reboot); could it leave anything written by a setup without a confirmed outcome? MODEM-PLAN, MODEM-CLIENT and the comment in omamobile-sitd.service still say a second start isn't supported; those should change with the code.

#374 and #378. device/tegu/CALL-AUDIO-TUNING.md still says no phone trial and "command/counter matching". Please record the 2026-11-02 calls there with uname -r and what the far end heard, and note that byte 1 of the reply is the counter, which the check now skips. The kernel commit linked there (253ddb231a89…) isn't on linux-omarchy-mobile; both controls are on omamobile in drivers/soc/google/aoc/alsa/aoc_alsa_ctl.c. Could you also confirm the envelope description was written from what you read, not transcribed from decompiled code? Describing the protocol is fine.

#380. Some of this reaches the 7 Pro, so I'll run it there before it merges: the SIT transport, the binary-SMS change, the apps.db migration, and mmd exporting the bearer's address and DNS. mmd's bus lets everyone read properties, so "never in the world-readable copy" doesn't hold once the bridge republishes them; either reword that or keep the address out of the bridge's properties. For mmsd-tng, CI only runs test/all, so please post an aarch64 build log and the meson test result, and use a neutral placeholder rather than Wholesale.Example in the MMS test.

#374's failed CI run was a mirror download error, so a re-run should clear it. Before any of these leave draft, each needs a tools/phone-smoke report from the 9a with the kernel release.

@W4HO-ham

W4HO-ham commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for going through all five. The chain is rebased on main (with #364, #367, #371 and #372 under it), the versions are left for you, and each point is in the PR it belongs to:

Ordering. The radio-state and signal-decode commits are dropped from #371 and #372. The screen-on at bring-up is 9a-only now (#372): tegu's sitd drop-in sets OMAMOBILE_SIT_SCREEN_ON_AT_START=1, nothing else does, and a test holds the 7 Pro and raven to that. In sit.py, begin() takes manifest_reply and passes all of check()'s arguments, and request() goes through it, so it's the only send path. A new test refuses a do-not-send ID, a SIM_IO without the ISIM opening, a SIM_IO other than the EF_PCSCF read with it, and an unprompted or unopened 0x4600, through both request() and begin(), with nothing written to the socket. On devices (#380): sitd's internet report and the bridge use the device in data-interface, with nothing exported before it's found. The bridge takes the MMS device from sitd's status. A dedicated MMS bearer's device is [mms] interface (default rmnet2), since probing it as the internet one is found needs an answer an MMSC needn't give.

#376. I kept my NR-mode check and folded in the IMS restart fix (DelPdnInfo for the earlier start's PDN before registering again). clear_stale() now clears only records whose setup was confirmed (the response saved). An unanswered reservation, such as MMS's, stays with any IMS registration on it, so activate() refuses and it waits for a reboot. MODEM-PLAN, MODEM-CLIENT and the unit's comment now say what a second start-up does after a clean stop, and that a failed one still means a reboot. The re-test after the rebase needs the palmtop, which is down until the morning.

#374 and #378. CALL-AUDIO-TUNING records the three calls of 2026-11-02 with the kernel release and what the far end heard. It also says the reply's second byte is the counter, which the check skips, and the kernel link now points at omamobile. On where the envelope description came from: I can't confirm it the way you asked. Codex wrote the first version while reading the stock HAL and its AoC library, and it named their internal symbols, so I can't rule out decompiled code behind it. I've rewritten the section from struct CMD_AUDIO_OUTPUT_SET_PARAMETER_BULK and CMD_HDR in our own header, plus what the palmtop's AoC accepted, with no vendor names. The 12-byte envelope layout is still the one Codex found there; I describe it as a protocol and nothing more.

#380. The wording is fixed: the address is kept out of state.json, but the bridge publishes it in Ip4Config, which any system-bus client can read, as with ModemManager. The test uses a neutral placeholder APN. The aarch64 build log and meson test result come in the morning; tonight's build on the palmtop didn't run meson test, and I'll run it on maclab's arm64 VM or the palmtop.

#374's CI should pass on this push. Phone-smoke reports for each come with the next palmtop session.

Select the TAS2572 route only for google,tegu-aoc-snd-card. Save the
controls, verify sink mute, configure the stock microphone/TDM routes,
and start EP4 capture and EP5 playback as mono S16_LE at 8 kHz with
80-frame periods and two periods. Applying ALSA hardware parameters
prepares each PCM once; do not prepare the modem stream twice.

After PCM startup resets the amplifier profile, set both TAS digital
gains to index 180 (-20 dB) and verify read-back before unmuting. A gain
refusal unwinds the route and leaves call signalling available. Close
PCMs before restoring controls, keep mute on cleanup failure, and retain
the cheetah CS35L41 route and the default card=none configuration.

Add fake-ALSA fault tests and the voice-window audit. The existing SRAM
reservation is retained; no CPU mapping or phone operation is added.
Outgoing and incoming speakerphone calls with audio both ways, first on the daily kernel and then on in-tree drivers from the open kernel PRs, where data and a text ran too. The Modem cell says so, and what's left: echo cancellation, an earpiece, the modem's start at boot and the kernel PRs' merge.
Trace the existing app, session agent, ModemManager-compatible bridge and sitd path. Record the tegu installation and unit prerequisites still missing on main, and an attended bridge-only test that preserves the running modem stack.

Document the passing offline bridge and apps package suites, activation and audio limits, and the eventual board-specific image integration.
Keep sitd's canonical name while moving the modem dependency into device-owned policy drop-ins. Tegu checks an already running modem and CP ONLINE; cheetah and raven retain their existing starter relationship. Require the device policy capability during RIL upgrades.

Add an opt-in telephony package with a bridge policy and attended helper. It checks live sitd readiness, refuses legacy unit shadows and competing managers, and starts only mmd and the graphical user's agent. The service recovery check permits live calls and registration loss; no helper enables or recovers the modem.

Remove mmd's service-level conflict so a bridge start cannot stop another modem manager. Package exclusion and D-Bus name ownership remain. Retain the previously developed SIM, safe-release and audio changes in this stack.

Validate the helper, dependency policies and composed units offline; run all seven affected/dependency package suites and build the new architecture-independent package without installing dependencies.
…start the bridge, and a plan that reads as one

Record the palmtop run of Phone and Messages (kernel, versions, what passed, and that opening an app didn't start the agent), say which start fits which case, cite derekross#363 instead of a branch, and drop the lines that read like a task report.
…in 0.1.3, with this pull request

The plan and the README dated the removal of the unit's Conflicts=ModemManager.service to mmd 0.1.1, and the bullet above still listed it as built; this pull request is what removes it, in 0.1.3.
…WantedBy and tmp.mount, and a refusal isn't retried

With derekross#372's boot unit on and this package installed, the bridge's ExecStartPre refused every start: sitd wanted omamobile-mmd.service (the bridge's own WantedBy, once enabled) and both units wanted tmp.mount (systemd adds it). Neither pulls the RIL or the CP into a start, so both are allowed now. A refusal of --service-check exits 3, which the drop-in names in RestartPreventExitStatus=, so a refused bridge stays down instead of retrying every five seconds.
…ot, opt-in

The 9a's modem only started by hand, from a bring-up script outside the package. omamobile-tegu-modem-up is now packaged: the kernel's own CP drivers when it has them, else the bring-up modules; the NV check, then a sleep inhibitor, then the drivers; a latch written before the drivers and cleared at CP ONLINE, so a start that never got there stops later boots until a human looks; the once-per-boot refusal; and with --phone the phone service and, when installed, the Phone and Messages bridge. omamobile-tegu-modem-boot.service runs it at boot, installed but never enabled by the package. A scratch-root test covers the driver choice, the order, the latch and the refusals.
@derekross

Copy link
Copy Markdown
Owner

Thank you for bringing the four drafts back onto main, and for doing it so that each one's diff is only its own change. I checked this one: against today's main it is the tuning upload, its tests, the extractor's six files and the plan, nothing from the PRs that have merged underneath it, and the defaults are still off. CI is green and it merges cleanly.

It stays a draft for now, for the reasons you list yourself. One thing I'd like cleared up in the plan before the trial: CALL-AUDIO-TUNING.md still says "no phone trial" and "Hardware results: not run", and your reply says the far end still hears the echo. If that comes from a call with tegu_aec = yes (on this branch or on #378's), please put that result in the plan, with what was uploaded and what the AoC acknowledged, because a negative result is the most useful thing the plan can hold right now. If it only describes calls without the feature, the plan is right as it is.

When the palmtop is free of the sleep series: the speaker trial first, the earpiece only after it passes and away from the ear, then the smoke report from the head that ran.

Two housekeeping points for when it leaves draft, no hurry: the title still says 0.3.16 and the description still says it is stacked on #372 and that nothing has run. And 0.3.35 is also claimed by #669, #389 and #376, so I'll set the number at merge.

@W4HO-ham W4HO-ham changed the title omamobile-modem-sit 0.3.16: opt-in 9a call echo cancellation and earpiece audio omamobile-modem-sit: opt-in 9a call tuning upload and earpiece audio Nov 12, 2026
@W4HO-ham

Copy link
Copy Markdown
Contributor Author

It comes from calls with tegu_aec = yes, and they are in the plan, but in #378's copy of it, not this branch's. #378's CALL-AUDIO-TUNING.md has "Results on the palmtop, 2026-11-02": three calls to the owner's iPhone on the daily kernel with the six files from the owner's factory image, tegu_route = speaker:

  1. sitd 0.3.18, before the counter fix: the uplink upload accepted with status 0, the reply's counter byte differing, taken for an unknown outcome, the call kept silent as designed.
  2. 0.3.19: both uploads confirmed by the AoC, audio both ways, the far end hearing its own voice come back as without the tuning.
  3. 0.3.20, with Audio DSP Mode at Telephony_APMG3 before the uploads: no echo for the first few seconds and a new low hiss, then the echo back with the hiss still there.

This branch's copy predates those calls, which is why it still says "no phone trial" and "not run": this head by itself has never run on the palmtop, since the first call needed #378's counter fix to be anything but silent. The description says that now, and the title has lost its number.

Not tried on a call yet: the last two commits of #378 (the modem mixer's ASP on, and the tuning sent after the voice streams start), and the earpiece route. The speaker trial comes first, with the owner at the palmtop and on the far end, then the smoke report from the head that ran.

@W4HO-ham

Copy link
Copy Markdown
Contributor Author

The speaker trial ran this evening, and the result is negative again: the far end hears no echo for about the first 2 s of a call and its own voice for the rest.

What ran. omamobile-modem-sit 0.3.37 and omamobile-mmd built on the palmtop from the chain's top (#380's head 0f6bdedf, which holds this PR, #376 and #378 on that day's main), tegu_aec = yes, tegu_route = speaker, the six files from the owner's factory image, the daily kernel (7.3.0-rc6-omamobile-tegu-s2mpg15-m1-g991042e2eff3-dirty), after a clean reboot. One thing had to be added for the build: main's test_attach_bearer fails on a phone whose modem is up (it reads the phone's own rmnet0), so the package was built with #677's test fix on top; nothing else differs from the head. The build before it on the palmtop was from 3 November and lacked #378's last commit.

The calls. Two, from the palmtop to the owner's iPhone, he on the far end: 25 s and 14 s. Both had audio both ways. sitd logged "AoC tegu speakerphone prepared at conservative TAS gain" at each start and "AoC call routes restored" at each end, and no refusal, so both uploads were acknowledged. In his words: he could not hear himself for about the first 2 seconds, then for the rest of the call he could.

So #378's last two changes (the modem mixer's ASP on, tried on 11-03, and the tuning sent after the voice streams start, tried today) leave it where it was: the cancellation works for about 2 s and stops. CALL-AUDIO-TUNING.md on #378 now records both (results 4 and 5) and what to read during the next call: the AoC's own log and the three controls every half second, to see what changes about 2 s in. That needs a call but no listener.

The earpiece route wasn't tried, since the speaker trial didn't pass.

A slip to own on #378's branch: my push 20d19d8b took a merge of main with tests/all still carrying conflict markers; 3da13d71, a minute later, resolves it.

tools/phone-smoke with the build above installed, from its first boot at 01:58Z; the calls were two boots later (02:45Z), with nothing changed in the phone service between:

phone-smoke: tegu

Kernel 7.3.0-rc6-omamobile-tegu-s2mpg15-m1-g991042e2eff3-dirty, tools at e6bc8e3d, 2026-11-12T01:58Z.

Check Result Detail
boot (required) ok kernel 7.3.0-rc6-omamobile-tegu-s2mpg15-m1-g991042e2eff3-dirty, slot b, up 1949s
storage guard (required) ok 62 partitions; only userdata and slot B's boot images writable
root (required) ok ext4 on userdata, 88G free
kernel health (required) ok no oops or BUG; 0 WARN, 0 error lines in dmesg (0 known, 0 new)
systemd units ok none failed
USB gadget (required) ok bound to 11210000.usb
display ok card1-DSI-1 connected, 1080x2424
GPU ok render node on panthor
session (required) ok Hyprland and the Omarchy shell running
lock ok PAM file present, the shell can lock (passwordPam true, locked true)
touch ok Synaptics TouchComm Touchscreen
buttons ok gpio-keys
Wi-Fi ok wlan0 on brcmfmac, link up
Bluetooth ok hci0, powered true
battery ok 88% Unknown, 35 °C
sound cards ok googleteguaocsn
sensors ok Accelerometer AmbientLight Proximity
cameras ok 3 listed by libcamera
thermal ok hottest zone 46 °C

Packages: hyprland 0.57.0-3.3, libcamera 0.7.2-4.23, mesa 1:26.2.4-1.4, omacam 0.3.3-1, omamessages 0.2.2-1, omamobile-apps 0.2.2-1, omamobile-audio 0.5.18-1, omamobile-device-tegu 0.2.16-1, omamobile-fingerprint 0.1.17-1, omamobile-firstboot 0.1.4-1, omamobile-gnss 0.2.9-1, omamobile-keyring 20261026-1, omamobile-mirror 0.1.1-1, omamobile-mmd 0.1.4-1, omamobile-modem 0.1.20-1, omamobile-modem-sit 0.3.37-1, omamobile-omarchy 0.1.43-1, omamobile-owl-widgets 0.1.2-1, omamobile-sensors 0.2.1-1, omamobile-shell 0.2.125-1, omamobile-telephony-tegu 0.1.0-1, omaphone 0.2.3-1, omarchy 4.5.0-3, omatel-agent 0.2.4-2, quickshell 0.3.2.r7.g2b4501a-1.1

@W4HO-ham

Copy link
Copy Markdown
Contributor Author

A wrong time in my comment above: the calls were at 03:45Z (20:45 MST), not 02:45Z. The smoke report's 01:58Z is right.

@derekross

Copy link
Copy Markdown
Owner

Thank you for running the speaker trial with the owner on the far end, and for reporting a negative result as carefully as a positive one: what was built and from which head, that #677 had to go on top to build it, both uploads acknowledged, and his own words for what he heard. Five calls now tell the same story, so "the cancellation holds for about 2 s and then stops" is a finding I trust. Leaving the earpiece untried because the speaker trial didn't pass is the right call.

This stays a draft, and I think you see it the same way. For when you come back to it:

  1. Reading the AoC's own log and the three controls every half second through a call is the right next step, attended as before. What changes at the 2 s mark is the whole question.
  2. On its own this PR ships a switch that can't work: with tegu_aec = yes the call stays silent until omamobile-modem-sit 0.3.19, 0.3.20: the AoC's tuning acknowledgement, and its DSP in telephony mode #378's acknowledgement fix. I'd like omamobile-modem-sit: opt-in 9a call tuning upload and earpiece audio #374 and omamobile-modem-sit 0.3.19, 0.3.20: the AoC's tuning acknowledgement, and its DSP in telephony mode #378 to land together, either as one pull request or with that fix moved down into this one. Tell me which you prefer.
  3. CALL-AUDIO-TUNING.md on this branch still says "no phone trial" and "Hardware results: not run". The five results are in omamobile-modem-sit 0.3.19, 0.3.20: the AoC's tuning acknowledgement, and its DSP in telephony mode #378's copy; whichever lands first should carry them.
  4. It conflicts with main now, only in tests/all. Please take main's loop line as it is and put the new suite on its own two lines at the end of the file, where the "one suite per line" block is, so it doesn't meet anyone else's change again.

One question: the extractor now stops when any of the six tuning files is missing from the image, and every 9a owner runs it, also with the feature off. On which factory builds have you seen all six? If there is any doubt, a warning would be safer than a stop while this is experimental.

A note so it doesn't surprise you: #626 also adds an earpiece route for the 9a, with different levels and a live switch, and the two can't both merge as they are. Two people have now built this for the same phone, so I'd rather not pick from here: could you and #626's author compare the two on the palmtop, levels and switch included, and tell me which design should carry on? I'll take the one you both stand behind, and I'll say the same on #626.

The number is mine to set at merge; 0.3.35 is claimed five times over at the moment.

… is a warning, not a stop

Every 9a owner runs the extractor, with the call tuning off too, and the six files have been seen on one factory build only (BP3A.250905.014). A missing one now leaves the set out whole, since the loader needs a route's three files together, says so, and the rest is extracted and checksummed as before.
tests/all is main's, with the call-tuning extractor's test on its own two lines at the end, in the one-suite-per-line block.
…s it really comes

The first call with echo cancellation on the palmtop went silent. The AoC accepted the tuning upload with status 0, but its reply rewrites the second header byte (0x01 sent, 0x3e back), and the check compared the first six bytes, so a successful upload was taken as an unknown outcome and the call audio stayed muted. The check now compares the first byte, the size and the command ID, and the fake AoC in the tests rewrites that byte as the real one does.

A refused call now also logs why.
…mode for echo cancellation

With the tuning uploaded and confirmed (0.3.19), the far end still heard its own voice: the AoC's output DSP stayed in Ambient during calls, and the uploaded tuning is for its APMg3 telephony mode. With tegu_aec on, the call route now sets Audio DSP Mode to Telephony_APMG3 before the upload and puts the old mode back after the tuning is turned off.

On the palmtop (a speakerphone call to an iPhone, 2026-11-02) this changed what the far end heard: no echo for the first few seconds and a new low hiss, then the echo came back with the hiss still there. So the mode takes effect, but the cancellation doesn't hold yet; the echo reference or the order of the setup is the next thing to check.
…t from our own kernel header

Record the three calls with the kernel release and what the far end heard, describe the command from struct CMD_AUDIO_OUTPUT_SET_PARAMETER_BULK in our GPL header on omamobile rather than from vendor library names, say the reply's counter byte isn't compared and why, and drop the link to a kernel commit that isn't on linux-omarchy-mobile.
The FT AEC reference changes nothing for the built-in microphone, the modem mixer's ASP stays off during our calls, stock applies wideband tuning to narrowband voice, and stock runs a speaker compensation tuner we don't.
With the tuning confirmed and the DSP in its telephony mode, the echo still came back after a few seconds, and AoC Modem Mixer ASP Mode (block 19, where the tuning goes) read ASP_OFF during the calls. With tegu_aec on, the route now sets it to ASP_ON before the upload and restores it after the call. Not yet tried on a call.
With the tuning sent before the streams, the far end heard no echo for 2-3 s and then the echo again, with ASP on and at stock's microphone gain alike (2026-11-03). The AoC starts its voice path at the playback start ("Start voice call" in the kernel log, after our upload), which may set it up afresh. The tuning now goes up after both streams have started, while the call sink is still muted; a failed upload closes the streams and keeps the sink muted as before. Not yet tried on a call.
…12, and the watcher that read them

The results as derekross#378 had them, brought here with the acknowledgement fix so the two land together: the echo after the first seconds in every call, and what the AoC's own log showed on 11-12, that those first seconds are a silent uplink and not cancellation. bringup/call-audio-watch.py is the read-only watcher and call-levels.py reads its output.
@W4HO-ham

Copy link
Copy Markdown
Contributor Author

Thank you. Taking your points in order; the branch is updated.

  1. The AoC's log through a call is done, this morning, and it changes the finding. The seconds without echo aren't cancellation: after each answer the uplink is silent for about 5 s, the palmtop's own side included (the laptop counting aloud beside the palmtop wasn't heard through the phone either), and then it carries everything. Nothing changes in the controls or in the AoC's log a few seconds in, and both uploads arrive and are answered. So "holds for 2 s and then stops" was my misreading of a startup silence, five times over, and the processor has never visibly cancelled. It's results 6 to 8 in CALL-AUDIO-TUNING and my comment on omamobile-modem-sit 0.3.19, 0.3.20: the AoC's tuning acknowledgement, and its DSP in telephony mode #378.
  2. omamobile-modem-sit: opt-in 9a call tuning upload and earpiece audio #374 and omamobile-modem-sit 0.3.19, 0.3.20: the AoC's tuning acknowledgement, and its DSP in telephony mode #378 together: as one pull request, this one. I've brought omamobile-modem-sit 0.3.19, 0.3.20: the AoC's tuning acknowledgement, and its DSP in telephony mode #378's own commits down onto this branch (the acknowledgement fix, the DSP mode, ASP on, the tuning after the streams' start, and the results), so the switch here can work, and I'll close omamobile-modem-sit 0.3.19, 0.3.20: the AoC's tuning acknowledgement, and its DSP in telephony mode #378. omamobile-modem-sit: a second start in the same boot gets data and IMS back #376 doesn't come with it; apart from its files and main's own changes, the modem service on this branch is what omamobile-modem-sit 0.3.19, 0.3.20: the AoC's tuning acknowledgement, and its DSP in telephony mode #378 had.
  3. CALL-AUDIO-TUNING here is omamobile-modem-sit 0.3.19, 0.3.20: the AoC's tuning acknowledgement, and its DSP in telephony mode #378's copy now, with all eight results.
  4. tests/all is main's as it is, with the extractor's test on its own two lines at the end of the one-suite-per-line block.

Your question on the six files: I've seen all six on one factory build only, the palmtop's own (BP3A.250905.014). That is no basis for a stop, so a missing one is a warning now: the set is left out whole, since the loader needs a route's three files together, the warning names the file, and everything else is extracted and checksummed as before. tests/extract-tegu-call-tuning covers both cases.

On #626: yes. I'll read it, and its author and I can compare the two on the palmtop, levels and switch included. One thing I can say already from this morning: with the tuning on, the echo comes back louder than with it off (a talking clock as the far end, the uplink's samples in the AoC's log: about 130 against a downlink of 2,000 with the tuning off, 4,000 to 8,000 with it on), so until the cancellation works an earpiece route is the part of this that helps a caller, and a live switch matters more than I gave it.

It stays a draft. What I'm trying next for the echo is in "Next for the echo"; a call to a talking clock shows the echo in the AoC's log with nobody listening, so the tries don't need a far end.

tests/packages omamobile-modem-sit, tests/extract-tegu-call-tuning and tools/pr-check origin/main pass on this head.

…th the speakers at 0 and with the reference recorded

Four more results from 2026-11-12. Without the tuning the uplink stays low through the clock's tone; with it the uplink is quiet most of the time and breaks through in bursts of several thousand; with the speakers at 0 the bursts are gone, so the echo is acoustic; and the processor's reference capture carries the downlink. The next steps are brought up to date.
@derekross

Copy link
Copy Markdown
Owner

Thank you. This was a lot of work in a day, and the result that matters most is a negative one found honestly: the two seconds without echo that five calls agreed on were a silent uplink after the answer, not cancellation. You found that with a watcher that only reads, checked it with a voice beside the palmtop, and then found a way to see the echo in the AoC's own log with nobody listening. Owning "my misreading, five times over" in the plan is exactly how I'd want it written.

On the points from last time:

  1. The AoC's log through a call: done, and it changed the finding (results 6 to 12).
  2. omamobile-modem-sit: opt-in 9a call tuning upload and earpiece audio #374 and omamobile-modem-sit 0.3.19, 0.3.20: the AoC's tuning acknowledgement, and its DSP in telephony mode #378 together, here: done. I compared the files: voice_audio.py and aoc_tuning.py on this head are byte for byte the ones in the build that made the calls of 11-11 and 11-12.
  3. The plan has the results now.
  4. tests/all: you did what I asked, and it conflicts again, because another pull request appended at the same end of the file. That's on my advice, not on you. When you next merge main: keep main's two install-guided lines and put yours after them. The second conflict is in tools/extract-vendor-firmware, where main now sorts with LC_ALL=C: keep your loop and end it with done | LC_ALL=C sort > "$stage/expected". I resolved both that way in a scratch copy, and the phone service's tests and tests/extract-tegu-call-tuning pass on the result.

Thank you for the plain answer on the six files (one factory build), and for turning the stop into a warning that leaves the set out whole.

It stays a draft, as you say. What I'd like before it leaves draft:

  • The top of the plan and the shipped comment should say where this stands. The plan's status is still the 11-03 one, "Missing any of these six fails extraction" is no longer true, and modem-sit.conf says "keep off until an attended trial". The trial has run: with tegu_aec = yes the echo isn't cancelled and comes through in louder bursts. Please say that in both places. If the cancellation can't be made to hold, I'd take a narrower pull request with what is proven (the transport, the extractor and the plan) over a switch that makes calls worse.
  • The earpiece route requires tegu_aec = yes. Given results 9 and 10, is that still right? You wrote yourself that the earpiece is the part that helps a caller today. Please settle it together with the comparison with omamobile-modem-sit 0.3.45: switch call audio between loudspeaker and earpiece (9a) #626 rather than separately; I still want one design from the two of you.
  • Two capture tries ended in errors, and I'd like to know more before the next one. Result 12 (hw:0,27, "Bad address", the call ended 48 s in) and the in-call capture that ended in EIO with the kernel log not kept. Did the capture end the call? Was the AoC still online afterwards? Was someone at the palmtop? On the 7 Pro a wrong capture route during audio took the AoC down until a reboot, so please treat each AoC capture that hasn't run during a call before as a first probe: one per boot, the kernel log streamed to the laptop first, and attended. The same question for results 8 to 11: the plan's own gate says attended, and result 8 says nobody was near it.
  • Edited tuning files. Result 10 uploaded a copy of the uplink tuning with one field changed, and "Next" plans more. That's a fair experiment on the microphone side. Please write the rule into the plan: only uplink files are edited, never a downlink one (that is the speaker's path), the owner's file goes back and is checked against vendor-firmware.sha256, and an edited file is never committed.
  • Small ones: the two new scripts under device/tegu/bringup/ need their # SPDX-License-Identifier: MIT line. And VoiceAudio.__init__ now checks tegu_route on every phone, so a typo in that key would leave a Pixel 7 Pro's call without audio; please check it only on the 9a's route.
  • A tools/phone-smoke report from the head that runs, as before.

One thing is mine to answer and I haven't: on 11-05 I said I'd come back to you on the protocol description. The section still names the stock HAL's internal functions in two places and describes what one of them does. I'll tell you in a separate comment what can stay and what should go; please don't spend time on it until then.

The version is mine to set at merge.

tests/all keeps main's install-guided lines with the call tuning test after them; tools/extract-vendor-firmware keeps the loop that leaves an absent optional set out and sorts with LC_ALL=C, as main now does.
…ning stands, and the route key checked only on the 9a

The plan's status and the shipped comment said the trial was still to run.
It has: the AoC takes the tuning and the echo isn't cancelled; with it the
echo comes through in louder bursts. Both say so now, and that tegu_aec
stays off. The plan no longer says a missing tuning file fails extraction
(the set is optional and left out whole), and it has the rules for the
tests that are left: an AoC capture new to a call is a first probe, one per
boot, attended, with the kernel log streamed first; only uplink tuning
files are edited, and the owner's file goes back and is checked.

VoiceAudio checked tegu_route on every phone, so a typo in that key would
have left a Pixel 7 Pro's call without audio. It is checked on the 9a's
route only. The two bring-up scripts get their SPDX lines.
@W4HO-ham

Copy link
Copy Markdown
Contributor Author

Thank you. Two commits: the merge of main (58adf61) and e01f78e.

  • The merge. Both conflicts resolved as you describe: main's two install-guided lines with the call tuning test after them, and the loop kept with done | LC_ALL=C sort > "$stage/expected". tests/extract-tegu-call-tuning and the phone service's tests pass on the result.
  • Where it stands, in the plan's status and in modem-sit.conf: the trial has run, the AoC takes the tuning, the echo isn't cancelled and comes through in louder bursts, and tegu_aec stays off. The plan no longer says a missing file fails extraction.
  • tegu_route is checked only when the card is the 9a's, with a test: a typo in the key on another phone builds the audio route as before, and on the 9a it is refused.
  • The two scripts have their SPDX lines.
  • The rule for edited tuning files is in the plan: uplink files only, never a downlink one, the owner's file back and checked against vendor-firmware.sha256 after each call, an edited file never committed.

Your questions on the two captures, from the record:

  • Result 12 (hw:0,27, "Bad address"): the call ended 48 s in, where the other clock calls that morning ran 80 to 110 s, so the capture may well have ended it; I can't show it didn't. The AoC was still online afterwards: the next call, four minutes later on the same boot, had call audio and the uplink samples of result 11, and the phone service read registered after both.
  • The in-call capture that ended in EIO: no kernel log was kept, and whether the AoC was online after it wasn't recorded. I don't know more than that.
  • Who was there: nobody. Result 8 says so, and nobody was asked to be at the palmtop for 9 to 12 either. That was against the plan's own gate, and the plan says so now. The rule you ask for is in it: an AoC capture that hasn't run during a call before is a first probe, one per boot, attended, with the kernel log streamed to the laptop first.

Still open, and it stays a draft:

  • The earpiece route and tegu_aec = yes, together with the comparison with omamobile-modem-sit 0.3.45: switch call audio between loudspeaker and earpiece (9a) #626. I haven't settled it and won't separately.
  • The tools/phone-smoke report from the head that runs; it comes with the next attended call test.
  • The narrower pull request (the transport, the extractor and the plan, without a switch that makes calls worse) is where I expect this to end if the next tests don't make the cancellation hold. I'll say so here when I get there.
  • The protocol description waits for your comment, as you ask.

# Conflicts:
#	packages/omamobile-modem-sit/version
#	tests/all
@W4HO-ham W4HO-ham mentioned this pull request Nov 13, 2026
10 of 14 tasks
@derekross

Copy link
Copy Markdown
Owner

Thank you. Everything I asked for on the 13th that was yours is in: the plan and the shipped comment now say plainly that the tuning doesn't cancel the echo and that tegu_aec stays off, the rules for captures and for edited tuning files are written down, the route key is only checked on the 9a, and the scripts have their licence lines. Thank you also for the straight account of results 8 to 12: nobody was at the palmtop, against the plan's own gate, and the plan says so. Please keep to that gate from here on.

Where this stands now:

And one thing is still mine: the comment on the protocol description, which I've now promised twice. It comes next; please don't spend time on that section until then.

omamobile-modem-sit is 0.3.46 here, after main's 0.3.44 and derekross#837's 0.3.45; the audio defaults keep this branch's tegu_route and tegu_aec beside main's control follow_screen.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants