Repository navigation
omamobile-shell 0.2.98: the user setup makes Omarchy's default keyring - #397
Merged
Merged
Conversation
Omarchy's installer gives each user an unlocked default keyring, but a phone user is made without that installer, so on the Pixel 9a Chromium's first start opened an oversized "Choose password for new keyring" prompt that the palmtop couldn't get past. The user setup now runs Omarchy's own default-keyring step, which creates only what is missing. The step is an if-block, so the script still succeeds when a later Omarchy moves the file, with a test for that.
derekross
added a commit
that referenced
this pull request
Nov 3, 2026
… 0.2.99 over 0.2.97 Main took omamobile-modem-sit 0.3.28 (#364, the unconfirmed-hangup stop) and omamobile-shell 0.2.97 (#394); #397 lands shell 0.2.98. This branch keeps 0.3.29 and moves the shell to 0.2.99. tools/sit-sim keeps both #364's --unconfirmed-hangup and this branch's --imsi-plmn/--no-imsi in the usage block and the argument list. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d
derekross
added a commit
that referenced
this pull request
Nov 3, 2026
…0: review round 2, the modem-up guard bounded The review of #398 asked for three changes and a few corrections. The self-clearing modem-up guard was unbounded: a phone that hangs because the modem is up went up, hang, refused, up, hang, refused, for ever, with only a tile line on the boots in between. Now the refused copy the script already keeps is the counter: one automatic retry, then a hold. refuse_unclean keeps the marker and refuses "(held)" when a modem-up.refused-* copy exists (no clean stop since the last refusal); --stopped on this boot's marker removes the copies, so a clean stop resets the count; --retry clears both markers and the copies. The test's "four unclean boots in a row" block becomes "the second refusal holds, a clean stop resets", and M4.6b gets drill B9b for it. systemctl is-enabled reads "disabled" for a unit started by a vendor wants link alone (it reports /etc and /run links only), so B6's pass and stop lines expected the wrong answer and would have stopped a correct install; B6 now expects "enabled" before and "disabled" after the disable, and proves the link with ls -l of the /usr/lib link and systemctl list-dependencies --plain multi-user.target. The README, the target's header and the install message say the same, so nobody reads "disabled" and skips the mask. The read-only NV checksum check (M3.5) opens B6 as well as closing the runbook (AGENTS.md section 1). B8's is-active expectation is "failed inactive inactive active" (mmd runs). omamobile-shell takes 0.2.100: main is 0.2.98 after #397 and #373 is taking 0.2.99. The DEVICES cheetah fingerprint cell reads "works": #358 made it on by default. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d
derekross
added a commit
that referenced
this pull request
Nov 3, 2026
…0: the Pixel 7 Pro's modem stack on by default (#398) * omamobile-modem 0.1.16, device-cheetah 0.1.43, omamobile-shell 0.2.98: the Pixel 7 Pro's modem stack on by default The maintainer's decision of 2026-11-03: the next release ships the modem working out of the box (calls, texts and data on the tested network, M4.6 through three reboots). The switch of M4.6, omamobile-modem-boot.target, is now on by default on cheetah, and a boot that can't or shouldn't start the modem costs as little as possible: - omamobile-device-cheetah 0.1.43 enables the target with a vendor wants link under multi-user.target.wants, as it does for the AoC and Wi-Fi units; the four units the target wants get no link of their own, and omamobile-modem itself still enables nothing (its test holds it to that; tegu and raven are untouched). Off: systemctl mask the target. The stack's packages (omamobile-modem-sit, omamobile-mmd) join cheetah's ROOTFS_PACKAGES so the release image carries them. - A phone that isn't provisioned costs nothing: the modem and inhibit units carry ConditionPathExists= for the chroot, the NV checksums and the board id (what tools/phone-provision puts there), so both are skipped, not failed, and the inhibitor isn't held. The inhibitor needs its own copy because the modem unit's Requires= pulls it in even when that unit's conditions skip it. sitd skips itself without /dev/umts_ipc0; sit-data now does too, through a device drop-in: without it a condition-skipped sitd counted as started for sit-data's Requires=, and the fallback would have failed after 60 s and restarted every 10 s all boot. The start script checks the same three paths first, for a start by hand. - The modem-up guard clears itself after one refused boot: a stale marker still refuses that boot and logs where to look (journalctl -b -1), then moves to modem-up.refused-<time>-<pid> (the last three kept) so the next boot starts the modem again. A phone that hangs with the modem up every time loses the modem on every other boot at most, never for good. /etc/omamobile/modem-hold restores the old hard stop; --retry still clears both markers; the bring-up latch keeps its hard stop. - Every refusal leaves one short line in /run/omamobile/modem-refused, and the shell's Mobile data tile shows it under its name instead of "No modem" (omamobile-shell 0.2.98, tile-state.sh): no new notification path, the journal has the rest. Versions: #372 and #380 claim device-cheetah 0.1.42, #389 omamobile-modem 0.1.14 and #382 0.1.15, main has omamobile-shell 0.2.97 (#394); hence 0.1.43, 0.1.16 and 0.2.98. Docs: RELEASES (ROOTFS_PACKAGES, decision 12 amended, checklist step 6), the release notes draft (the modem known issue becomes what works and what still needs a hand), INSTALL, DEVICES, and MODEM-PLAN M4.6b with the runbook: install, two reboots, a refused-boot drill by planting a stale marker, the hold flag. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d * omamobile-modem 0.1.16, device-cheetah 0.1.43, omamobile-shell 0.2.100: review round 2, the modem-up guard bounded The review of #398 asked for three changes and a few corrections. The self-clearing modem-up guard was unbounded: a phone that hangs because the modem is up went up, hang, refused, up, hang, refused, for ever, with only a tile line on the boots in between. Now the refused copy the script already keeps is the counter: one automatic retry, then a hold. refuse_unclean keeps the marker and refuses "(held)" when a modem-up.refused-* copy exists (no clean stop since the last refusal); --stopped on this boot's marker removes the copies, so a clean stop resets the count; --retry clears both markers and the copies. The test's "four unclean boots in a row" block becomes "the second refusal holds, a clean stop resets", and M4.6b gets drill B9b for it. systemctl is-enabled reads "disabled" for a unit started by a vendor wants link alone (it reports /etc and /run links only), so B6's pass and stop lines expected the wrong answer and would have stopped a correct install; B6 now expects "enabled" before and "disabled" after the disable, and proves the link with ls -l of the /usr/lib link and systemctl list-dependencies --plain multi-user.target. The README, the target's header and the install message say the same, so nobody reads "disabled" and skips the mask. The read-only NV checksum check (M3.5) opens B6 as well as closing the runbook (AGENTS.md section 1). B8's is-active expectation is "failed inactive inactive active" (mmd runs). omamobile-shell takes 0.2.100: main is 0.2.98 after #397 and #373 is taking 0.2.99. The DEVICES cheetah fingerprint cell reads "works": #358 made it on by default. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d * omamobile-modem 0.1.16: the start script's test stops after the marker decision The case "the boot after a refused one starts the modem again" (and the --retry case) ran lib/omamobile-modem-start past the marker refusals and relied on the machine to stop it: on the laptop and in CI no sleep inhibitor is held, so the script refused there before any driver. On the phone, where tools/phone-install-package builds the package as an unprivileged user, the inhibitor is held, so the test went on into the real bring-up and failed on /sys/module/pcie_aspm/parameters/policy (permission denied) and then on omamobile-vendor's "run as root". The script takes a test-only OMAMOBILE_MODEM_TEST_STOP_AFTER_CHECKS=1 (documented in its header; no unit or install step sets it) and exits 0 right after the marker decision, before the link driver's sysfs read, the inhibitor wait, the first modprobe and the profile. The two cases use it and assert the decision itself: exit 0, the stale marker moved aside with its refused copy kept, no latch written, the earlier reason left for the tile (it is removed only once every refusal has passed, which the stop point comes before). The test also checks that the stop point sits between the marker decision and the sysfs read, the inhibitor and the latch, and that no unit sets the variable. Verified: packages/omamobile-modem/test/all as uid 1000, with and without a systemd-inhibit stand-in that reports the inhibitor held (the phone's case); tools/pr-check origin/main. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d * release notes: the carrier APNs come from the SIM, not by hand Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
derekross#397, from derekross#343) Omarchy's installer gives each user an unlocked default keyring, but a phone user is made without that installer, so on the Pixel 9a Chromium's first start opened an oversized "Choose password for new keyring" prompt that the palmtop couldn't get past. The user setup now runs Omarchy's own default-keyring step, which creates only what is missing. The step is an if-block, so the script still succeeds when a later Omarchy moves the file, with a test for that. Co-authored-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
…0: the Pixel 7 Pro's modem stack on by default (derekross#398) * omamobile-modem 0.1.16, device-cheetah 0.1.43, omamobile-shell 0.2.98: the Pixel 7 Pro's modem stack on by default The maintainer's decision of 2026-11-03: the next release ships the modem working out of the box (calls, texts and data on the tested network, M4.6 through three reboots). The switch of M4.6, omamobile-modem-boot.target, is now on by default on cheetah, and a boot that can't or shouldn't start the modem costs as little as possible: - omamobile-device-cheetah 0.1.43 enables the target with a vendor wants link under multi-user.target.wants, as it does for the AoC and Wi-Fi units; the four units the target wants get no link of their own, and omamobile-modem itself still enables nothing (its test holds it to that; tegu and raven are untouched). Off: systemctl mask the target. The stack's packages (omamobile-modem-sit, omamobile-mmd) join cheetah's ROOTFS_PACKAGES so the release image carries them. - A phone that isn't provisioned costs nothing: the modem and inhibit units carry ConditionPathExists= for the chroot, the NV checksums and the board id (what tools/phone-provision puts there), so both are skipped, not failed, and the inhibitor isn't held. The inhibitor needs its own copy because the modem unit's Requires= pulls it in even when that unit's conditions skip it. sitd skips itself without /dev/umts_ipc0; sit-data now does too, through a device drop-in: without it a condition-skipped sitd counted as started for sit-data's Requires=, and the fallback would have failed after 60 s and restarted every 10 s all boot. The start script checks the same three paths first, for a start by hand. - The modem-up guard clears itself after one refused boot: a stale marker still refuses that boot and logs where to look (journalctl -b -1), then moves to modem-up.refused-<time>-<pid> (the last three kept) so the next boot starts the modem again. A phone that hangs with the modem up every time loses the modem on every other boot at most, never for good. /etc/omamobile/modem-hold restores the old hard stop; --retry still clears both markers; the bring-up latch keeps its hard stop. - Every refusal leaves one short line in /run/omamobile/modem-refused, and the shell's Mobile data tile shows it under its name instead of "No modem" (omamobile-shell 0.2.98, tile-state.sh): no new notification path, the journal has the rest. Versions: derekross#372 and derekross#380 claim device-cheetah 0.1.42, derekross#389 omamobile-modem 0.1.14 and derekross#382 0.1.15, main has omamobile-shell 0.2.97 (derekross#394); hence 0.1.43, 0.1.16 and 0.2.98. Docs: RELEASES (ROOTFS_PACKAGES, decision 12 amended, checklist step 6), the release notes draft (the modem known issue becomes what works and what still needs a hand), INSTALL, DEVICES, and MODEM-PLAN M4.6b with the runbook: install, two reboots, a refused-boot drill by planting a stale marker, the hold flag. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d * omamobile-modem 0.1.16, device-cheetah 0.1.43, omamobile-shell 0.2.100: review round 2, the modem-up guard bounded The review of derekross#398 asked for three changes and a few corrections. The self-clearing modem-up guard was unbounded: a phone that hangs because the modem is up went up, hang, refused, up, hang, refused, for ever, with only a tile line on the boots in between. Now the refused copy the script already keeps is the counter: one automatic retry, then a hold. refuse_unclean keeps the marker and refuses "(held)" when a modem-up.refused-* copy exists (no clean stop since the last refusal); --stopped on this boot's marker removes the copies, so a clean stop resets the count; --retry clears both markers and the copies. The test's "four unclean boots in a row" block becomes "the second refusal holds, a clean stop resets", and M4.6b gets drill B9b for it. systemctl is-enabled reads "disabled" for a unit started by a vendor wants link alone (it reports /etc and /run links only), so B6's pass and stop lines expected the wrong answer and would have stopped a correct install; B6 now expects "enabled" before and "disabled" after the disable, and proves the link with ls -l of the /usr/lib link and systemctl list-dependencies --plain multi-user.target. The README, the target's header and the install message say the same, so nobody reads "disabled" and skips the mask. The read-only NV checksum check (M3.5) opens B6 as well as closing the runbook (AGENTS.md section 1). B8's is-active expectation is "failed inactive inactive active" (mmd runs). omamobile-shell takes 0.2.100: main is 0.2.98 after derekross#397 and derekross#373 is taking 0.2.99. The DEVICES cheetah fingerprint cell reads "works": derekross#358 made it on by default. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d * omamobile-modem 0.1.16: the start script's test stops after the marker decision The case "the boot after a refused one starts the modem again" (and the --retry case) ran lib/omamobile-modem-start past the marker refusals and relied on the machine to stop it: on the laptop and in CI no sleep inhibitor is held, so the script refused there before any driver. On the phone, where tools/phone-install-package builds the package as an unprivileged user, the inhibitor is held, so the test went on into the real bring-up and failed on /sys/module/pcie_aspm/parameters/policy (permission denied) and then on omamobile-vendor's "run as root". The script takes a test-only OMAMOBILE_MODEM_TEST_STOP_AFTER_CHECKS=1 (documented in its header; no unit or install step sets it) and exits 0 right after the marker decision, before the link driver's sysfs read, the inhibitor wait, the first modprobe and the profile. The two cases use it and assert the decision itself: exit 0, the stale marker moved aside with its refused copy kept, no latch written, the earlier reason left for the tile (it is removed only once every refusal has passed, which the stop point comes before). The test also checks that the stop point sits between the marker decision and the sysfs read, the inhibitor and the latch, and that no unit sets the variable. Verified: packages/omamobile-modem/test/all as uid 1000, with and without a systemd-inhibit stand-in that reports the inhibitor held (the phone's case); tools/pr-check origin/main. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d * release notes: the carrier APNs come from the SIM, not by hand Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
W4HO-ham's #343, cherry-picked onto main unchanged (author kept) with the version set to 0.2.98, because #394 took 0.2.97 after #343 was rebased to 0.2.95; the only difference from #343 is the version file. Supersedes #343.