Skip to content

omamobile-shell 0.2.98: the user setup makes Omarchy's default keyring - #343

Closed
W4HO-ham wants to merge 1 commit into
derekross:mainfrom
W4HO-ham:shell-default-keyring
Closed

W4HO-ham wants to merge 1 commit into
derekross:mainfrom
W4HO-ham:shell-default-keyring

Conversation

@W4HO-ham

@W4HO-ham W4HO-ham commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

On the palmtop (Pixel 9a), Chromium's first start opened GNOME Keyring's "Choose password for new keyring" prompt, scaled far past the screen, and nothing behind it could be reached. The user had no default keyring: Omarchy's installer makes one for each user (install/user/default-keyring.sh, an unencrypted keyring that never locks, so nothing asks for a password the autologin never types), but a phone user is made by our setup, not that installer.

omamobile-setup-user now runs Omarchy's own script from $OMARCHY_PATH (default /usr/share/omarchy) when it's there. That script creates only the files that are missing, so a user who already has a default keyring keeps it, and later logins change nothing. It isn't an omarchy-done step for that reason.

Tested on the palmtop: I closed the prompt, ran Omarchy's script as the session user and restarted gnome-keyring-daemon. Chromium then started with no prompt, and the owner has used it since. test/setup-user.sh gains a case with a stand-in for Omarchy's script: a new user gets the default keyring, and a user's own default file is kept. packages/omamobile-shell/test/all and tools/pr-check pass.

@derekross

Copy link
Copy Markdown
Owner

Heads-up: #344 just landed as omamobile-shell 0.2.79 (the Hyprland 0.57 transparency fix), so this PR needs packages/omamobile-shell/version bumped to 0.2.80, and the title to match, before it can merge. Two PRs at the same version merge without a conflict, and the second one would then never be published. Thanks!

@W4HO-ham
W4HO-ham force-pushed the shell-default-keyring branch from e035c53 to 6ba3b8f Compare November 2, 2026 19:07
@W4HO-ham W4HO-ham changed the title omamobile-shell 0.2.79: the user setup makes Omarchy's default keyring omamobile-shell 0.2.80: the user setup makes Omarchy's default keyring Nov 2, 2026
@derekross

Copy link
Copy Markdown
Owner

Thank you, @W4HO-ham, and thanks for the quick bump to 0.2.80. Running Omarchy's own
default-keyring step rather than writing our own copy is the right call: the phone gets
exactly what a desktop install gets, and a user who already has a default keyring keeps it.
CI's policy check passes, tools/pr-check is clean here, and the branch merges cleanly onto
today's main.

One small change, please. The new last line of omamobile-setup-user,
[[ -f $keyring ]] && bash "$keyring", makes the whole script exit 1 when the file isn't
there: the [[ ]] test fails, and as the last command its status becomes the script's. With
Omarchy 4.0.6 the file exists, so nothing shows today, but if a later Omarchy moves it, the
setup unit would fail at every login. Could you write it as
if [[ -f $keyring ]]; then bash "$keyring"; fi, and add a test case with OMARCHY_PATH
pointing at an empty folder that expects the script to succeed?

One note for the record, nothing to change: Omarchy's script makes a plaintext keyring
(no password, never locked), so it's "unencrypted" rather than just "unlocked". That matches
Omarchy on the desktop, and I'm fine with it for now.

A heads-up on timing: a release is being published right now, so I'll merge package bumps
once it's promoted. I'll also check what the keyring folder looks like on my Pixel 7 Pro
first, since this reaches every phone at the next login.

@W4HO-ham

W4HO-ham commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

Thanks, Derek. Done: rebased onto #344, with packages/omamobile-shell/version at 0.2.80 and the title to match (head 6ba3b8f). test/setup-user.sh and tools/pr-check pass on it, and CI is green.

@W4HO-ham
W4HO-ham force-pushed the shell-default-keyring branch from 6ba3b8f to 71fd5c2 Compare November 3, 2026 00:05
@W4HO-ham W4HO-ham changed the title omamobile-shell 0.2.80: the user setup makes Omarchy's default keyring omamobile-shell 0.2.87: the user setup makes Omarchy's default keyring Nov 3, 2026
@W4HO-ham

W4HO-ham commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Thanks, Derek. Done (71fd5c2): the step is now if [[ -f $keyring ]]; then bash "$keyring"; fi, and test/setup-user.sh has a case with OMARCHY_PATH pointing at an empty folder that expects the setup to succeed and make no keyring (it uses the runner's RUN_OMARCHY_PATH from #355). The comment now says "unencrypted". Rebased onto today's main, so the version is 0.2.87 (#359 and the others took up to 0.2.86) and the title follows. packages/omamobile-shell/test/all and tools/pr-check pass. Merging after the release is promoted is fine.

@W4HO-ham
W4HO-ham force-pushed the shell-default-keyring branch from 71fd5c2 to 0fbdcb3 Compare November 3, 2026 02:23
@W4HO-ham W4HO-ham changed the title omamobile-shell 0.2.87: the user setup makes Omarchy's default keyring omamobile-shell 0.2.93: the user setup makes Omarchy's default keyring Nov 3, 2026
@derekross

Copy link
Copy Markdown
Owner

Thanks, @W4HO-ham. Both changes are in exactly as asked: the if … fi form, and the test with OMARCHY_PATH on an empty folder, which really does take that branch through RUN_OMARCHY_PATH. I also checked the stand-in against Omarchy's real default-keyring.sh: it only creates what's missing, so running it at every login is fine.

Main has moved again (#377 took omamobile-shell 0.2.94), so the version file conflicts. Could you merge main and set packages/omamobile-shell/version to 0.2.95 (and the title to match)? It's the only change needed; I'll merge as soon as it's in. One thing to keep an eye on: on a fresh install, could you watch whether Chromium's first start is prompt-free without restarting gnome-keyring-daemon, as your palmtop test did?

@W4HO-ham
W4HO-ham force-pushed the shell-default-keyring branch from 0fbdcb3 to 56fb9e7 Compare November 3, 2026 05:40
@W4HO-ham W4HO-ham changed the title omamobile-shell 0.2.93: the user setup makes Omarchy's default keyring omamobile-shell 0.2.95: the user setup makes Omarchy's default keyring Nov 3, 2026
@W4HO-ham

W4HO-ham commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Done: rebased on main, packages/omamobile-shell/version is 0.2.95, title to match. I'll watch Chromium's first start on the next fresh install.

derekross added a commit that referenced this pull request Nov 3, 2026
…1-03 keys (modem-sit 0.3.29, mmd 0.1.2, shell 0.2.96)

main moved under this PR (#384, #386, #387, #388): modem-sit 0.3.24-0.3.27
brought attach_apn = none, ims_first, internet_cid, [profiles],
carrier_manifest and ims_pcscf_from_isim, and the internet bearer's rmnet
device is now found by omamobile-sit-data. Where both sides changed the
same thing, main's code wins: bringup.start() is main's order with the
carrier lookup in front of it (the SIM read once after the USIM is READY,
what isn't typed comes from the lookup); data_network.py is main's device
search with this PR's roaming check on the device found; paths.py, sit.py,
modem-sit.conf and test_bringup.py merged by hand.

What registered IMS and carried calls and texts on the 7 Pro on
2026-11-03 (NOTES, IMS-SHANNON 11-12) was five typed values beyond the
APN, so the lookup now produces them: an override section carries
attach_apn (an APN or none), ims_apn, ims_first, internet_cid and
profile_<ID> lines, and "like = MCC/MNC" lets a carrier's codes share one
section. ims_apn, ims_first and internet_cid default to auto; an empty
[profiles] takes the override's set. Verizon's codes give apn =
VZWINTERNET, attach_apn = none, ims_apn = IMS, ims_first = yes,
internet_cid = 3 and stock's four profiles. The 11-02 value attach_apn =
vzwims registered but never got IMS: gone, and the file says why. mmd
treats none as no attach settings; the Mobile network page shows it as
"Not sent: the carrier profile's own".

Versions: modem-sit 0.3.29 (main 0.3.27, #389 claims 0.3.28), mmd 0.1.2
(main 0.1.1), shell 0.2.96 (main 0.2.94, #343 claims 0.2.95).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d
@derekross

Copy link
Copy Markdown
Owner

Thanks, that's everything: 0.2.95 with the title to match, rebased on main, and the setup-user test still passes here with both keyring cases. Merging; I'll set the version at merge if another shell bump landed first.

Omarchy's installer gives each user an unlocked default keyring, but a phone user is made without that installer, so on the Pixel 9a Chromium's first start opened an oversized "Choose password for new keyring" prompt that the palmtop couldn't get past. The user setup now runs Omarchy's own default-keyring step, which creates only what is missing.

The step is an if-block, so the script still succeeds when a later Omarchy moves the file, with a test for that.
@W4HO-ham
W4HO-ham force-pushed the shell-default-keyring branch from 56fb9e7 to 6ba424a Compare November 3, 2026 14:09
@W4HO-ham W4HO-ham changed the title omamobile-shell 0.2.95: the user setup makes Omarchy's default keyring omamobile-shell 0.2.98: the user setup makes Omarchy's default keyring Nov 3, 2026
@W4HO-ham

W4HO-ham commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Rebased again: #394 took 0.2.97, so this is 0.2.98 now (version file and title).

@derekross

Copy link
Copy Markdown
Owner

Landed as #397: your commit cherry-picked onto main unchanged, with the version set to 0.2.98 because #394 took 0.2.97 in the meantime. Closing this one; thank you.

derekross added a commit that referenced this pull request Nov 3, 2026
#397, from #343)

Omarchy's installer gives each user an unlocked default keyring, but a phone user is made without that installer, so on the Pixel 9a Chromium's first start opened an oversized "Choose password for new keyring" prompt that the palmtop couldn't get past. The user setup now runs Omarchy's own default-keyring step, which creates only what is missing.

The step is an if-block, so the script still succeeds when a later Omarchy moves the file, with a test for that.

Co-authored-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
@derekross derekross closed this Nov 3, 2026
robertzas pushed a commit to robertzas/omarchy-mobile that referenced this pull request Nov 14, 2026
derekross#397, from derekross#343)

Omarchy's installer gives each user an unlocked default keyring, but a phone user is made without that installer, so on the Pixel 9a Chromium's first start opened an oversized "Choose password for new keyring" prompt that the palmtop couldn't get past. The user setup now runs Omarchy's own default-keyring step, which creates only what is missing.

The step is an if-block, so the script still succeeds when a later Omarchy moves the file, with a test for that.

Co-authored-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants