Repository navigation
omamobile-modem-sit 0.3.21: leave an unconfirmed call release for an attended reboot - #364
Conversation
|
Thanks, this is the right direction: a modem power-off in place reset your 9a once, and on the 7 Pro every power-off costs a UFS error-handler pass and we've said the modem stays up once it's up, so radio off plus an attended reboot fits both phones. I read the three paths, the cleanup ordering and the new sit-sim cases; the unit's #356 and my #381 (0.3.20) are now on main, so this needs a rebase on top. The conflict is mechanical: One more thing before I merge: the docs still describe the old behaviour, and two runbooks wait for a log line that can no longer appear:
Could you point those at the new behaviour and journal text ("Call release not confirmed: …", "attended reboot required")? This changes the 7 Pro's failure path too, and I'm fine with that for the reason above; a note that the path has only run in the simulator would round off the description. |
b3c5ea6 to
6e3a478
Compare
|
Rebased onto main with #381: one commit, now 0.3.21. The only conflict was in |
|
Also added your first note from #356 here as a second commit, no version bump since it's a comment: the 0xf1 comment in |
8f8e073 to
12284cc
Compare
|
Done: rebased on main (one conflict in |
Stopping a running modem in place has reset tegu. When release is not confirmed, try radio-off, log only the reason and radio/CP states, and exit sitd while keeping call ownership and the modem/NV server intact. Apply the same recovery to stale ownership at startup and unresolved shutdown. Treat the recovery as fatal even inside a socket request, skip a second hangup attempt during cleanup, and always restore the audio route. Radio off failures still require an attended reboot; nothing powers the CP off or restarts it automatically. Exercise missing release indications through sit-sim at the hangup deadline, service shutdown and stale-owner startup, plus failed radio-off handling.
The comment at 0xf1 read as if sending 0 there caused the 9a's status 36. The SIM test's record says otherwise: 0.3.7 sent the bitmap and still got 36, and 0.3.8's wait after the data permission fixed it. Comment only.
… off and waits for a reboot The docs and two runbooks still described the old path, which stopped the modem unit and powered the CP off, and waited for a journal line that can no longer appear. They now give the new behaviour and journal text, and say it has run only in the simulator.
12284cc to
1e2eece
Compare
|
Thanks, this is ready. I checked the rebase: #381's registration and signal tests are all there, the radio-state line is main's, and the three docs now say what the journal will say and that the path has only run in the simulator. Merging with the subject from the version file (0.3.28; #389 picked the same number, so it gets the next one). |
The crash notice is omamobile-modem 0.1.14, and the sitd exit lands in whichever omamobile-modem-sit release derekross#389 merges as (0.3.28 went to derekross#364). Review of derekross#389. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The crash notice is omamobile-modem 0.1.14, and the sitd exit lands in whichever omamobile-modem-sit release derekross#389 merges as (0.3.28 went to derekross#364). Review of derekross#389. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… 0.2.99 over 0.2.97 Main took omamobile-modem-sit 0.3.28 (#364, the unconfirmed-hangup stop) and omamobile-shell 0.2.97 (#394); #397 lands shell 0.2.98. This branch keeps 0.3.29 and moves the shell to 0.2.99. tools/sit-sim keeps both #364's --unconfirmed-hangup and this branch's --imsi-plmn/--no-imsi in the usage block and the argument list. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d
…e's IMS CID is the override's fault Review of #373. MODEM-CLIENT.md's "no identity reads, but one" paragraph and the apn comment in modem-sit.conf said GET_IMSI goes out when apn or attach_apn is auto, from 0.3.12. choose_apn() sends it when any of apn, attach_apn, ims_apn, ims_first or internet_cid is auto or empty, which with the shipped defaults is every boot, and typing apn and attach_apn alone still sends it for the bearer order; only typing all five reads no IMSI. Both now say so, and that it landed in 0.3.29. override_values() accepted internet_cid = 2 (the IMS bearer's CID), and start() then stopped with a message blaming [network] internet_cid. The override now refuses 2 itself, as it does 16: the value is left out, its key is listed under 'refused', and choose_apn() logs that the project's carrier override for this SIM had it, never the config and never the network code. A test with such an override checks CID 1 and the message. Also from the review: carrier_apn.py and omamobile-sit-config in MODEM-CLIENT's module table, the [profiles] comment says the override's profiles apply only when the SIM was read (not with all five keys typed), and TELEPHONY-APPS-PLAN 7.6 names the versions after the merge with main (shell 0.2.99; main's 0.3.28 is #364's). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d
…99: SIM setup with no APN to type (#373) * omamobile-modem-sit 0.3.12: the APNs from the SIM, and registration without one A reseller SIM on Verizon's network needed "apn = vzwinternet" typed into modem-sit.conf before sitd would start, and then registered only with the IMS APN as the initial attach APN. A SIM should just work. With [network] apn and attach_apn at "auto" (the new default; empty means the same), sitd sends GET_IMSI once after the USIM is READY, keeps only the MCC/MNC and looks them up in the project's apn-overrides.conf, then in the system's mobile-broadband-provider-info (CC-PDDC, now a dependency). The attach APN is an override's attach_apn, else a database APN typed "ia", else the internet APN. The only override is Verizon's codes: internet vzwinternet (Verizon's own page), attach ims (our capture on 2026-11-02). A typed value always wins. Only the source is logged, never the IMSI, the network code or an APN; status carries the APNs in use and the SIM's PIN1 state for the shell. Without an APN sitd no longer stops before the radio: it registers, skips the internet bearer and goes on to IMS, and reports data unavailable. [data] roaming (default yes, the behaviour so far) drops the cellular route while roaming; omamobile-sit-data reads it on every pass. The new omamobile-sit-config, run through pkexec (polkit: the active user), changes only apn, attach_apn and roaming, and restarts nothing: an APN applies at the next start-up, which needs a fresh CP. tools/sit-sim answers GET_IMSI with a made-up subscriber part and logs the attach APN. Overlaps #356/#364/#367 (0.3.9-0.3.11) in bringup.start(); the attach_apn key matches #356's line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d * omamobile-mmd 0.1.1: the APNs sitd's start-up used, not "auto" With sitd 0.3.12 the config's APN can be "auto". The bearer's apn and Modem3gpp.InitialEpsBearerSettings now show what sitd's status reports (the internet APN and the attach APN), and fall back to the config's values, with "auto" shown as no APN. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d * omamobile-shell 0.2.93: a Mobile network page, and the SIM in setup omamobile.mobilenetwork, opened from Setup > Mobile network (only where the modem stack is) and the Mobile data tile's chevron: carrier, registration, signal, Mobile data and Data roaming switches, the APN in use with a field to type one, the attach APN under Advanced, and the SIM PIN lock. "No modem" without the stack. omamobile-mobile-network reads sitd's public state, its config and ModemManager, and changes settings through omamobile-sit-config under pkexec; it never restarts the modem services, so an APN change offers a restart of the phone. omamobile-onboarding names the carrier and says mobile data is set up automatically when a SIM is in and the stack runs; nothing to type. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d * TELEPHONY-APPS-PLAN: 7.6, SIM setup with no APN to type The design of the automatic APN and attach APN, the carrier database and its licence, the Mobile network page, what is logged, and the phone checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d * omamobile-modem-sit 0.3.12: Verizon's attach APN is vzwims, as captured The override said "ims", which was never tried as an attach APN. The SIM on Verizon's network registered on 2026-11-02 (20:26 and 20:35) with vzwims as the attach APN and vzwinternet for internet, so the override, its citation, the comments, the design notes and the tests now say vzwims. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d * omamobile-modem-sit 0.3.29: say when GET_IMSI is sent, and an override's IMS CID is the override's fault Review of #373. MODEM-CLIENT.md's "no identity reads, but one" paragraph and the apn comment in modem-sit.conf said GET_IMSI goes out when apn or attach_apn is auto, from 0.3.12. choose_apn() sends it when any of apn, attach_apn, ims_apn, ims_first or internet_cid is auto or empty, which with the shipped defaults is every boot, and typing apn and attach_apn alone still sends it for the bearer order; only typing all five reads no IMSI. Both now say so, and that it landed in 0.3.29. override_values() accepted internet_cid = 2 (the IMS bearer's CID), and start() then stopped with a message blaming [network] internet_cid. The override now refuses 2 itself, as it does 16: the value is left out, its key is listed under 'refused', and choose_apn() logs that the project's carrier override for this SIM had it, never the config and never the network code. A test with such an override checks CID 1 and the message. Also from the review: carrier_apn.py and omamobile-sit-config in MODEM-CLIENT's module table, the [profiles] comment says the override's profiles apply only when the SIM was read (not with all five keys typed), and TELEPHONY-APPS-PLAN 7.6 names the versions after the merge with main (shell 0.2.99; main's 0.3.28 is #364's). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The crash notice is omamobile-modem 0.1.17, and the sitd exit lands in whichever omamobile-modem-sit release derekross#389 merges as (0.3.28 went to derekross#364). Review of derekross#389. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The crash notice is omamobile-modem 0.1.17, and the sitd exit lands in whichever omamobile-modem-sit release derekross#389 merges as (0.3.28 went to derekross#364). Review of derekross#389. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The crash notice is omamobile-modem 0.1.17, and the sitd exit lands in whichever omamobile-modem-sit release derekross#389 merges as (0.3.28 went to derekross#364). Review of derekross#389. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…attended reboot, with the radio off (derekross#364) * omamobile-modem-sit 0.3.21: leave unresolved calls for attended reboot Stopping a running modem in place has reset tegu. When release is not confirmed, try radio-off, log only the reason and radio/CP states, and exit sitd while keeping call ownership and the modem/NV server intact. Apply the same recovery to stale ownership at startup and unresolved shutdown. Treat the recovery as fatal even inside a socket request, skip a second hangup attempt during cleanup, and always restore the audio route. Radio off failures still require an attended reboot; nothing powers the CP off or restarts it automatically. Exercise missing release indications through sit-sim at the hangup deadline, service shutdown and stale-owner startup, plus failed radio-off handling. * omamobile-modem-sit: the APN-type bitmap wasn't the cause of status 36 The comment at 0xf1 read as if sending 0 there caused the 9a's status 36. The SIM test's record says otherwise: 0.3.7 sent the bitmap and still got 36, and 0.3.8's wait after the data permission fixed it. Comment only. * MODEM-CLIENT, MODEM-PLAN: an unconfirmed call release turns the radio off and waits for a reboot The docs and two runbooks still described the old path, which stopped the modem unit and powered the CP off, and waited for a journal line that can no longer appear. They now give the new behaviour and journal text, and say it has run only in the simulator.
…99: SIM setup with no APN to type (derekross#373) * omamobile-modem-sit 0.3.12: the APNs from the SIM, and registration without one A reseller SIM on Verizon's network needed "apn = vzwinternet" typed into modem-sit.conf before sitd would start, and then registered only with the IMS APN as the initial attach APN. A SIM should just work. With [network] apn and attach_apn at "auto" (the new default; empty means the same), sitd sends GET_IMSI once after the USIM is READY, keeps only the MCC/MNC and looks them up in the project's apn-overrides.conf, then in the system's mobile-broadband-provider-info (CC-PDDC, now a dependency). The attach APN is an override's attach_apn, else a database APN typed "ia", else the internet APN. The only override is Verizon's codes: internet vzwinternet (Verizon's own page), attach ims (our capture on 2026-11-02). A typed value always wins. Only the source is logged, never the IMSI, the network code or an APN; status carries the APNs in use and the SIM's PIN1 state for the shell. Without an APN sitd no longer stops before the radio: it registers, skips the internet bearer and goes on to IMS, and reports data unavailable. [data] roaming (default yes, the behaviour so far) drops the cellular route while roaming; omamobile-sit-data reads it on every pass. The new omamobile-sit-config, run through pkexec (polkit: the active user), changes only apn, attach_apn and roaming, and restarts nothing: an APN applies at the next start-up, which needs a fresh CP. tools/sit-sim answers GET_IMSI with a made-up subscriber part and logs the attach APN. Overlaps derekross#356/derekross#364/derekross#367 (0.3.9-0.3.11) in bringup.start(); the attach_apn key matches derekross#356's line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d * omamobile-mmd 0.1.1: the APNs sitd's start-up used, not "auto" With sitd 0.3.12 the config's APN can be "auto". The bearer's apn and Modem3gpp.InitialEpsBearerSettings now show what sitd's status reports (the internet APN and the attach APN), and fall back to the config's values, with "auto" shown as no APN. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d * omamobile-shell 0.2.93: a Mobile network page, and the SIM in setup omamobile.mobilenetwork, opened from Setup > Mobile network (only where the modem stack is) and the Mobile data tile's chevron: carrier, registration, signal, Mobile data and Data roaming switches, the APN in use with a field to type one, the attach APN under Advanced, and the SIM PIN lock. "No modem" without the stack. omamobile-mobile-network reads sitd's public state, its config and ModemManager, and changes settings through omamobile-sit-config under pkexec; it never restarts the modem services, so an APN change offers a restart of the phone. omamobile-onboarding names the carrier and says mobile data is set up automatically when a SIM is in and the stack runs; nothing to type. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d * TELEPHONY-APPS-PLAN: 7.6, SIM setup with no APN to type The design of the automatic APN and attach APN, the carrier database and its licence, the Mobile network page, what is logged, and the phone checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d * omamobile-modem-sit 0.3.12: Verizon's attach APN is vzwims, as captured The override said "ims", which was never tried as an attach APN. The SIM on Verizon's network registered on 2026-11-02 (20:26 and 20:35) with vzwims as the attach APN and vzwinternet for internet, so the override, its citation, the comments, the design notes and the tests now say vzwims. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d * omamobile-modem-sit 0.3.29: say when GET_IMSI is sent, and an override's IMS CID is the override's fault Review of derekross#373. MODEM-CLIENT.md's "no identity reads, but one" paragraph and the apn comment in modem-sit.conf said GET_IMSI goes out when apn or attach_apn is auto, from 0.3.12. choose_apn() sends it when any of apn, attach_apn, ims_apn, ims_first or internet_cid is auto or empty, which with the shipped defaults is every boot, and typing apn and attach_apn alone still sends it for the bearer order; only typing all five reads no IMSI. Both now say so, and that it landed in 0.3.29. override_values() accepted internet_cid = 2 (the IMS bearer's CID), and start() then stopped with a message blaming [network] internet_cid. The override now refuses 2 itself, as it does 16: the value is left out, its key is listed under 'refused', and choose_apn() logs that the project's carrier override for this SIM had it, never the config and never the network code. A test with such an override checks CID 1 and the message. Also from the review: carrier_apn.py and omamobile-sit-config in MODEM-CLIENT's module table, the [profiles] comment says the override's profiles apply only when the SIM was read (not with all five keys typed), and TELEPHONY-APPS-PLAN 7.6 names the versions after the merge with main (shell 0.2.99; main's 0.3.28 is derekross#364's). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Stacked on #356 (it shows that PR's commits too); mine is the top one.
When sitd couldn't confirm a call's release, it stopped the modem in place. On the Pixel 9a a stop of the running modem hard-reset the palmtop once (device/tegu MODEM-PLAN, M5), and the unit that stop targets is masked there. Now, at all three places that fell back to a stop (the hang-up deadline, an unresolved call at shutdown, and a stale call owner at start-up), sitd tries radio off, logs only the reason and the radio and CP states, keeps the call's ownership and the modem and NV server as they are, restores the audio route and exits. Nothing powers the CP off or restarts it; the way out is an attended reboot. This applies to every device, since a stop in place was never qualified anywhere.
The recovery is fatal even inside a socket request, and cleanup doesn't try a second hang-up. sit-sim gains the missing release indication at the hang-up deadline, at shutdown and for a stale owner at start-up, plus a failed radio-off;
test/all(95 tests) andtools/pr-checkpass. No call has been made on the 9a yet (no audio route), so this hasn't run on hardware.This failure path has run only in the simulator (sit-sim: a missing release at the hangup deadline, at shutdown and for a stale owner at start-up, plus a failed radio-off); no call has been left unconfirmed on a phone.