Repository navigation
omamobile-omarchy 0.1.19: fingerprint on the lock only when a finger is enrolled - #171
Merged
Merged
Conversation
This was referenced Oct 30, 2026
derekross
added a commit
that referenced
this pull request
Oct 30, 2026
The matrix and the Wanted list against what has merged since #140, with each pull request's state checked on GitHub today: - Pixel 7 (panther): the GPU and haptics nodes (kernel #129, #130) were closed because they landed unchanged through kernel #134, merged with the touchscreen node and s2idle by default; device-panther 0.1.1 (#145) carries the GPU's always-on rule, the feedbackd rule and the sleep.conf drop-in. GPU and Haptics stay "testing" and now cite #134, #145 and the 2026-10-28 notes. Touch stays WIP: kernel #134's body records touches driving Hyprland and the PIN screen, but the driver fixes (kernel #133) and the kernel option with the touch notes (#149) are still in review. Suspend: "no" with the s2idle default named, since the notes say it hasn't run. - Pixel 6 Pro (raven): Haptics "no" -> "works": HAPTICS-TORCH-PLAN H5 passed (2026-10-28/29), cs40l25-vibra and the node merged as kernel #114, feedbackd's rule in device-raven 0.1.27 (#113). Display names its open kernel PR, #116. - Pixel 7a (lynx): Bluetooth "no" -> WIP: the merged WIFI-PLAN (#133) records it scanning through its own UART; kernel #98 and #98 are in review. The Wanted line says so too. - Pixel 7 Pro (cheetah) detail: Boot names the AVB footers a chained vbmeta_b needs (NOTES 2026-10-28 and 10-29, #104); Suspend describes the merged tier 1 auto-sleep (#64, off by default behind the omamobile-sleep toggle, P0-P5 on 2026-10-26) in place of the old "until S8" text. Nothing from the open #171, #172, #174-#176. - Wanted: coral's #52 is merged, so its line no longer says "in review"; flame gets a line for its native install in review (#55, #56, #58, #59, split out of #17); the OnePlus 13 (dodge) is listed with #111 and kernel #115, both open. The Pixel 9a row and the Pixel 9 family line are left to #165. Every status word still parses with the website's parseCell. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…is enrolled Omarchy 4.0.6's lock and omarchy-apply-lock decide fingerprint is set up with `fprintd-list "$USER" | grep -qi finger`, which also matches "User ... has no fingers enrolled ...". omamobile-fingerprint installs /etc/pam.d/omarchy-lock-fingerprint and pulls in fprintd, so on a phone with nothing enrolled only that grep decides, and it says yes. The lock then starts a pam_fprintd attempt that fails at once (PAM_AUTHINFO_UNAVAIL, code 9) and retries 250 ms later for as long as it is up: 130,164 failed attempts in one night on a Pixel 7 Pro, about 3.4 a second, each reaching fprintd and polkit, and 55-62 mA (roughly 12 % of the phone's draw) in an A/B run against the PAM file moved aside (#170). Upstream fixed this in 879d6583d ("Fix fingerprint enrollment and lock-screen recovery", omacom/omarchy#7158), which is only in the 4.5 pre-releases. Patch 0022 backports its probe half: - the lock's probe becomes `LC_ALL=C fprintd-list "$USER" 2>&1`, read by FingerprintModel.classifyProbe(): yes only for an enrolled-print row (" - #0: ..."), no for "has no fingers enrolled" (or no PAM file), unknown otherwise; an unknown answer never turns fingerprint off and is asked again after 1 s, doubling to 40 s, while the lock is up; - omarchy-apply-lock matches the same row, removes the fingerprint PAM file only on a definite no, and keeps it when the probe fails. The rest of 879d6583d (the attempt backoff and "reader unavailable" notice, the fprintd resume hook, the enrollment changes) is left out, so a phone with a finger enrolled behaves as before: a mismatch still retries at 250 ms. omamobile-fingerprint keeps owning the PAM file (TOUCH-PLAN 0.1); with the probe fixed, the file's presence no longer counts as setup on its own. test/patches.py runs the patched lock's own probe command against a fake fprintd-list with the issue's "has no fingers enrolled" text, an enrolled print and a failed call, and puts the output through classifyProbe; it runs the patched omarchy-apply-lock the same way. The series applies with --fuzz=0 to the real aarch64 omarchy 4.0.6-1. 0.1.13 and 0.1.14 are taken by open #134 and #162 (and patch 0021 by Fixes #170 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
derekross
force-pushed
the
fix-170-fingerprint-retry
branch
from
October 30, 2026 19:02
7823045 to
bef0469
Compare
Owner
Author
|
Rebased onto today's main, which has the glance lock (0.1.16–0.1.18), and renumbered to 0.1.19. Patch 0022 still applies with |
Contributor
|
Tested on a Pixel 7 Pro (cheetah) with no finger enrolled: this stops the loop. Setup.
Before,
The install.
After, 0.1.15-1 from this branch. Locked from 16:42:25Z to 17:01:02Z (18 min 37 s).
Not tested:
|
9 tasks done
9 tasks done
This was referenced Nov 1, 2026
Somnius
added a commit
to Somnius/omarchy-mobile
that referenced
this pull request
Nov 1, 2026
…ator Three overlays for the MAX77759 steps of the battery plan, none default, listed through DTB_OVERLAYS like the other devices': - battery-clk-test: CMU_PERIC1 and its sysreg, USI11 and the bus still off (step M2b); - battery-i2c-test: also USI11 and hsi2c_11, the bus of the gauge, PMIC, charger registers and Type-C controller (M3). They need kernel derekross#163; - gauge-model: Google's ModelGauge m5 model for the pack, as maxim,fg-model and maxim,fg-params on the fuel gauge (M4c). Without a model the gauge stays in its power-on state (Status 0x0002, Config 0x2354) and reports a battery temperature stuck at exactly 22.0 C: the same gauge on a Pixel 7 does the same without its model and reads 33.1 C with it (kernel derekross#171). With default-a1-0k (what Google's driver falls back to for an unknown pack) loaded through this overlay the driver logs "battery model loaded (DesignCap 0x994, TaskPeriod 0x2d00)", the power-on bit clears, and the temperature reads 34.4 C and moves. The pack (ATL, COS or LSN) is not known yet, so the percentage may be a few points off; the charge voltage comes from the device tree, not the model. tools/gen-gauge-overlay.py writes the overlay from Google's stock husky node, so no number is typed by hand: each stock u32 table cell becomes two u16 words, the stock parameter bytes become big-endian u16 words in the order of struct max77759_fg_params. The shipped gauge-model.dtso is its output for default-a1-0k. tests/device-overlays compiles all three with dtc -@ (48 overlays ok). Booted on a Pixel 8 Pro (7.3.0-rc6, slot B): all three, in order. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Nov 1, 2026
This was referenced Nov 3, 2026
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
The matrix and the Wanted list against what has merged since derekross#140, with each pull request's state checked on GitHub today: - Pixel 7 (panther): the GPU and haptics nodes (kernel derekross#129, derekross#130) were closed because they landed unchanged through kernel derekross#134, merged with the touchscreen node and s2idle by default; device-panther 0.1.1 (derekross#145) carries the GPU's always-on rule, the feedbackd rule and the sleep.conf drop-in. GPU and Haptics stay "testing" and now cite derekross#134, derekross#145 and the 2026-10-28 notes. Touch stays WIP: kernel derekross#134's body records touches driving Hyprland and the PIN screen, but the driver fixes (kernel derekross#133) and the kernel option with the touch notes (derekross#149) are still in review. Suspend: "no" with the s2idle default named, since the notes say it hasn't run. - Pixel 6 Pro (raven): Haptics "no" -> "works": HAPTICS-TORCH-PLAN H5 passed (2026-10-28/29), cs40l25-vibra and the node merged as kernel derekross#114, feedbackd's rule in device-raven 0.1.27 (derekross#113). Display names its open kernel PR, derekross#116. - Pixel 7a (lynx): Bluetooth "no" -> WIP: the merged WIFI-PLAN (derekross#133) records it scanning through its own UART; kernel derekross#98 and derekross#98 are in review. The Wanted line says so too. - Pixel 7 Pro (cheetah) detail: Boot names the AVB footers a chained vbmeta_b needs (NOTES 2026-10-28 and 10-29, derekross#104); Suspend describes the merged tier 1 auto-sleep (derekross#64, off by default behind the omamobile-sleep toggle, P0-P5 on 2026-10-26) in place of the old "until S8" text. Nothing from the open derekross#171, derekross#172, derekross#174-derekross#176. - Wanted: coral's derekross#52 is merged, so its line no longer says "in review"; flame gets a line for its native install in review (derekross#55, derekross#56, derekross#58, derekross#59, split out of derekross#17); the OnePlus 13 (dodge) is listed with derekross#111 and kernel derekross#115, both open. The Pixel 9a row and the Pixel 9 family line are left to derekross#165. Every status word still parses with the website's parseCell. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
…is enrolled (derekross#171) Omarchy 4.0.6's lock and omarchy-apply-lock decide fingerprint is set up with `fprintd-list "$USER" | grep -qi finger`, which also matches "User ... has no fingers enrolled ...". omamobile-fingerprint installs /etc/pam.d/omarchy-lock-fingerprint and pulls in fprintd, so on a phone with nothing enrolled only that grep decides, and it says yes. The lock then starts a pam_fprintd attempt that fails at once (PAM_AUTHINFO_UNAVAIL, code 9) and retries 250 ms later for as long as it is up: 130,164 failed attempts in one night on a Pixel 7 Pro, about 3.4 a second, each reaching fprintd and polkit, and 55-62 mA (roughly 12 % of the phone's draw) in an A/B run against the PAM file moved aside (derekross#170). Upstream fixed this in 879d6583d ("Fix fingerprint enrollment and lock-screen recovery", omacom/omarchy#7158), which is only in the 4.5 pre-releases. Patch 0022 backports its probe half: - the lock's probe becomes `LC_ALL=C fprintd-list "$USER" 2>&1`, read by FingerprintModel.classifyProbe(): yes only for an enrolled-print row (" - #0: ..."), no for "has no fingers enrolled" (or no PAM file), unknown otherwise; an unknown answer never turns fingerprint off and is asked again after 1 s, doubling to 40 s, while the lock is up; - omarchy-apply-lock matches the same row, removes the fingerprint PAM file only on a definite no, and keeps it when the probe fails. The rest of 879d6583d (the attempt backoff and "reader unavailable" notice, the fprintd resume hook, the enrollment changes) is left out, so a phone with a finger enrolled behaves as before: a mismatch still retries at 250 ms. omamobile-fingerprint keeps owning the PAM file (TOUCH-PLAN 0.1); with the probe fixed, the file's presence no longer counts as setup on its own. test/patches.py runs the patched lock's own probe command against a fake fprintd-list with the issue's "has no fingers enrolled" text, an enrolled print and a failed call, and puts the output through classifyProbe; it runs the patched omarchy-apply-lock the same way. The series applies with --fuzz=0 to the real aarch64 omarchy 4.0.6-1. 0.1.13 and 0.1.14 are taken by open derekross#134 and derekross#162 (and patch 0021 by Fixes derekross#170 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #170.
On a phone with
omamobile-fingerprintinstalled and no finger enrolled, the lock starts apam_fprintdattempt about 3.4 times a second for as long as it is up. Each attempt fails at once withPAM_AUTHINFO_UNAVAILand is retried 250 ms later. One night logged 130,164 failed attempts, each reaching fprintd and polkit, and an A/B run in the issue measured about 55-62 mA more draw with the screen off.The cause is Omarchy 4.0.6's check,
fprintd-list "$USER" | grep -qi finger, which also matches "User … has no fingers enrolled …". Becauseomamobile-fingerprintships the PAM file and depends on fprintd, only that grep decides, and it says yes.What changes (omamobile-omarchy 0.1.15, patch 0022): a backport of the probe half of upstream's 879d6583d (omacom/omarchy#7158, so far only in the 4.5 pre-releases).
LC_ALL=C fprintd-list "$USER" 2>&1, read byFingerprintModel.classifyProbe(). An enrolled-print row (- #0: …) means yes; "has no fingers enrolled", or no PAM file, means no; anything else is unknown.omarchy-apply-lockmatches the same row, removes the fingerprint PAM file only on a definite no, and keeps it when the probe fails.Left out on purpose: the rest of 879d6583d (the attempt backoff and "reader unavailable" notice, the fprintd resume hook, the enrollment changes). A phone with a finger enrolled behaves as before: a mismatch still retries at 250 ms.
omamobile-fingerprintkeeps owning the PAM file (TOUCH-PLAN 0.1).Version: 0.1.13 and 0.1.14 are taken by open #134 and #162, and patch 0021 by #134, so this takes 0.1.15 and 0022. Whichever merges later rebases
version.Tests:
packages/omamobile-omarchy/test/allpasses; the series applies with--fuzz=0to the real aarch64 omarchy 4.0.6-1.fprintd-list(no fingers enrolled, an enrolled print, a failed call, no PAM file) and classify the output, and run the patchedomarchy-apply-lockthe same way.tools/pr-checkandtests/packages(22 suites) pass.Not yet tested on a phone. On a phone with nothing enrolled, after
omamobile-omarchy-patches statusshows 0022 applied: lock it, andjournalctl --user -f | grep omarchy-lock-fingerprintshould show no new attempts. On cheetah, with a finger enrolled, the lock should still unlock with a finger.🤖 Generated with Claude Code