Repository navigation
docs/review: lessons from review round 29 - #160
Merged
Merged
Conversation
Twenty-six lessons (L-318 to L-343) from the round 29 omamobile-reviewer runs, and three corrections: C-20, our kernel #109 advice that the Pixel 7's SPI controller DMAs the touch report (it polls; gs201's spi_0 has no dmas); C-21, asking for FT3658=m in panther's device kernel.config against RELEASES; C-22, a Bluetooth address in kernel #98's thread that the first review missed. Five candidates were dropped as already covered. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
Twenty-six lessons (L-318 to L-343) from the round 29 omamobile-reviewer runs, and three corrections: C-20, our kernel derekross#109 advice that the Pixel 7's SPI controller DMAs the touch report (it polls; gs201's spi_0 has no dmas); C-21, asking for FT3658=m in panther's device kernel.config against RELEASES; C-22, a Bluetooth address in kernel derekross#98's thread that the first review missed. Five candidates were dropped as already covered. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twenty-six lessons (L-318 to L-343) and three corrections from review round 29.
dmas, so it polls (lesson L-329).FT3658=min panther's devicekernel.config, against RELEASES (lesson L-337; L-314's last sentence pointed the same way).Docs only; no duplicate numbers (343 lessons, 22 corrections).
🤖 Generated with Claude Code