Skip to content

docs/review: lessons from review round 29 - #160

Merged
derekross merged 1 commit into
mainfrom
review-lessons-r29
Oct 29, 2026
Merged

derekross merged 1 commit into
mainfrom
review-lessons-r29

Conversation

@derekross

@derekross derekross commented Oct 29, 2026 •

Copy link
Copy Markdown
Owner

Twenty-six lessons (L-318 to L-343) and three corrections from review round 29.

  • C-20: our kernel Package publish failed on the build machine #109 advice said the Pixel 7 SPI controller DMAs the touch report; gs201 spi_0 has no dmas, so it polls (lesson L-329).
  • C-21: we asked for FT3658=m in panther's device kernel.config, against RELEASES (lesson L-337; L-314's last sentence pointed the same way).
  • C-22: the first review of kernel device-lynx: Bluetooth on the APM UART #98 missed a Bluetooth address in a thread comment (lesson L-324).
  • 31 candidates: 26 kept, 5 dropped as already covered.

Docs only; no duplicate numbers (343 lessons, 22 corrections).

🤖 Generated with Claude Code

Twenty-six lessons (L-318 to L-343) from the round 29 omamobile-reviewer
runs, and three corrections: C-20, our kernel #109 advice that the
Pixel 7's SPI controller DMAs the touch report (it polls; gs201's spi_0
has no dmas); C-21, asking for FT3658=m in panther's device
kernel.config against RELEASES; C-22, a Bluetooth address in kernel
#98's thread that the first review missed. Five candidates were dropped
as already covered.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@derekross
derekross merged commit c04addf into main Oct 29, 2026
2 checks passed
@derekross
derekross deleted the review-lessons-r29 branch October 29, 2026 18:51
robertzas pushed a commit to robertzas/omarchy-mobile that referenced this pull request Nov 14, 2026
Twenty-six lessons (L-318 to L-343) from the round 29 omamobile-reviewer
runs, and three corrections: C-20, our kernel derekross#109 advice that the
Pixel 7's SPI controller DMAs the touch report (it polls; gs201's spi_0
has no dmas); C-21, asking for FT3658=m in panther's device
kernel.config against RELEASES; C-22, a Bluetooth address in kernel
derekross#98's thread that the first review missed. Five candidates were dropped
as already covered.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant