Repository navigation
omamobile-device-husky 0.1.3: the display at 120 Hz, with brightness - #228
Conversation
|
Thank you, this is a careful piece of work: the marker, the panel-gated
#221 and #214 are merged now, so this needs a rebase on |
6ebf6e5 to
f9f2659
Compare
The kernel display PR runs husky's screen on gs-decon, with DSIM0 and the HK3 panel driver for brightness and 120 Hz. Those need gs_dsim_cmd.allow_tx set before gs_decon probes, since gs-decon decides on 120 Hz at probe, as on the Pixel 9a. - omamobile-husky-display-start loads gs_decon (stage 2) before the display manager, hang-safe like omamobile-tegu-graphics-start: a synced marker that a load which never returns leaves behind keeps it off on the next boot, until --retry. It allows the panel's DSI commands first, only when the bootloader names the google-hk3 panel on the command line (exynos_drm.panel_name=google-hk3.<id>); - omamobile-husky-display.conf blacklists gs_decon's autoload, so only the start loads it, and sets screen_off=2, as cheetah and tegu do: on DPMS off DECON stops its frames and the HK3 sleeps, and DPMS on wakes it; - display-manager.service.d orders the session after it; - the saved brightness: systemd-backlight restores it in sysinit, before the start allows the panel's commands, and the HK3 driver keeps that level. The start sends it again once allow_tx is on. Ordering systemd-backlight after the start instead would be a cycle (sysinit is before the start) or would move the start before sysinit, where a hung load blocks the whole boot; - kernel/configs/omamobile.config builds the HK3 driver: a module that binds only to its compatible, so it is safe on every phone. On a kernel without the display PR the DTB has no DECON0, and the unit is skipped by its condition. test/display-start runs the start in a scratch root: the marker before the load, allow_tx on for google-hk3 and google-hk3.<id> only and before gs_decon, the brightness sent again only then, a failed load, a stale marker and --retry. Tested on the first husky with these files installed under /etc and /usr/local: on two reboots the start allowed DSI commands for google-hk3.20800a before gs_decon, the session came up at 120 Hz on gs-decon, and a brightness of 700 set before the reboot came back. test/all checks the staged files, the enable link, the orderings and the unit's DECON0 condition. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Brett-Michael Green <brett@bmgvisualtech.com>
f9f2659 to
6d57e14
Compare
|
Thanks Derek. Rebased onto main after #221 and #214 (
New in this push:
|
|
The boot from the package, as you asked:
The start's journal (monotonic time):
"disabled" is only What the boot shows:
|
| Check | Result | Detail |
|---|---|---|
| boot (required) | ok | kernel 7.3.0-rc6-omamobile-husky-wifi, slot b, up 56s |
| storage guard (required) | ok | 62 partitions; only userdata and slot B's boot images writable |
| root (required) | ok | ext4 on userdata, 97G free |
| kernel health (required) | ok | no oops or BUG; 0 WARN, 33 error lines in dmesg |
| systemd units | ok | none failed |
| USB gadget (required) | ok | bound to 11210000.usb |
| display | ok | card2-DSI-1 connected, 1344x2992 |
| GPU | ok | render node on panthor |
| session (required) | ok | Hyprland and the Omarchy shell running |
| lock | ok | PAM file present, the shell can lock (passwordPam true, locked true) |
| touch | ok | SALIXP Touchscreen |
| buttons | ok | gpio-keys |
| Wi-Fi | ok | wlp1s0 on brcmfmac, link up |
| Bluetooth | skip | no controller |
| battery | skip | no battery power supply |
| sound cards | skip | none |
| sensors | skip | no sensor proxy |
| cameras | skip | no libcamera tools |
| thermal | ok | hottest zone 51 °C |
The 33 error lines are the BCM4398 bring-up's (#156: unexpected monitor packets, firmware channels 169-177, PKTID, the P2P interface, one join retried before it succeeded), plus the ones listed on kernel #157: panthor's missing regulator, the HK3's one refused write before allow_tx, and exynos-clkout from the zuma PMU on omamobile.
|
Thanks, Brett. Every point is answered, and I checked each one against the new head (
One thing for the merge, and it isn't yours to fix: Lef's USB-rescue PR (#250) also takes Merging. Thanks for a really well-tested piece of boot plumbing. |
…erekross#228) Reviewed in round 32: see the pull request for the tests.
omamobile-device-husky0.1.3 brings up the Pixel 8 Pro's display at 120 Hz, with brightness, at every boot. derekross/linux-omarchy-mobile#160 runs the screen on gs-decon, with DSIM0 and an HK3 panel driver. As on the Pixel 9a, gs-decon decides on 120 Hz when it probes, sogs_dsim_cmd.allow_txhas to be on beforegs_deconloads.What it adds:
omamobile-husky-display-start, hang-safe likeomamobile-tegu-graphics-start:gs_decon stage=2 fbdev=0before the display manager. A load that never returns leaves the marker, so the next boot stays on simple-framebuffer until--retry;google-hk3panel on the command line (exynos_drm.panel_name=google-hk3.20800aon the first phone);omamobile-husky-display.service, enabled by a vendormulti-user.target.wantslink, plusdisplay-manager.service.d/10-omamobile-husky.conf, so the session starts after it.modprobe.d/omamobile-husky-display.conf:blacklist gs_decon, so only the start loads it. There's noinstallline.The saved brightness: systemd-backlight restores it in sysinit, before the start allows the panel's commands. docs/review: lessons from review round 29 #160's HK3 driver keeps that level instead of failing, and the start sends it again once
allow_txis on.Ordering systemd-backlight after the start would be a cycle, because sysinit comes before the start. I tried it, and systemd broke the cycle. The other way to fix it, moving the start before sysinit, would let a hung load block the whole boot.
options gs_decon screen_off=2, as cheetah and tegu ship it: on DPMS off, DECON stops its frames and the HK3 goes to sleep, and DPMS on wakes it. Without it, the panel stays awake on black frames.kernel/configs/omamobile.config:CONFIG_DRM_PANEL_GOOGLE_HK3=m, a module that binds only to its compatible. On a kernel without docs/review: lessons from review round 29 #160, olddefconfig drops the unknown symbol, and the unit is skipped by its DECON0 condition.Tests:
test/display-startruns the start in a scratch root, withmodprobe,syncandsleepfaked:allow_txis 1 whengs_deconloads forgoogle-hk3andgoogle-hk3.<id>, and stays 0 forgoogle-tg4c,google-hk3xor no name;allow_tx;gs_deconoff until--retry;test/allchecks the staged files, the enable link, both orderings, and thatgs_deconis the only blacklisted module.tools/pr-checkandpackages/omamobile-device-husky/test/allpass.Tested on the first husky (the kernel at #160's tag
husky-test-20261031-d3, these files installed under/etcand/usr/local), over two reboots:google-hk3.20800abeforegs_deconloaded at about 4.5 s, and SDDM started after it;zuma_gpu_max_khz=890000took effect too.🤖 Generated with Claude Code