Repository navigation
AGENTS: on the 9a, NFC needs the ST54L's NFC mode on (linux-omarchy-mobile#131), not a power-off hook - #137
Conversation
After an s2idle wake the ST54L has lost its NCI state until neard powers the adapter off and on (derekross#132), so the sleep hook should power it off rather than only stop polling. The first test of that hook didn't wake, so it stays attended.
|
Thanks, @W4HO-ham, for turning the #131 follow-up around so quickly. I checked the new text against #132 and your NOTES entry on #131, and it matches what you reported: the A few changes before it merges:
Here is one way to write the end of the entry, from "so stop polling by hand first" onwards, with your facts and the points above. Change it as you like:
Merge order: #100 edits the same line (it adds the kernel release after "all woke"), so whichever of the two merges second needs a rebase. Please keep #100's release in the line when you rebase. Thanks again. This gotcha has already stopped one bad suspend, and the sharper version will save the next person a lot of guessing. |
…one wakes Review: the gotcha now says what was observed (no I2C ACK after the wake), keeps the stop-poll hook, and describes the power-off hook as the candidate under test that must stop polling and check Powered first. MODEM-PLAN's suspend section records the 10-28 results with the kernel release.
|
Thanks. All four are in the new head:
I'll keep #100's release in the line when I rebase, whichever of the two goes second. |
0bb9e84 to
5f2ae68
Compare
The NACK after a wake was the controller idling without its NFC mode on; linux-omarchy-mobile#131 turns it on, and NFC then polls after a wake with the stop-poll hook alone.
|
This changed overnight: the NACK wasn't about sleep. Without its NFC mode turned on, the ST54L goes silent about 2 s after init whenever it isn't discovering, sleep or not. linux-omarchy-mobile#131 turns the mode on, as ST's HAL does, and with it NFC polls again after a wake with the stop-poll hook alone. The entry now says that, with the kernel release, and drops the power-off-hook advice. #132 has the test details. The MODEM-PLAN paragraph in this PR still describes the 10-28 state; I'll add the result there too if you'd like it in the same PR. |
|
Thanks, @W4HO-ham. All four points from my last comment were taken in the 02:49 push. The gotcha kept the stop-poll hook, the power-off hook got its "stop polling, check A few things before it merges:
As before, #100 edits the same AGENTS line (the release after "all woke"), so whichever of the two goes second needs a rebase that keeps both changes. Thanks for following this all the way down. The gotcha now tells the next person the cause, not just a workaround. |
…erekross#127 line The 10-28 evening entry still says the sleep hook has to power the NFC adapter off, and that fingerprint matching doesn't work. Both are out of date: the ST54L's NFC mode (linux-omarchy-mobile#131, derekross#137) makes the power-off hook unnecessary, and one try of such a hook failed to wake, and matching works since FINGERPRINT-PLAN F9/F10 (derekross#138). Point forward from both bullets so nobody builds the hook from the old note, and wrap the sentence about derekross#127 like the rest of the entry.
…ld, derekross#131 as a link The plan's NFC paragraph still ended with the 10-28 rule (keep the stop-poll hook until a power-off hook wakes) while AGENTS.md said no power-off hook is needed. The 10-28 paragraph stays as that day's record, and a dated 10-29 paragraph follows it: the hook reworked to check Powered woke 1 of 1 but NFC had already failed before the sleep; the no-sleep A/B/C table from derekross#132 (NACK from about 3 s of idle, with and without the set-config, with and without quick retries); the cause (the ST54L's NFC mode never turned on) and its fix, linux-omarchy-mobile#131; what passed with it (3 s to 3 minutes of idle, two RTC-woken s2idle cycles); and what was ruled out, including how the clock pad was forced on (a test module through the kernel's PMU regmap, not userspace). The release is the same for the runs with and without the fix, so both files name the tested core.c by its blob id, 77fc35b61da5, the head of derekross#131. The AGENTS line now gives the count behind "polls after a wake with the stop-poll hook alone": one RTC-woken cycle without the power-off hook, for which it isn't recorded whether polling was stopped, so it needs a re-run with the hook's log; the stop-poll rule itself still rests on the 35 of 35 of 10-27. linux-omarchy-mobile#131 is written as a full link wherever it appears, since a bare cross-repository reference doesn't become one in a file.
|
Done in 47180f5. The plan's 10-28 paragraph stays as that day's record, and a dated 10-29 paragraph follows it with the A/B/C table from #132, the cause, the fix as a link, and what passed with it: polling after 3 s to 3 minutes of idle, and after two RTC-woken s2idle cycles, one with the power-off hook and one without. On your point 2: for the cycle without the hook I didn't record whether the poll loop was stopped, so both files now say that, count it as the one cycle behind "polls after a wake with the stop-poll hook alone", and call for a re-run with the hook's log. The stop-poll rule itself still rests on the 35 of 35 from 10-27. The tested core.c is blob 77fc35b61da5, #131's head at the time, named in both files next to the release. Since then #131 has moved to the reset-notification wait you asked for (core.c c96704ddd480, re-tested today, see there); the plan line names the blob the 10-29 results came from. linux-omarchy-mobile#131 is a full link everywhere it appears. I'll rebase onto #100 if it goes in first. |
|
Thanks, @W4HO-ham. All four points are in: the plan now has a dated 10-29 paragraph that matches AGENTS.md, the no-hook cycle is described honestly as "not recorded", the tested Two small wording fixes before it merges:
Thanks for the clock-pad detail in the plan as well. Doing it through the kernel's PMU regmap was the right way. As before, I'll merge this after derekross/linux-omarchy-mobile#131. I'll write the squash message myself, because the earlier commits' messages describe the power-off hook plan that this PR ends up replacing. |
…re from The idle and s2idle results of 10-29 ran on linux-omarchy-mobile#131's first version (core.c blob 77fc35b61da5, a fixed 200 ms wait after the reset). The version that merges waits for the controller's CORE_RESET_NTF instead (c96704ddd480) and was re-run the same day for six power-ons and polling at 3 s and 30 s after power-on, with no NACK. Both files now say which build each result is from, so nobody reads the s2idle cycles as tested on the merged code. The AGENTS line also quoted a phrase that the previous push removed, so the quotation pointed at nothing. It now says plainly that whether NFC comes back after a wake with the stop-poll hook alone rests on that one cycle and needs a re-run with the hook's log.
|
Both in fab2290. The plan and the AGENTS line now say the idle and s2idle results are from #131's first version (77fc35b61da5) and that the merged one (c96704ddd480) was re-run for six power-ons and polling at 3 s and 30 s, and the dead quotation is replaced with your wording. Fine by me on the squash message. |
|
Thanks, both wording fixes are in, and the plan and the AGENTS line now agree. Since then #100 has merged and added the kernel release after "all woke" on the same line, so this now conflicts there. It's a one-line fix, and I'll do it at merge: your line with |
# Conflicts: # AGENTS.md
|
Merged right after derekross/linux-omarchy-mobile#131, thank you. The AGENTS line came out identical to main's once the kernel release was back after "all woke" (your #100 had carried the same wording), so this lands the MODEM-PLAN side. |
…dem plan's corrections (derekross#137) MODEM-PLAN's NFC and sleep notes now agree with the AGENTS line about the Pixel 9a's NFC polling through s2idle (a suspend with neard polling reset the palmtop; with polling stopped, 35 RTC-woken s2idle cycles all woke), and the plan names the merged nxp-nci core change (linux-omarchy-mobile#131) it relies on. Merged with main's AGENTS line, which already carried the same wording plus the kernel release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The follow-up you asked for on #131. The 9a gotcha now says what #132 found: after an s2idle wake, NFC stays dead until neard powers the adapter off and on, so the hook should power it off, not only stop polling. It also says the power-off version isn't proven. In its first RTC test on the palmtop (2026-10-28) the palmtop didn't wake, and I don't know why yet, so the next try is attended.