Repository navigation
device/tegu: SLEEP-PLAN, an audit of the s2idle drain - #144
Conversation
The 9a sleeps and wakes, but its drain is high. This audits why from stock's device tree and a snapshot of the palmtop: no cluster or SICD idle states, the GNSS and fingerprint rails always on in the bring-up DTB, and MIF, with a measurement runbook.
So cluster states on zumapro would be platform-coordinated, with a composite StateID; and the core state's rejection rate, read from cpuidle.
The cable-out s2idle figure (about 140 mA), MIF in sleep (about 57 mA saved), and the cluster power-down tries of 10-28 (cluster 0 hangs; clusters 1-2 save nothing measurable) were already measured; the candidates are re-ranked on them.
|
Thank you for this. It's exactly the kind of plan the drain needed: what's measured, what was tried and dropped (cluster power-down, with the reason Google never powers down cluster 0), and a ranked list with the cable-in MIF figure kept apart from the cable-out one. Finding the GNSS rails and A few things before it merges. They're all small text changes, but the first two matter for safety:
Not blocking:
The policy check and CI pass, and the plan has no identifiers. This one has no textual conflicts with the other open tegu PRs. It reads best after #100, since it quotes that entry's measurements. |
…fter, the code by commit The runbook stops if slot B isn't marked successful and doesn't mark it (a devinfo write on the 9a, derekross#125). S1 needs the NFC stop-poll hook active or polling stopped by hand, with the kernel's derekross#131 state and the rule that stays, a Rollback line and pstore after a cycle that doesn't come back. S2 snapshots regulator_summary before and diffs it after, stops if more than the four rails changed, records stock's consumers of them (none in its DT: no phandle on any of the four, the GNSS three on the PMIC's channel mux, LDO15S a spare), keeps the modem off in that boot and stays away from a G3 session. The push wording says what bin/omamobile push writes and that only vendor_kernel_boot differs. The module, the bring-up DT and the S2 change are linked by commit on the fork's tegu-sleep-bringup branch, and the CPU_INFORM hints of 10-28 are credited to the bring-up module that wrote them over the PMU SMC. The measurements link derekross#100's NOTES entry.
|
Thanks, all done in 5e8368b.
Not blocking: the push wording now says bin/omamobile push writes every image in BOOT_IMAGES, and the step checks by sha that only vendor_kernel_boot differs; S1 has a Rollback line (rmmod tegu-mif-sleep, or a reboot) and the runbook says to read /sys/fs/pstore first after a cycle that doesn't come back; the measurements link #100's NOTES entry; S2 stays away from a G3 session. CPU_INFORM: not the exynos-pmu regmap, and not userspace. It was a small bring-up kernel module (a cpu_pm notifier, never published, dropped with the result) that wrote each core's word with the PMU register-write SMC, the same call gs101-pmu's regmap write uses. The plan says so, and that a SICD step would go through the exynos-pmu regmap. |
|
Thank you for the quick and careful turnaround. I checked 5e8368b point by point, and everything from my last comment is in. The slot B precondition matches USB-HOST-PLAN word for word and no longer tells anyone to mark. The NFC precondition covers both S1 and S2 and says plainly that the nxp-nci change doesn't lift the rule. All three bring-up commits are public on Two small things before it merges. Both come from reading the plan next to the others:
Not blocking:
The policy check and both CI jobs pass on this head, it merges cleanly onto today's main, and the plan has no identifiers. |
…oot, S1's command and column S2 says it turns LDO15S off on purpose for one boot against FINGERPRINT-PLAN's rule (that plan gets the matching note once derekross#138 is on main), and step 3 keeps omamobile-fp, the trusted app and storageproxyd stopped before the push and until the rollback, since F6c still writes secure objects. S1 names its command, power-ab with derekross#157's systemd suspend mode (rtcwake -m no plus systemctl suspend, so the NFC hook runs), reads charge_now, column 7, because the 9a's gauge has no charge_counter, and waits for derekross#157. Also: derekross#125's rules are being settled; the four rails read disabled with or without the unused-rail cleanup; stock's source grepped for the four rail names (DT sources and the register header only, no module asks by name); a Polling read before each run; nothing starts the modem at boot, so nothing to mask.
|
Done in d5f1c26.
Not blocking, all done: #125 "being settled"; step 4 says the four read disabled whether or not the 30 s cleanup runs; I grepped stock's source for the four names (L15S_SPARE and the three GPS rails, plus S2MPG15_LDO9-11/15) in devices/google/tegu, devices/google/zuma* and google-modules, and they appear only in DT sources and the S2MPG15 register header, no vendor module asks for them by name, recorded in the plan; a busctl Polling read before each run is in the NFC precondition; nothing on the palmtop starts the modem at boot (it's started by hand with omamobile-tegu-modem-up), so there's nothing to mask, and the plan says so. |
The 9a's link driver began as a copy of the gs201 controller in kernel derekross#144, so it goes in as a second compatible stacked on that; the section lists what zumapro adds.
The zumapro compatible of the gs201 modem link driver and its binding, stacked on kernel derekross#144; the DT nodes follow once that stack is on omamobile.
* device/tegu: SLEEP-PLAN, an audit of the s2idle drain The 9a sleeps and wakes, but its drain is high. This audits why from stock's device tree and a snapshot of the palmtop: no cluster or SICD idle states, the GNSS and fingerprint rails always on in the bring-up DTB, and MIF, with a measurement runbook. * device/tegu SLEEP-PLAN: the firmware's PSCI has no OS-initiated mode So cluster states on zumapro would be platform-coordinated, with a composite StateID; and the core state's rejection rate, read from cpuidle. * device/tegu SLEEP-PLAN: start from what's measured The cable-out s2idle figure (about 140 mA), MIF in sleep (about 57 mA saved), and the cluster power-down tries of 10-28 (cluster 0 hangs; clusters 1-2 save nothing measurable) were already measured; the candidates are re-ranked on them. * device/tegu SLEEP-PLAN: S2's image, its expectation and rollback * device/tegu SLEEP-PLAN: the review's preconditions, S2's before and after, the code by commit The runbook stops if slot B isn't marked successful and doesn't mark it (a devinfo write on the 9a, derekross#125). S1 needs the NFC stop-poll hook active or polling stopped by hand, with the kernel's derekross#131 state and the rule that stays, a Rollback line and pstore after a cycle that doesn't come back. S2 snapshots regulator_summary before and diffs it after, stops if more than the four rails changed, records stock's consumers of them (none in its DT: no phandle on any of the four, the GNSS three on the PMIC's channel mux, LDO15S a spare), keeps the modem off in that boot and stays away from a G3 session. The push wording says what bin/omamobile push writes and that only vendor_kernel_boot differs. The module, the bring-up DT and the S2 change are linked by commit on the fork's tegu-sleep-bringup branch, and the CPU_INFORM hints of 10-28 are credited to the bring-up module that wrote them over the PMU SMC. The measurements link derekross#100's NOTES entry. * device/tegu SLEEP-PLAN: the fingerprint stack stays stopped in S2's boot, S1's command and column S2 says it turns LDO15S off on purpose for one boot against FINGERPRINT-PLAN's rule (that plan gets the matching note once derekross#138 is on main), and step 3 keeps omamobile-fp, the trusted app and storageproxyd stopped before the push and until the rollback, since F6c still writes secure objects. S1 names its command, power-ab with derekross#157's systemd suspend mode (rtcwake -m no plus systemctl suspend, so the NFC hook runs), reads charge_now, column 7, because the 9a's gauge has no charge_counter, and waits for derekross#157. Also: derekross#125's rules are being settled; the four rails read disabled with or without the unused-rail cleanup; stock's source grepped for the four rail names (DT sources and the register header only, no module asks by name); a Polling read before each run; nothing starts the modem at boot, so nothing to mask.
Piece 13's open item: s2idle works on the 9a, but it draws about 140 mA with the cable out (10-27). The plan gathers what's measured: MIF at 421 MHz in sleep saves about 57 mA with the cable in, and the 10-28 cluster power-down tries (cluster 0 hangs; clusters 1 and 2 are stable but save nothing measurable). It adds an audit from Google's
zumapro-cpu.dtsiand a read-only snapshot of the palmtop, which shows the bring-up DTB keeps the three GNSS rails andudfps-3v3always on. The candidates are ranked, with a measurement runbook. S1 needs the cable out and is attended. Docs only.