Repository navigation
docs/review: 34 lessons and 3 corrections from the twenty-fifth and twenty-sixth rounds - #127
Merged
Merged
Conversation
The confirmed candidates from round 25 (L-260 to L-278): the 9a slot B marking as a devinfo question, cross-repository links, squash-merged stacks and version files, stale hand-built prebuilts, and before-merge Pixel 7 Pro runs on omamobile-int. C-16 to C-18 correct our own earlier comments on kernel #98, kernel #80 and #74; L-241 is corrected in place. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
L-279 to L-293: the 9a's slot B hold and what made devinfo writable (#125), per-device flags checked by building both command lines (#101), env defaults in the shared build library and CI waiting for approval (#79), GLib retry paths and radio stops checked at the controller (#99), silent re-pushes and stacks with several tops (the tegu stack), and two of our own: merge only after every check has finished (#126), and an empty diff is checked for empty inputs (kernel #123). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 29, 2026
W4HO-ham
added a commit
to W4HO-ham/omarchy-mobile
that referenced
this pull request
Oct 29, 2026
…erekross#127 line The 10-28 evening entry still says the sleep hook has to power the NFC adapter off, and that fingerprint matching doesn't work. Both are out of date: the ST54L's NFC mode (linux-omarchy-mobile#131, derekross#137) makes the power-off hook unnecessary, and one try of such a hook failed to wake, and matching works since FINGERPRINT-PLAN F9/F10 (derekross#138). Point forward from both bullets so nobody builds the hook from the old note, and wrap the sentence about derekross#127 like the rest of the entry.
W4HO-ham
added a commit
to W4HO-ham/omarchy-mobile
that referenced
this pull request
Oct 29, 2026
… H5 scripts, the meter rule and rollbacks The maintainer's review of the runbook: H2 now copies and enables the early read (and H6 removes it), H1 checks the I2C device nodes and that the DTB dead-man is unarmed and disables it, the meter rule covers any reset with the drive attached, and H4 and H5 have rollback lines and a word on pstore. H5 says plainly that no SSH is guaranteed after the drive-for-laptop swap, what can bring the link back, and the forced restart that boots like H3. The scripts that run while the laptop is out are published next to the early read and started detached with systemd-run: H4's unbinds the charger 20 s after the drive enumerates and logs VBUS and CHG_CNFG_00; H5's resets without a shutdown, and only when the early read is armed and a drive has enumerated. The early read loads i2c-dev itself, since it runs before systemd-modules-load, and waits for the root to be read-write. The DTB paragraph records the gn3 build's sha256 and that it isn't derekross#127 byte for byte; the node comparison against a derekross#127 build is the open step. "settled on derekross#125" is "being settled".
W4HO-ham
added a commit
to W4HO-ham/omarchy-mobile
that referenced
this pull request
Oct 29, 2026
… warm reboots, stock's PDO and the RT9470's lines The open step from the review is done: derekross#127's DTB matches the palmtop's running tree on the three nodes. Four warm reboots today came up as peripheral on the otg node. Stock's source PDO and the RT9470's interrupt and enable lines are traced to Google's tegu and zuma trees.
W4HO-ham
added a commit
to W4HO-ham/omarchy-mobile
that referenced
this pull request
Oct 29, 2026
The RT9470's interrupt and enable are MAX77779 SGPIOs, and stock services the boost's watchdog from that interrupt. The block's driver (kernel derekross#139), the board node and the reworked boost (derekross#127) get one attended boot before H3, with Expect, Stop and Rollback, and the PMIC's register readout from today as the before.
W4HO-ham
added a commit
to W4HO-ham/omarchy-mobile
that referenced
this pull request
Oct 29, 2026
…it doesn't reset, the derekross#127 pin, H4's rollback with the drive in The maintainer's second round. The DTB paragraph no longer calls the node comparison open, since the paragraph below records it, and the status line says derekross#127 is at 5ada9ab0f now, with what the commits after the compared 5dd15e31c changed. The H5 script removes the early read's armed marker on every exit without a reset, so a fallback reboot can't leave a log that looks like H5's; H5 says the read counts only when the script's log ends with the "resetting now" line, and gives the swap timer's command in full. H4's rollback with the drive still in points at H5's swap text, since a boot like H3's needs the laptop back in first.
W4HO-ham
added a commit
to W4HO-ham/omarchy-mobile
that referenced
this pull request
Oct 29, 2026
The derekross#127 DTB can't take the kit's other overlays (a dry pack failed on the first of them), so H2b's delta, the MAX77779 PMIC node with its pin and the boost's two lines, goes on gn3 as a bring-up overlay, where bring-up overlays live. A dry pack applied it and the overlaid tree has all three pieces.
W4HO-ham
added a commit
to W4HO-ham/omarchy-mobile
that referenced
this pull request
Oct 30, 2026
…nterrupt only, with its way back From Derek's review of 2198e47. The H2b overlay no longer gives the boost its enable line: SGPIO7 is the RT9470's charge enable, and driving it with nothing managing the charger could start it charging beside the MAX77779; that line stays with kernel derekross#127, which must clear CHG_EN before taking it. H2b now reads the boost's FUNCTION and ICSTAT after the modprobe, as the H4 script does, and stops if ICSTAT shows charging. Its rollback says what to do when SSH doesn't come back after a forced restart: fastboot by the buttons and stop, no flash without Derek (derekross#125), so the step is risk medium; the header and the DTB paragraph say that H2b's push writes slot B's images through the normal path. The status line says H2b boots gn3 plus the overlay, step 1 is marked done by H2, the H5 script traps TERM so the swap timer's reboot disarms the early read too, the overlay's header says bring-up only, and the watchdog sentences record the reworked boost driver (6c5d97e18) as the follow-up asked for on derekross#131.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The confirmed candidates from rounds 25 and 26, added to
docs/review/LESSONS.md.Round 25
devinfoquestion (AGENTS, device/tegu: a fallback to slot A on the 9a costs the Linux root #125, issue Pixel 9a (tegu / Tensor G4): native bring-up #28), cross-repository#Nlinks, squash-merged stacks and the packageversionfile (device-raven: load the charger at boot, with its temperature guard #112/device-raven 0.1.26: the version #112 named #126, omamobile-shell 0.2.34: home widgets see the phone they run on #115/omamobile-shell 0.2.35: the Pixel 9a's display scale #117), stale hand-built prebuilts (issue Package publish failed on the build machine #109), power-sequencer reference counting (kernel device-lynx: Bluetooth on the APM UART #98), and before-merge Pixel 7 Pro runs onomamobile-int(kernel initramfs, device-felix 0.1.4: unmask both display triggers #82, Fingerprint on the Pixel 9a: its file list, trusted app and KeyMint #71, device-lynx 0.2.0: the device package, the Arch root and the Wi-Fi plan #88).allow_txguard missed in device-tegu 0.1.1: public-kernel boot, native display and guarded touch #74's review.Round 26
devinfowritable (AGENTS, device/tegu: a fallback to slot A on the 9a costs the Linux root #125).Documentation only;
tools/pr-checkpasses.🤖 Generated with Claude Code