Repository navigation
Conversation
|
Thanks, Nate. For a first board file this is the shape I'd hoped for: the binding first, the SoC description untouched, and everything beyond storage, keys, watchdogs and clocks described but disabled. I ran the gate on it even though it's a draft, since it is cheap for a board: it merges cleanly, all 11 device trees build with W=1 with no new warnings, and with dtschema run by hand your DTB validates with zero messages (and is rejected on its compatible by the base's schema, so the check is real). The board id and revision match Google's What has to change before it leaves draft:
What I did not check in this round, and will when it is ready: the CPU tables against stock's limits, the four extra reserved-memory regions, and the battery, charger and GPU properties (all disabled here). Two things to keep in mind for later: the Hall switch is a lid switch to logind, so its enabling commit goes out together with your device package's lid drop-in; and nothing that enables the MAX17201 may write its nonvolatile memory. |
derekross
left a comment
There was a problem hiding this comment.
CI has run on this head and passes: clean merge onto today's omamobile, sign-offs, prefixes, checkpatch (only the "does MAINTAINERS need updating?" note for the new file, which it doesn't), all 11 Google device trees building with W=1 and passing dtbs_check with no new warning, and dt_binding_check on the binding. The one skipped line is "no C files touched". So the build side of the draft is confirmed by CI as well as by my hand run.
What it can't show is the boot, and that is still what this draft waits for: please don't flash it with USB disabled, and the three points in my comment above stand.
4004fc5 to
c1425be
Compare
Add the Google Pixel 9 Pro Fold, a Tensor G4 board, as google,zumapro-comet with the google,zumapro fallback, next to the Pixel 9a. The bootloader's selector properties are the SoC's and are already described. Assisted-by: LLM Signed-off-by: Nate Crawford <nate@kdegeek.com>
Add the Google Pixel 9 Pro Fold (comet), a Tensor G4 board, on the zumapro SoC description the Pixel 9a uses, with what it needs to boot from UFS with its keys, both watchdogs and the USB gadget: - the bootloader's selectors for comet's FOPLP and IPOP parts, its bootargs and the firmware carve-outs its own DT reserves, less the three it inserts itself; - the UFS supply on gpp0-1 and the key banks' interrupts; - comet's CPU levels from its own ACPM table (the inherited levels it doesn't have are deleted, those above what has run on it are turbo-mode) and its lower thermal trips; - the ramoops layout stock uses; - the Pixel 9a's plain DWC3 configuration for USB 2.0 peripheral mode with four clocks and both PHYs enabled. Described but disabled, each to be enabled once it has its own review: - the MAX77779 charger, gauge and USB-C port controller, and the second cell's MAX17201; - the CS40L26A haptics, the LM3644 torch and the ST54L NFC controller; - the fold's Hall switch; - the GPU's ACPM clock and its levels up to 940 MHz. The cover and inner displays, touch, cameras, AoC sensors and audio, Wi-Fi, Bluetooth, the modem, fingerprint, UWB, the board thermistors and wireless charging are left out: their drivers or bindings are not in this tree yet, or need SoC nodes the zumapro description doesn't have. Tested on comet with a cold boot through the bootloader of this DT (with the three inserted carve-outs still listed, which only logged overlaps) on the v7.3-rc6 based 7.3.0-rc6-omamobile-comet-rc2-cand21 kernel: the board booted from UFS to the root file system, both watchdogs were taken over, and dwc3 bound 11210000.usb directly; the gadget was up 3.2 s into boot and the host configured it. Link: https://android.googlesource.com/kernel/devices/google/comet/+/c826c913562277d8d7ee4c089d4a0aab54507637/dts/zumapro-comet-mp.dts Assisted-by: LLM Signed-off-by: Nate Crawford <nate@kdegeek.com>
c1425be to
fb76082
Compare
|
Derek, v3 is pushed. The binding commit is unchanged. Since v2, this board DT has had its cold boot on comet, and the board commit carries the result. Changes in the board commit:
The cold boot (2026-11-18):
I'll keep in mind the lid drop-in that has to come with the Hall switch, and that nothing that enables the MAX17201 may write its NVM. |
This is the kernel side of omarchy-mobile#203, as asked there on 11-12: the
dt-bindings:commit first, new nodes disabled, no other board touched. USB uses the Pixel 9a's plainsnps,dwc3node, so it needs no glue (#271 is closed). It sits on the zumapro SoC description that came in with the Pixel 9a stack (#187 and its base) and changes neitherzumapro.dtsinorzumapro-reserved-memory.dtsi.Evidence
Every value comes from the DT the phone runs every day: kernel
7.3.0-rc6-omamobile-comet-rc2-cand21, and its packed DT compared node by node with this file's DTB.snps,dwc3, the four HSI0 clocks, peripheral mode at high speed) and both PHYs. The phone's daily DT still uses the glue node.Cold boot (2026-11-18)
ABL booted this board DT, unmodified, on
7.3.0-rc6-omamobile-comet-rc2-cand21. That was v2's DTB. v3 differs from it only by dropping the three reserved-memory nodes ABL inserts itself, which had only logged overlaps. The trialvendor_kernel_boot_brestored the daily image from its own init, so a lost USB link would have recovered on the next boot.11210000.usbbound todwc3directly. The gadget was up 3.17 s into boot, and the host configured it (configured driver=dwc3).tmr_atbootin the bootargs, the driver stops them at probe. Userspace then opened and fed them.tools/phone-smoke:7.3.0-rc6-omamobile-comet-rc2-cand21userdataand slot B's boot images writableuserdata11210000.usbgpio-keyssamsung-pinctrl …: irq number not available, fromzumapro.dtsi's pinctrl nodes having nointerrupts. That file isn't touched here, and this board uses no GPIO interrupts on those banks.Differences from the phone's DT, on purpose
gsa-log@905ff000.Left out: no driver or binding here, or no SoC node in
zumapro.dtsidsi1node, and the comet DECON variants are missing. TE comes with them.spi19.google,lrte-packet-delimiterscomes with the camera series. The IMX787 binding is in media: i2c: imx386: IMX787 (Pixel 9 Pro Fold main camera); ak7375: focus after standby and sensor-owned power #272.spi13.Checks
On v3:
checkpatch --strictgives the same singleFILE_PATH_CHANGESwarning, and the DTB builds withdtc, identical to v2's apart from the three dropped nodes.On v2, with
tools/kernel-pr-check --build OUT --merge origin/omamobile HEAD:dt_binding_checkpasses ongoogle.yaml.checkpatch --strict: no errors, one warning (FILE_PATH_CHANGES).exynos/google/is already in MAINTAINERS.zumapro-comet.dtbon its own builds with zero.Merges after
Nothing.
🤖 Generated with Claude Code