Repository navigation
Conversation
…upts The PERIC0, PERIC1, HSI1, HSI2 and HSI2UFS pin controllers have no interrupts property, so their GPIO interrupt (EINT) setup fails at every boot of a zumapro board: samsung-pinctrl 10840000.pinctrl: irq number not available once for each of the five. The controllers have no GPIO interrupts until it succeeds. Add each controller's GPIO interrupt, as zuma.dtsi does for the same controllers. The numbers are those of Google's zumapro interrupt header (IRQ_GPIO_PERIC0_PERIC0 634, IRQ_GPIO_PERIC1_PERIC1 649, IRQ_GPIO_HSI1_HSI1 413, IRQ_GPIO_HSI2_HSI2 432 and IRQ_GPIO_HSI2UFS_HSI2 433), which also gives the SPIs this file already uses, such as 643 for USI2 on PERIC0. This reaches the Pixel 9a and the Pixel 9 Pro Fold. The Fold's daily kernel (7.3.0-rc6-omamobile-comet-rc2-cand21) runs with these five interrupts in its device tree: /proc/interrupts lists all five parent interrupts requested, and none of the five warnings is logged. No node on either board takes a GPIO interrupt on these banks yet, so the five haven't fired there; every GPIO interrupt user in their device trees is on a gpa or gpn bank, which belong to the ALIVE, FAR and CUSTOM controllers. Link: https://android.googlesource.com/kernel/google-modules/soc/gs/+/3045cdcfebf91dc1d3bb3170967d23169d3b65af/include/dt-bindings/interrupt-controller/zumapro.h Assisted-by: LLM Signed-off-by: Nate Crawford <nate@kdegeek.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The follow-up promised on #273: the five GPIO interrupts that
zumapro.dtsi's pin controllers are missing.What and why
The PERIC0, PERIC1, HSI1, HSI2 and HSI2UFS pin controllers have no
interruptsproperty. So the driver's GPIO interrupt (EINT) setup fails for each of them at every boot of a zumapro board:This logs once per controller, and those banks have no GPIO interrupts. The commit adds each controller's interrupt the way
zuma.dtsidoes:The numbers are the
IRQ_GPIO_*values in Google's zumapro interrupt header (GPL, linked in the commit). The same header gives the SPIs this file already uses, for example 643 for USI2 on PERIC0, so the numbering matches.Evidence
7.3.0-rc6-omamobile-comet-rc2-cand21) logged all five warnings./proc/interruptslists all five parents (10840000.pinctrl…13060000.pinctrl) as requested, and none of the warnings appears.gpaorgpnbank, which belong to the ALIVE, FAR and CUSTOM controllers.This reaches the Pixel 9a, through the shared dtsi. It is not booted on a 9a. I'd welcome one boot there: the five warnings should be gone, with nothing else changed.
Checks
checkpatch --strict: no errors, warnings or checks.W=1 CHECK_DTBS=yforzumapro-comet.dtb(with arm64: dts: exynos: google: Add the Pixel 9 Pro Fold (comet) #273's v3) andzumapro-tegu.dtb, with dtschema 2026.9: no warnings, the same as without the patch. Both DTBs carry the five interrupts.omamobile. It doesn't depend on arm64: dts: exynos: google: Add the Pixel 9 Pro Fold (comet) #273.🤖 Generated with Claude Code