Repository navigation
arm64: dts: exynos: google: zuma-husky: Default to suspend-to-idle - #244
Conversation
The firmware advertises PSCI SYSTEM_SUSPEND, so the kernel offers deep sleep and makes it the default: /sys/power/mem_sleep reads "s2idle [deep]" on the Pixel 8 Pro. Linux has no zuma sleep sequence yet, so a deep suspend does not wake: on a Pixel 8 Pro (G1MNW) whose battery ran low, upower asked for a suspend, the log ends at "PM: suspend entry (deep)" and the phone stayed down until it was restarted. Pass mem_sleep_default=s2idle, as the Pixel 8a does, so a suspend that names no state stays in s2idle. The omamobile-device-husky package asks systemd for s2idle since 0.1.10; this covers anything that writes "mem" directly, rtcwake -m mem among them. Not booted yet with this line; the same argument is on the Pixel 8a, the Pixel 7 Pro, the Pixel 7 and the Pixel 9a. Suggested-by: Derek Ross <derekross@gmail.com> Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: Colin Lundholm <265166644+gitColinX@users.noreply.github.com>
|
Thank you, @gitColinX, for following up on #656 the same day, and for the account of what happened on your phone. A battery-critical suspend that went to I compared it with #238: the argument is in the same place, the comment is the 8a's word for word, and the built device tree differs from today's in that one string and nothing else. The gate passes on today's The commit says plainly that it hasn't booted yet, and I'm fine merging it that way once CI is green: it is one kernel parameter on the end of a string, the 8a showed it arriving in Two things to know, neither for this PR:
#243 touches the same file in another place; the two merge cleanly in either order. |
|
@derekross, the readings you asked for, late: on published |
The kernel line @derekross asked for in derekross/omarchy-mobile#656:
mem_sleep_default=s2idleinzuma-husky.dts, as #238 has it for the 8a. One commit, one file: the argument on the end ofbootargsand the 8a's three comment lines above it.Why it matters on this phone
/sys/power/mem_sleepreadss2idle [deep]on my Pixel 8 Pro (G1MNW), onhusky-test-20261109-t1plus my RTC test commits.suspend requested from client PID 1340 ('upowerd')), and the last line of that boot's journal isPM: suspend entry (deep). It did not wake, and came back only when it was restarted. The root still hadomamobile-device-husky0.1.8, so there was no drop-in either.systemctl suspend. This line covers what writesmemitself,rtcwake -m memamong them.Not tested: I have not booted a kernel with this line. I can build it on the t1 tree and report
/proc/cmdlineand/sys/power/mem_sleepfrom the phone if that is wanted before merge. Suspend to idle itself is still not something I have run on this unit; the runbook Derek described in #656 comes first.Checks:
tools/kernel-pr-check --build --mergepasses: it merges cleanly ontofc7086a68, checkpatch --strict has no errors (its warnings are the longbootargsline, as on the 8a, and theCo-Authored-Bytrailer's spelling), and 10 device trees build with W=1 and pass dtbs_check with no new warnings. No C files are touched.