Repository navigation
arm64: dts: exynos: google: zuma-husky: the main PMIC's interrupt, so the Pixel 8 Pro has an RTC alarm - #243
Conversation
Tensor G3 (zuma) latches the main PMIC's in-band interrupt in a VGPIO2AP system register block at 0x15090000, as zumapro does at the same address and gs201 at 0x182f0000; the PMIC driver reads it through the google,vgpio2ap-sysreg phandle of the samsung,s2mpg14-pmic binding. Add the compatible, with no clock, as theirs. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: Colin Lundholm <265166644+gitColinX@users.noreply.github.com>
The system registers that latch the main PMIC's in-band interrupt (GIC SPI 74 on this SoC), the way zumapro.dtsi and gs201.dtsi describe theirs. The address is SYSREG_VGPIO2AP in Google's s2mpg14-register.h (kernel/google-modules/soc/gs, android-gs-shusky-6.1-android16), where s2mpg14-irq.c maps it with INTC0_IPEND at 0x290. A PMIC node points at it with google,vgpio2ap-sysreg; nothing uses it until a board does. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: Colin Lundholm <265166644+gitColinX@users.noreply.github.com>
Without an interrupt the S2MPG14 driver supplies its rails but none of
the PMIC's events reach the host ("no interrupt, so no RTC alarm" at
boot), so rtc0 has no wake alarm on the Pixel 8 Pro. The interrupt is
GIC SPI 74, as stock's s2mpg14mfd node has it on this board
(interrupts = <0 0x4a 4>), latched by the VGPIO2AP sysreg, as the gs201
boards and the Pixel 9a have it; wakeup-source makes the alarm a wake
source for suspend, which has not been run on this phone yet.
On a Pixel 8 Pro (G1MNW) with these three commits on the display and
GPU test tree: no "no RTC alarm" line, rtc0 has wakealarm, the
s2mpg14-pmic interrupt line counts 0 until an alarm armed with
rtcwake -m no -s 60 fires on time (rtc-alarm0 0 to 1), no failed units.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Signed-off-by: Colin Lundholm <265166644+gitColinX@users.noreply.github.com>
|
Thank you, @gitColinX. This is a tidy port of #236: the same three steps in the same order, and the two values that had to be the Pixel 8 Pro's own are sourced rather than copied. I checked both against Google's tree on What I ran: the gate passes on today's Your evidence is the right kind: the Nothing to change in the commits. I'll merge once CI is green. Four small things, none of which holds it up:
One correction to the description, not the commits: suspend has run on the model, on Somnius's phone (omarchy-mobile #640 and #642); "never on this unit" is the accurate form, as your commit message already has it. #244 touches the same file in another place; the two merge cleanly in either order. |
|
@derekross, I owe you answers to the four things you asked here on 11-12. Sorry for the delay. The tested tree. The three MFD files are The On published
NOTES and ROADMAP: in derekross/omarchy-mobile#835 (the 2026-11-15 NOTES entry has the RTC lines, and ROADMAP's Time row no longer says "No RTC"). And yes on the description: "never on this unit" is right. Somnius's runs were first on the model. |
On
omamobilethe Pixel 8 Pro's main PMIC has no interrupt:sec-pmic-acpm firmware:power-management:pmic-1: no interrupt, so no RTC alarmat boot, andrtc0has nowakealarm. This is #236's fix for the 9a, on zuma.Three commits, the way #236 has them:
google,zuma-vgpio2ap-sysregcompatible in the sysreg binding (no clock, as zumapro's and gs201's);zuma.dtsi;interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>,google,vgpio2ap-sysregandwakeup-sourceonpmic-1inzuma-husky.dts.Where the two values come from
s2mpg14mfdnode on my phone hasinterrupts = <0 0x4a 4>(its owndtbo, board id 0x40206).SYSREG_VGPIO2APin Google'sinclude/linux/mfd/samsung/s2mpg14-register.h(kernel/google-modules/soc/gs,android-gs-shusky-6.1-android16);drivers/mfd/s2mpg14-irq.cmaps it withINTC0_IPENDat 0x290, whichS2MPG14_VGPIO2AP_INTC0_IPENDalready is here.On my phone (G1MNW, 2026-11-11): the same changes on
husky-test-20261109-t1(with #233 and one more test commit that nothing on this boot ran),7.3.0-rc6-omamobile-push1-g755b5d1c5532, its own modules installed.rtc0haswakealarm.s2mpg14-pmicline in/proc/interruptsstayed at 0 for the first two minutes.rtcwake -m no -s 60armed the alarm and it fired on time:rtc-alarm00 to 1,s2mpg14-pmic0 to 2.tools/phone-smokepasses every required check.Not tested: suspend. It has never run on the 8 Pro, and I only armed the alarm with the phone awake. I have not booted this exact branch on today's
omamobile; the device tree changes are the same lines. The 8a (zuma-akita.dts) gets the syscon node fromzuma.dtsibut nothing there points at it; @aninmucek may want the same three lines on itspmic-1once someone reads its stock interrupt.Checks:
tools/kernel-pr-check --build --mergepasses: it merges cleanly ontofc7086a68, checkpatch --strict has no errors (its warnings are theCo-Authored-Bytrailer's spelling), 10 device trees build with W=1 and pass dtbs_check with no new warnings, and dt_binding_check passes on the one binding. No C files are touched.