Repository navigation
Conversation
Some boards connect the LM3644's external STROBE input to a GPIO. Torch-only operation must keep this active-high input low rather than leave it available to another consumer while HWEN is asserted. Describe an optional strobe-gpios property so the torch driver can own and hold that line inactive. Existing boards without the property keep their current behavior. Assisted-by: LLM Signed-off-by: Garrett lindquist <gr_link@hotmail.com>
Oriole's camera wiring includes a separate external strobe GPIO. The existing torch bring-up controller holds it low, but the native driver only owns HWEN. Moving the board description into the native device tree must preserve that ownership without the separate controller. Request the optional strobe GPIO as an inactive output before requesting HWEN or identifying the chip. Abort probe on a GPIO acquisition error. Device-managed ownership keeps strobe inactive throughout the device's lifetime and releases HWEN before strobe during probe unwind or removal. Boards without strobe-gpios retain the existing torch behavior. Build-tested with W=1, full Image/modules linking and modpost. The changed driver also links against the retained Oriole integration SDK. The new strobe ownership has not been exercised on hardware. Assisted-by: LLM Signed-off-by: Garrett lindquist <gr_link@hotmail.com>
Describe Oriole's LM3644 on HSI2C7 at 0x63, with HWEN on gpp23-6 and the external strobe on gpp27-0, following Google's GPL camera device tree: https://android.googlesource.com/kernel/devices/google/raviole/+/81506b991a5385be6c59ee27df4dda2b1379c507/dts/gs101-oriole-camera.dtsi Keep USI7, HSI2C7 and the LED controller disabled pending qualification of the native GPIO ownership on the current kernel. Use 100 kHz bus timing, one current sink, a conservative 6000 microamp limit and default off. The existing I2C pin group uses only gpp14-0/1. The existing qualified controller and native LED driver produced visible rear light at brightness 1 during a three-second test and returned to verified HWEN-low. That path uses separate strobe ownership and does not qualify the new strobe-gpios property or enable these nodes by default. The disabled DTB and an enable-only test overlay pass schema validation. Assisted-by: LLM Signed-off-by: Garrett lindquist <gr_link@hotmail.com>
|
Thank you, @Gr-linkk. This is a tidy series: the binding first, then the driver, then the board, with USI7, the bus and the LED node all left disabled. I checked the wiring against Google's Three small things before I merge:
For later, not for this PR: turning the nodes on is its own commit after a boot of this tree, with the enable overlay under |
Describe the Pixel 6 rear torch in the native board tree while preserving the external strobe safeguard currently supplied by its separate bring-up controller. Keep USI7, HSI2C7 and the LED controller disabled; this does not enable torch at boot.
The three commits add the optional
strobe-gpiosbinding, request that GPIO inactive before HWEN in the existing LM3644 driver, and describe Oriole's wiring. The board uses one sink, a conservative 6000 microamp cap, 100 kHz bus timing and default off. No private staging framework, firmware, calibration or package payload is included. Existing boards without the property retain their behavior.Validation:
df3a12b9base. The final commits are onfc7086a6; its four intervening upstream commits touch unrelated files, and the three-file patch is byte-identical, so those build/schema results are reused. Its 1171 compiler warnings exactly match the saved broad-build baseline by normalized file/line/message; none are new torch warnings.7.3.0-rc6-oriole-hsi1-late-dev0-g4bd35d34abb9-dirty, the modified LM3644 module was tested against its matching integration SDK on a fresh boot with the old torch provider suppressed. A guarded staging helper supplied the node and released both initially-low GPIOs before LED probe; the native driver then owned both STROBE and HWEN. Cold ID/reset checks, default-off state, maximum brightness 2, and both raw GPIO levels low passed.toggleTileaction was invoked through its documented IPC as the desktop user, exercising the same backend as the torch tile. It selected brightness 2 (nominal 5460 microamps), reported On, then returned to brightness zero/HWEN low and Off in about 1.04 seconds, before the five-second fallback. This was an IPC test, not a physical touchscreen tap. Current values are programmed nominal values, not measured LED current.The new native GPIO ownership, bounded light output, shell control, NFC startup coexistence, and off-state ordered shutdown/clean restart have been tested on the existing integration kernel. The board nodes remain disabled. Shutdown while lit, interrupted-native-marker/power-loss recovery, persistent native-driver autostart, and a phone boot of the public-tree Image have not been qualified. No default-enable or full-phone support claim is made here. The private staging helper and test packaging are not part of this PR.
Related work: Raven torch support in #113 is already merged. This reuses that LM3644 driver and existing standard LED/shell control path; it does not replace them.
AI assistance: Codex helped compare the GPL board wiring and retained evidence, implement the three focused changes, and run the builds and guarded pulse. Commits credit
Assisted-by: LLM.Independent Astra review of the settled patch reported no findings. Final commit checks pass strict checkpatch (zero warnings/checks), whitespace and identifier/blob policy; all three commits have the human author's DCO sign-off.