Skip to content

device-oriole: record rear torch integration test in the device matrix - #871

Open
Gr-linkk wants to merge 2 commits into
derekross:mainfrom
Gr-linkk:oriole-torch-observation
Open

Gr-linkk wants to merge 2 commits into
derekross:mainfrom
Gr-linkk:oriole-torch-observation

Conversation

@Gr-linkk

Copy link
Copy Markdown
Contributor

The Pixel 6 torch cell says “no”. On November 10 the owner saw the rear LED turn on and off on the private integration kernel. The shell tile action also returned brightness to zero and the hardware enable line to low before its fallback fired. The notes identify the kernel and private setup.

Change only the torch cell to WIP. The public device package still leaves the torch disabled. Testing the public kernel and enable overlay is a separate step in derekross/linux-omarchy-mobile#242.

Checked the saved observation, shell tile and final-off records. Repository policy and whitespace checks pass. Documentation only.

The owner observed the rear LED turn on and off on the private integration kernel. Link the matrix to the hardware result and keep public enablement pending.

Assisted-by: LLM
@derekross

Copy link
Copy Markdown
Owner

Thank you, @Gr-linkk. The entry says plainly that this was your private kernel with a helper supplying the node, and that the public package doesn't enable the torch. That is how I want these recorded.

Two wording fixes and it goes in:

  1. The cell. "public board node disabled" reads as if the published kernel had the node. It doesn't yet: the node is in linux-omarchy-mobile#242, which is still open, so on today's release kernel the Pixel 6 has no torch node at all. The row's other cells all start with the "unpublished kernel/packages" link, so please use the same form here, for example:

    WIP ([unpublished kernel/packages](../device/oriole/NOTES.md#2026-11-10-rear-torch-on-the-integration-kernel); the rear LED turned on and off from the shell's tile with a private helper supplying the LED node; the board node is in review, disabled, as [kernel #242](https://github.com/derekross/linux-omarchy-mobile/pull/242), and has not run)

  2. The last sentence of the NOTES entry. "that public kernel" and "the Oriole enable overlay": omamobile-shell test: the weather words check skips without node #242 isn't merged, and I can't find the overlay in any pull request. Please say "with kernel omamobile-shell test: the weather words check skips without node #242 once it is merged" and that the enable overlay is still to be written.

Three small additions to the entry, if you can: what the helper is (a module that registers the LED's I2C device, or an overlay), that this run is not a test of #242's strobe handling (its commit messages say that path hasn't run on hardware), and which shell ran (your notes say the phone has a local 0.2.12).

On #242 itself, my three points from 11-11 are still open (the commit messages against the description, the binding text, samsung,clkreq-on). Once it merges, this cell gets one more edit.

Record the observation on the unpublished integration setup and identify the proposed board node and remaining enablement work.

Assisted-by: LLM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants