Repository navigation
arm64: dts: exynos: google: gs201-panther: enable the MAX77759's I2C bus - #167
Conversation
Enable USI13 as I2C at 400 kHz, as the Pixel 7 Pro does: the MAX77759 (Type-C port controller at 0x25, PMIC at 0x66, fuel gauge at 0x36, charger at 0x69) sits there, on gpp25-0/1, in the Pixel 7's live device tree too. Its devices stay undescribed for now: the Type-C port controller would take over VBUS and the data role from the forced-VBUS setup the USB PHY uses, and the USB link is the only way into the phone. With the bus up, user space can close the MAX77759's USB2 data switch after a replug (TCPC vendor register 0x93), which the chip opens on unplug; until a Type-C driver owns it, nothing else does, and the phone stays off the bus. Tested on a Pixel 7 from slot B (7.3.0-rc6), with the touchscreen, GPU and haptics: the bus probes as i2c-1, the TCPC's USBSW_CTRL reads 0x09 and the charger's CHG_DETAILS_00 0x60 (VBUS valid). After an unplug the switch read 0x00; omamobile-usb-rescue set it back to 0x09 and USB networking came back by itself, with no I2C errors. Assisted-by: Claude Opus 5.5 Signed-off-by: Alejandro Garcia <skipper.pelygro@gmail.com>
|
Thank you, @nesmeck. Enabling only the bus is the careful way to do this, and the message gives exactly the right reason for leaving the port controller out while the forced-VBUS setup owns USB. The node is the same as the Pixel 7 Pro's (I2C mode, 400 kHz), and Google's Optional, for a later push: stock also has the PCA9468 direct charger at 0x57 on this bus ( |
Enable USI13 as I2C at 400 kHz, as the Pixel 7 Pro does. The MAX77759 sits on that bus, on gpp25-0/1: the Type-C port controller at 0x25, the PMIC at 0x66, the fuel gauge at 0x36 and the charger at 0x69. The Pixel 7's live device tree has the same bus.
Only the bus, no children. A Type-C port controller node would take over VBUS and the data role from the forced-VBUS setup the USB PHY uses, and USB is the only way into the phone. Describing the chips is a later step.
Why now. The MAX77759 opens its USB2 data switch when the cable is unplugged, and nothing closes it again, so after a replug the phone stays off the bus until it reboots. With the bus up,
omamobile-usb-rescuecloses it from user space through TCPC vendor register 0x93. That is the script cheetah already uses, and it comes toomamobile-device-pantherin a later repo PR.Tested on a Pixel 7 (slot B, 7.3.0-rc6), with the touchscreen, the GPU and the haptics:
i2c-1.0x09and the charger's CHG_DETAILS_00 reads0x60(VBUS valid).0x00.omamobile-usb-rescueset it back to0x09, USB networking came back by itself in about 9 s, and there were no I2C errors.omamobile(b0d62d9), it booted twice more (…-g8c9496448397, with the old Input: ft3658 - review fixes: DMA-safe buffers, fsleep(), the Google source #133 head, and…-ge57e346e9b71). Both timesi2c-1was up, the switch read0x09and the charger0x60. The phone-smoke report from the second boot is in the touch PR.Checks:
tools/kernel-pr-check --build OUT --merge origin/omamobilepasses everything:🤖 Generated with Claude Code