Repository navigation
arm64: dts: exynos: google: gs201-panther: match stock's touch interrupt pull-up and CS setup delay - #166
Merged
derekross merged 2 commits intoNov 1, 2026
Conversation
Google's panther touch file sets a pull-up on the FT3658's interrupt pin, gpa7-0 (&ts_irq in gs201-panther-touch.dtsi, EXYNOS_PIN_PULL_UP), and the Pixel 7's live device tree has it (ts-irq, samsung,pin-pud = 3). The shared gs201 group has no pull, as the Pixel 7 Pro wants, so override it in this board file only. Touch worked without it, since the controller drives the line; this matches stock. Tested on a Pixel 7 from slot B (7.3.0-rc6), together with the next patch: the live device tree has samsung,pin-pud = 3 in ts-irq-pins, pinctrl reports gpa7-0 in that group, and the controller probes (chip id 0x56, firmware 0x16) and reports touches across the panel. Suggested-by: Derek Ross <derekross@gmail.com> Assisted-by: Claude Opus 5.5 Signed-off-by: Alejandro Garcia <skipper.pelygro@gmail.com>
…chip select Stock waits 1 us from asserting the FT3658's chip select to the first clock: cs-clock-delay = <1> in the touch node's controller-data, in Google's gs201-panther-touch.dtsi and in the Pixel 7's live device tree. Upstream spells it spi-cs-setup-delay-ns, which the SPI core applies after it drives a GPIO chip select, as this one is. Tested on a Pixel 7 from slot B (7.3.0-rc6), together with the previous patch: the touch node has spi-cs-setup-delay-ns = 1000 in the live device tree, and the controller probes (chip id 0x56, firmware 0x16) and reports touches across the panel with no CRC errors. Suggested-by: Derek Ross <derekross@gmail.com> Assisted-by: Claude Opus 5.5 Signed-off-by: Alejandro Garcia <skipper.pelygro@gmail.com>
Owner
|
Thank you, @nesmeck. This is exactly the first point from #134, and in the right place: the override lives in What I checked:
Thanks for the smoke report and the full release string. Merged with "Rebase and merge". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Point 1 of your review on #134: the two stock touch details the node didn't carry, one commit each, with
Suggested-by: Derek Ross. Both go ings201-panther.dtsonly.&ts_irq { samsung,pin-pud = <GS101_PIN_PULL_UP>; };, after Google'sgs201-panther-touch.dtsi. The Pixel 7's live device tree has the same thing (ts-irq,samsung,pin-pud = 3).gs201-pinctrl.dtsiis unchanged, so the Pixel 7 Pro keeps its group without a pull.spi-cs-setup-delay-ns = <1000>in the touch node, stock'scs-clock-delay = <1>. The chip select is a GPIO, and the SPI core waitscs_setupafter it drives one.Tested on a Pixel 7 (slot B,
7.3.0-rc6-omamobile-push1-ge57e346e9b71). The kernel was today'somamobile(b0d62d9) with #133 and the USB bus PR, with both commits together:samsung,pin-pud = 3ints-irq-pins, and pinctrl reports gpa7-0 in that group.spi-cs-setup-delay-ns = 1000.focaltech_ft3658reads chip id0x56, firmware0x16. Touches work across the panel, and so does the PIN unlock.dmesgshows no SPI or CRC errors.I didn't test the two commits on separate boots. The boot before this one ran the same tree without them, and touch worked there too.
Checks:
tools/kernel-pr-check --build OUT --merge origin/omamobilepasses everything:phone-smoke from this boot
phone-smoke: panther
Kernel
7.3.0-rc6-omamobile-push1-ge57e346e9b71, tools atd9bb1d5, 2026-10-31T23:47Z.Packages: hyprland 0.56.2-5.1, libcamera 0.7.2-4.21, mesa 1:26.2.4-1.4, omacam 0.3.3-1, omamobile-apps 0.2.0-1, omamobile-device-panther 0.1.1-1, omamobile-firstboot 0.1.2-1, omamobile-keyring 20261026-1, omamobile-mirror 0.1.1-1, omamobile-omarchy 0.1.12-1, omamobile-owl-widgets 0.1.1-1, omamobile-shell 0.2.28-1, omarchy 4.0.6-1, quickshell 0.3.2.r7.g2b4501a-1
🤖 Generated with Claude Code