Skip to content

arm64: dts: exynos: google: gs201-panther: match stock's touch interrupt pull-up and CS setup delay - #166

Merged
derekross merged 2 commits into
derekross:omamobilefrom
nesmeck:omamobile-gs201-panther-touch-stock
Nov 1, 2026
Merged

derekross merged 2 commits into
derekross:omamobilefrom
nesmeck:omamobile-gs201-panther-touch-stock

Conversation

@nesmeck

@nesmeck nesmeck commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

Point 1 of your review on #134: the two stock touch details the node didn't carry, one commit each, with Suggested-by: Derek Ross. Both go in gs201-panther.dts only.

  • Pull-up on the interrupt pin. &ts_irq { samsung,pin-pud = <GS101_PIN_PULL_UP>; };, after Google's gs201-panther-touch.dtsi. The Pixel 7's live device tree has the same thing (ts-irq, samsung,pin-pud = 3). gs201-pinctrl.dtsi is unchanged, so the Pixel 7 Pro keeps its group without a pull.
  • 1 µs from chip select to the first clock. spi-cs-setup-delay-ns = <1000> in the touch node, stock's cs-clock-delay = <1>. The chip select is a GPIO, and the SPI core waits cs_setup after it drives one.

Tested on a Pixel 7 (slot B, 7.3.0-rc6-omamobile-push1-ge57e346e9b71). The kernel was today's omamobile (b0d62d9) with #133 and the USB bus PR, with both commits together:

  • The live device tree has samsung,pin-pud = 3 in ts-irq-pins, and pinctrl reports gpa7-0 in that group.
  • The touch node has spi-cs-setup-delay-ns = 1000.
  • focaltech_ft3658 reads chip id 0x56, firmware 0x16. Touches work across the panel, and so does the PIN unlock.
  • dmesg shows no SPI or CRC errors.
  • The haptics and the GPU work as before.

I didn't test the two commits on separate boots. The boot before this one ran the same tree without them, and touch worked there too.

Checks: tools/kernel-pr-check --build OUT --merge origin/omamobile passes everything:

phone-smoke from this boot

phone-smoke: panther

Kernel 7.3.0-rc6-omamobile-push1-ge57e346e9b71, tools at d9bb1d5, 2026-10-31T23:47Z.

Check Result Detail
boot (required) ok kernel 7.3.0-rc6-omamobile-push1-ge57e346e9b71, slot b, up 1034s
storage guard (required) ok 55 partitions; only userdata and slot B's boot images writable
root (required) ok ext4 on userdata, 98G free
kernel health (required) ok no oops or BUG; 0 WARN, 6 error lines in dmesg
systemd units ok none failed
USB gadget (required) ok bound to 11210000.usb
display ok card0-Unknown-1 connected, 1080x2400
GPU ok render node on panthor
session (required) ok Hyprland and the Omarchy shell running
lock ok PAM file present, the shell can lock (passwordPam true, locked false)
touch ok FocalTech FT3658
buttons ok gpio-keys
Wi-Fi skip no wireless interface
Bluetooth skip no controller
battery skip no battery power supply
sound cards skip none
sensors skip no sensor proxy
cameras skip no libcamera tools

Packages: hyprland 0.56.2-5.1, libcamera 0.7.2-4.21, mesa 1:26.2.4-1.4, omacam 0.3.3-1, omamobile-apps 0.2.0-1, omamobile-device-panther 0.1.1-1, omamobile-firstboot 0.1.2-1, omamobile-keyring 20261026-1, omamobile-mirror 0.1.1-1, omamobile-omarchy 0.1.12-1, omamobile-owl-widgets 0.1.1-1, omamobile-shell 0.2.28-1, omarchy 4.0.6-1, quickshell 0.3.2.r7.g2b4501a-1

🤖 Generated with Claude Code

Google's panther touch file sets a pull-up on the FT3658's interrupt
pin, gpa7-0 (&ts_irq in gs201-panther-touch.dtsi, EXYNOS_PIN_PULL_UP),
and the Pixel 7's live device tree has it (ts-irq, samsung,pin-pud = 3).
The shared gs201 group has no pull, as the Pixel 7 Pro wants, so
override it in this board file only. Touch worked without it, since the
controller drives the line; this matches stock.

Tested on a Pixel 7 from slot B (7.3.0-rc6), together with the next
patch: the live device tree has samsung,pin-pud = 3 in ts-irq-pins,
pinctrl reports gpa7-0 in that group, and the controller probes (chip
id 0x56, firmware 0x16) and reports touches across the panel.

Suggested-by: Derek Ross <derekross@gmail.com>
Assisted-by: Claude Opus 5.5
Signed-off-by: Alejandro Garcia <skipper.pelygro@gmail.com>
…chip select

Stock waits 1 us from asserting the FT3658's chip select to the first
clock: cs-clock-delay = <1> in the touch node's controller-data, in
Google's gs201-panther-touch.dtsi and in the Pixel 7's live device tree.
Upstream spells it spi-cs-setup-delay-ns, which the SPI core applies
after it drives a GPIO chip select, as this one is.

Tested on a Pixel 7 from slot B (7.3.0-rc6), together with the previous
patch: the touch node has spi-cs-setup-delay-ns = 1000 in the live
device tree, and the controller probes (chip id 0x56, firmware 0x16)
and reports touches across the panel with no CRC errors.

Suggested-by: Derek Ross <derekross@gmail.com>
Assisted-by: Claude Opus 5.5
Signed-off-by: Alejandro Garcia <skipper.pelygro@gmail.com>
@derekross
derekross merged commit 5faac75 into derekross:omamobile Nov 1, 2026
1 check passed
@derekross

Copy link
Copy Markdown
Owner

Thank you, @nesmeck. This is exactly the first point from #134, and in the right place: the override lives in gs201-panther.dts, so the Pixel 7 Pro's pin group stays as it is.

What I checked:

  • Both commits match Google's gs201-panther-touch.dtsi: the pull-up on &ts_irq, and cs-clock-delay = <1> in the touch node's controller-data. Google's spi-s3c64xx waits cs-clock-delay microseconds after driving a GPIO chip select (stock's spi_0 has cs-gpios = <&gpp20 3 …>), and our SPI core does the same with spi-cs-setup-delay-ns, so 1000 ns is the same wait.
  • It merges cleanly onto today's omamobile (c534374), alone and with arm64: dts: exynos: google: gs201-panther: enable the MAX77759's I2C bus #167; the checks pass, and dt-validate reports nothing on the panther DTB before or after.
  • The built DTB has samsung,pin-pud = <3> in ts-irq-pins and the 1000 ns delay; the Pixel 7 Pro, Fold, 7a and 9a DTBs are byte-identical with and without it.

Thanks for the smoke report and the full release string. Merged with "Rebase and merge".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants