Skip to content

arm64: dts: exynos: gs101-raven: add the rear flash LED - #113

Merged
derekross merged 2 commits into
derekross:omamobilefrom
robotosaith:omamobile-gs101-torch-pr
Oct 28, 2026
Merged

derekross merged 2 commits into
derekross:omamobilefrom
robotosaith:omamobile-gs101-torch-pr

Conversation

@robotosaith

Copy link
Copy Markdown
Contributor

The Pixel 6 Pro's rear flash LED driver is the same TI LM3644TT as the Pixel 7 Pro's, so cheetah's torch-only leds-lm3644 driver covers it.

  • lm3644: the Pixel 6 uses it too: says so in the Kconfig help text.
  • add the rear flash LED: the LM3644 at 0x63 on I2C 7 (USI7), with HWEN on gpp23-6, as stock's raven device tree describes it. Torch only, both LEDs, capped at 50 mA per channel (cheetah's bring-up limit, not a stock value).

Tested on raven (7.3.0-rc6): the driver reads the LM3644TT (device ID 0x04) and offers 17 torch steps, 2550–49110 µA per channel. The LED turns on and off by hand and from the shell's torch tile (brightnessctl through logind, no udev rule needed). tools/kernel-pr-check passes with --build; dt-validate reports nothing new; the 4 checkpatch warnings are the Co-Authored-By: trailer, as in #8.

🤖 Generated with Claude Code

@derekross

Copy link
Copy Markdown
Owner

Thanks. I checked the node against stock's gs101-raven-camera.dtsi: flash-lm3644 on hsi2c_7 at 0x63, HW_ENABLE on gpp23-6, 370 kHz. All match, and torch-only with cheetah's 50 mA cap is the right start. Adding it enabled in one commit is fine here: the driver and node are the Pixel 7 Pro's, and you've tested it on the phone. The LM3644 object for cheetah is unchanged, since only the help text moved.

One small thing before I merge: the DT commit's subject is arm64: dts: exynos: gs101-raven: …, while every other commit on that file (and your #111, #112 and #114) uses arm64: dts: exynos: google: gs101-raven: …. Since kernel PRs land commit by commit, could you add google: when you rebase this onto #112?

@robotosaith

Copy link
Copy Markdown
Contributor Author

Smoke report from the build that runs this: #112 (comment).

google: is added to the DT commit; I'll push it with the rebase onto #112.

@robotosaith
robotosaith force-pushed the omamobile-gs101-torch-pr branch from 176e160 to c1b3b11 Compare October 28, 2026 17:09
@derekross

Copy link
Copy Markdown
Owner

Thanks, the DT commit now says arm64: dts: exynos: google: gs101-raven:, which is what lands with a rebase merge. (The PR title still lacks google:, but only the commit subjects land.)

The branch is on today's omamobile, not on #112, so once #112 is merged this conflicts at the end of gs101-raven.dts, where both add their nodes. The resolution is to keep both: the battery's &pmic { monitored-battery = <&battery>; }; block first, then your &usi7 and &hsi2c_7 blocks. I built that combination with #112 and #114 on top: it builds, raven's DTB validates with nothing new, and the Pixel 7 Pro's is byte-identical. You can push the rebase, or I can do it on your branch when I merge; whichever suits you.

For future raven DT PRs: stacking them (each on the previous one's branch) saves a rebase round each time, since they all add at the end of the same file.

robotosaith and others added 2 commits October 28, 2026 19:20
The Pixel 6 Pro's rear flash LED is an LM3644TT on I2C 7, driven by the
same torch-only driver as the Pixel 7's. Say so in the help text.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: saiththerobo <the.tom.sharp@gmail.com>
The Pixel 6 Pro's rear flash LED driver is a TI LM3644 at 0x63 on I2C 7
(USI7), with its HWEN on gpp23-6, as stock's raven device tree describes
it. Torch only, capped at 50 mA per channel (a bring-up limit).

Tested on raven (7.3.0-rc6): the driver reads the LM3644TT (device ID
0x04) and offers 17 torch steps, 2550-49110 uA per channel; the LED
turns on and off by hand and from the shell's torch tile (brightnessctl
through logind, no udev rule needed).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: saiththerobo <the.tom.sharp@gmail.com>
@robotosaith
robotosaith force-pushed the omamobile-gs101-torch-pr branch from c1b3b11 to f5e6ff7 Compare October 28, 2026 19:23
@derekross

Copy link
Copy Markdown
Owner

Thanks for the rebase. I checked the new push against what we discussed:

  • It sits on today's omamobile, with arm64: dts: exynos: google: gs101-raven: describe the battery for the charger #112's battery change underneath, and the end of gs101-raven.dts is in the order I suggested: the &pmic { monitored-battery = <&battery>; }; block, then your &usi7 and &hsi2c_7 blocks. Comparing the two pushes, the only change is that context. The LED node, the help text and both messages are word for word what I reviewed this afternoon.
  • The DT commit's subject still has arm64: dts: exynos: google: gs101-raven:, which is what lands.
  • tools/kernel-pr-check --build --merge passes on today's branch: it merges cleanly, both commits are signed off, checkpatch --strict shows only the Co-Authored-By: notes, and all seven Google device trees build with W=1 and nothing new. CI's dtbs_check agrees. The Pixel 7 Pro isn't affected, since only raven's DTS and the Kconfig help text change.

Nothing more is needed on your side. I'll merge it as it stands.

@derekross
derekross merged commit 0f5bbf4 into derekross:omamobile Oct 28, 2026
1 check passed
@robotosaith
robotosaith deleted the omamobile-gs101-torch-pr branch October 29, 2026 07:26
derekross added a commit to derekross/omarchy-mobile that referenced this pull request Oct 29, 2026
The matrix after the merges since #118, with each cell going by the
merged notes:

- Pixel 7 (panther): the board file (derekross/linux-omarchy-mobile#108) and the
  FT3658 touch driver (derekross/linux-omarchy-mobile#109) have merged
  into the published kernel, so Boot, Storage, Buttons and USB net say
  "in the published kernel" instead of "in review". Touch stays "no":
  the driver and the touch rails are published, but the board file has
  no touch node, and panther's notes end at boot 8 with the controller
  not answering. BRINGUP-M1's status and NOTES' header say the same.
- Pixel 6 Pro (raven), Charging: no -> works. device-raven 0.1.26 (#112,
  #126) loads the MAX77759 charger at boot with its temperature guard;
  USB-PLAN section 4 records C0-C5 passed on 2026-10-28, a full charge to
  100 % included. The battery node is derekross/linux-omarchy-mobile#112;
  the runs were on an unpublished integration kernel, and the cell says so.
- raven, Torch: still works; the LED's node is now in the published
  kernel (derekross/linux-omarchy-mobile#113), tested on
  omamobile-gs101-torch and not yet run from the published kernel.
- Pixel 9a (tegu), Fingerprint: no -> WIP. FINGERPRINT-PLAN records F0
  and F2-F6b passed on an unpublished kernel: Trusty's TA runs and the HAL
  sees the sensor; enrollment waits for the factory calibration (F6c).
  omamobile-fingerprint 0.1.10 (#101) maps Trusty's stores for it.

Left as they were: tegu's Charging (the MAX77779 charger driver,
derekross/linux-omarchy-mobile#92, is published, but tegu's notes record
no run of it), the gs201 HSI2 pin controller
(derekross/linux-omarchy-mobile#123, no cell), felix (#35 is a plan) and
cheetah (nothing merged for it).

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants