Skip to content

🧹 Remove legacy otherClicks field from AppStats and DailyStats #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
debugtheworldbot wants to merge 1 commit into from
+0 −12
Closed

🧹 Remove legacy otherClicks field from AppStats and DailyStats #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions KeyStats/AppStats.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ struct AppStats: Codable {
case rightClicks
case sideBackClicks
case sideForwardClicks
// legacy field
case otherClicks
case scrollDistance
}

Expand All @@ -43,10 +41,6 @@ struct AppStats: Codable {
rightClicks = try container.decodeIfPresent(Int.self, forKey: .rightClicks) ?? 0
sideBackClicks = try container.decodeIfPresent(Int.self, forKey: .sideBackClicks) ?? 0
sideForwardClicks = try container.decodeIfPresent(Int.self, forKey: .sideForwardClicks) ?? 0
// Backward compatibility: old builds stored all side clicks in `otherClicks`.
if !container.contains(.sideBackClicks) && !container.contains(.sideForwardClicks) {
sideBackClicks = try container.decodeIfPresent(Int.self, forKey: .otherClicks) ?? 0
}
scrollDistance = try container.decodeIfPresent(Double.self, forKey: .scrollDistance) ?? 0
}

Expand Down
6 changes: 0 additions & 6 deletions KeyStats/StatsManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,6 @@ struct DailyStats: Codable {
case rightClicks
case sideBackClicks
case sideForwardClicks
// legacy field
case otherClicks
case mouseDistance
case scrollDistance
case appStats
Expand All @@ -76,10 +74,6 @@ struct DailyStats: Codable {
rightClicks = try container.decodeIfPresent(Int.self, forKey: .rightClicks) ?? 0
sideBackClicks = try container.decodeIfPresent(Int.self, forKey: .sideBackClicks) ?? 0
sideForwardClicks = try container.decodeIfPresent(Int.self, forKey: .sideForwardClicks) ?? 0
Comment on lines 75 to 76
Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve legacy otherClicks during stats decoding

In DailyStats.init(from:), the decoder now defaults sideBackClicks and sideForwardClicks to 0 without any fallback from the legacy otherClicks key (and AppStats.init(from:) was changed the same way in this commit). For users upgrading directly from builds that only stored otherClicks, historical side-click counts will be dropped on load and then permanently overwritten on the next save, which is an irreversible data-loss regression for existing installations.

Useful? React with 👍 / 👎.

// Backward compatibility: old builds stored all side clicks in `otherClicks`.
if !container.contains(.sideBackClicks) && !container.contains(.sideForwardClicks) {
sideBackClicks = try container.decodeIfPresent(Int.self, forKey: .otherClicks) ?? 0
}
mouseDistance = try container.decodeIfPresent(Double.self, forKey: .mouseDistance) ?? 0
scrollDistance = try container.decodeIfPresent(Double.self, forKey: .scrollDistance) ?? 0
appStats = try container.decodeIfPresent([String: AppStats].self, forKey: .appStats) ?? [:]
Expand Down