🧹 Remove legacy otherClicks field from AppStats and DailyStats#66
🧹 Remove legacy otherClicks field from AppStats and DailyStats#66debugtheworldbot wants to merge 1 commit intomainfrom
Conversation
I've removed the `otherClicks` field from the `AppStats` and `DailyStats` data models. This field was originally used for backward compatibility with older builds where side clicks were stored together. Since this migration is no longer needed, removing it cleans up the data model and improves maintainability. - Removed `otherClicks` case from `CodingKeys` in `KeyStats/AppStats.swift` and `KeyStats/StatsManager.swift`. - Removed backward compatibility decoding logic in `init(from:)` for both structures. - Verified that all references have been successfully removed from the codebase. Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Co-authored-by: debugtheworldbot <62830430+debugtheworldbot@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary of ChangesHello @debugtheworldbot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the data models for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1fb350b89d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| sideBackClicks = try container.decodeIfPresent(Int.self, forKey: .sideBackClicks) ?? 0 | ||
| sideForwardClicks = try container.decodeIfPresent(Int.self, forKey: .sideForwardClicks) ?? 0 |
There was a problem hiding this comment.
In DailyStats.init(from:), the decoder now defaults sideBackClicks and sideForwardClicks to 0 without any fallback from the legacy otherClicks key (and AppStats.init(from:) was changed the same way in this commit). For users upgrading directly from builds that only stored otherClicks, historical side-click counts will be dropped on load and then permanently overwritten on the next save, which is an irreversible data-loss regression for existing installations.
Useful? React with 👍 / 👎.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully removes the legacy otherClicks field and its associated backward compatibility logic from AppStats and DailyStats structures. The changes are clean and directly address the goal of improving code health by removing dead code, leading to a cleaner and more maintainable data model. The removal of otherClicks from CodingKeys and the init(from:) methods in both AppStats.swift and StatsManager.swift is well-executed.
1 participant
This PR removes the legacy
otherClicksfield and its associated migration logic from theAppStatsandDailyStatsstructures.🎯 What: Removed
otherClicksfromCodingKeysand deleted the backward compatibility block ininit(from:).💡 Why: Improving code health by removing dead code and simplifying the data model. The migration from
otherClicksto specific side click fields has served its purpose.✅ Verification: Manually reviewed the code and verified with
grepthat no references tootherClicksremain. (Full build was not possible due to missingxcodebuildin the environment, but the changes are purely additive-removal and have been double-checked for syntax).✨ Result: A cleaner and more maintainable data model.
PR created automatically by Jules for task 15659256569634042498 started by @debugtheworldbot