refactor/transaction-factory-composition-root

composer.json

@@ -49,12 +49,6 @@
     },
     "sort-packages": true
   },
-  "repositories": [
-    {
-      "type": "vcs",
-      "url": "https://github.com/dbschemix/core"
-    }
-  ],
   "scripts": {
     "fix": [
       "@phpcbf",

src/Driver.php

@@ -10,12 +10,16 @@
 use PDOException;
 use OutOfBoundsException;
 use dbschemix\core\command\Command;
+use dbschemix\core\command\CommandInterface;
 use dbschemix\core\connection\ConnectionInterface;
 use dbschemix\core\connection\DriverInterface;
 use dbschemix\core\exception\ConfigurationException;
 use dbschemix\core\exception\ConnectionException;
 use dbschemix\core\Config;
 use dbschemix\pdo\internal\Connection;
+use dbschemix\pdo\internal\FactoryTransaction;
+use dbschemix\pdo\internal\Transaction;
+use dbschemix\pdo\internal\TransactionMysql;
 
 use function dbschemix\core\internal\get_package_path;
 
@@ -84,7 +88,7 @@ public function getSetupPath(): string
     }
 
     #[Override]
-    public function makeCommand(Config $config): Command
+    public function makeCommand(Config $config): CommandInterface
     {
         return new Command($this->makeConnection(), $config);
     }
@@ -106,7 +110,7 @@ private function makeConnection(): ConnectionInterface
             try {
                 return $this->connectionInstance = new Connection(
                     ($this->connectionFactory)(),
-                    $this->type,
+                    $this->makeFactoryTransaction(),
                 );
             } catch (PDOException $exception) {
                 throw new ConnectionException($this, $exception);
@@ -115,9 +119,25 @@ private function makeConnection(): ConnectionInterface
 
         return $this->connectionInstance;
     }
+
+    /**
+     * Composition root: picks the transaction factory for the resolved dialect.
+     *
+     * @infection-ignore-all
+     * @return class-string<FactoryTransaction>
+     */
+    private function makeFactoryTransaction(): string
+    {
+        if ($this->type === Type::PDO_MYSQL) {
+            return TransactionMysql::class;
+        }
+
+        return Transaction::class;
+    }
 }
 
 /**
+ * @internal
  * @return array{0: Type, 1: non-empty-lowercase-string}
  * @throws ConfigurationException
  */

src/Type.php

@@ -4,10 +4,6 @@
 
 namespace dbschemix\pdo;
 
-use dbschemix\pdo\internal\FactoryTransaction;
-use dbschemix\pdo\internal\Transaction;
-use dbschemix\pdo\internal\TransactionMysql;
-
 /**
  * @api
  */
@@ -31,16 +27,4 @@ public function value(): string
          */
         return strtolower($db);
     }
-
-    /**
-     * @return class-string<FactoryTransaction>
-     */
-    public function makeFactoryTransaction(): string
-    {
-        if ($this === self::PDO_MYSQL) {
-            return TransactionMysql::class;
-        }
-
-        return Transaction::class;
-    }
 }

src/internal/Connection.php

@@ -8,7 +8,6 @@
 use PDO;
 use dbschemix\core\connection\ConnectionInterface;
 use dbschemix\core\connection\TransactionInterface;
-use dbschemix\pdo\Type;
 
 /**
  * @psalm-internal dbschemix\pdo
@@ -17,17 +16,19 @@
 {
     use ThrowPrepareException;
 
+    /**
+     * @param class-string<FactoryTransaction> $factoryTransaction
+     */
     public function __construct(
         private PDO $connection,
-        private Type $driverType,
+        private string $factoryTransaction,
     ) {
     }
 
     #[Override]
     public function beginTransaction(): TransactionInterface
     {
-        $class = $this->driverType->makeFactoryTransaction();
-        return $class::begin($this->connection);
+        return ($this->factoryTransaction)::begin($this->connection);
     }
 
     #[Override]

tests/workflow/StatementMysqlTest.php

@@ -12,7 +12,7 @@
 use Testo\Test;
 use dbschemix\core\connection\TransactionInterface;
 use dbschemix\pdo\internal\Connection;
-use dbschemix\pdo\Type;
+use dbschemix\pdo\internal\TransactionMysql;
 
 #[Test]
 final class StatementMysqlTest
@@ -27,7 +27,7 @@ public function init(): void
             'CREATE TABLE migration (name TEXT PRIMARY KEY, version INTEGER DEFAULT 0, atime TEXT)'
         );
 
-        $this->transaction = (new Connection($pdo, Type::PDO_MYSQL))->beginTransaction();
+        $this->transaction = (new Connection($pdo, TransactionMysql::class))->beginTransaction();
     }
 
     /**