refactor/transaction-factory-composition-root#4
Merged
Conversation
…root Type was an @api enum that imported internal classes and exposed makeFactoryTransaction() returning class-string<FactoryTransaction>, leaking an internal type through the public API surface. - Type is now a pure public dialect enum (cases + value()), with no reference to internal classes. - Connection no longer depends on the public Type for behavior; its constructor takes class-string<FactoryTransaction> directly. - Driver (the composition root that already resolves the dialect via prepareDSN) decides which transaction factory to use via a private makeFactoryTransaction(), so the choice is not part of any public surface. - StatementMysqlTest constructs Connection with the factory class-string. - composer.json: drop the dbschemix/core vcs repository entry. phpcs/psalm/phpstan green; 29/29 Testo tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.