Repository navigation
Conversation
danoev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read-only inventory could return partial metadata after an exchange failure without telling callers that transport had been interrupted. Inventory admin/challenge errors could also expose raw exception text, including a malformed stored key. This draft adds an explicit
transport_interruptedflag while preserving credential-free partial evidence, and suppresses raw transport, decrypt and admin-builder exception chains. Cancellation still propagates.This PR stays on the preserved SDK 0.1.11/RC12 lineage (
codex/rc12-connection-safetyat65a196a4415516039fd98fe40ccdccc7dccfec23), not current SDK main. Integration RC13 draft danoev/ha-ttlock-ble#5 explicitly pins final SDK head60604872e004d9dc7fd74aaf3ad260da9143b4c1; published RC12 retains its original SDK pin.The original inventory scope remains: admin-gated summaries for PINs, fingerprints and upstream PR roquerodrigo#96's hardware-tested four-byte IC cards. Values, UIDs, fingerprint IDs and slots are discarded. PIN coverage remains incomplete; eight-byte cards remain unverified. The original MIT project authorship and upstream provenance are preserved.
Validation: complete local SDK suite 308 passed, 97.21% coverage; Ruff, formatting and mypy pass. New regressions cover transport interruption, redacted rendered tracebacks at admin/random/page stages, and malformed admin-challenge key handling. Existing control, cleanup, compatibility and retry tests remain in the full suite. Hosted CI 39764637576 and CodeQL 39764637993 pass at that exact head; hosted pytest also reports 308 passed, 97.21% coverage. The branch-update job skipped and the head remained unchanged.
Hardware inventory validation remains pending. This is a draft for fork review and validation; no merge or SDK-main change is requested.