Skip to content

Update file structure to conform with new skills behavior - #10

Merged
miguelangaranocurrents merged 2 commits into
currents-dev:mainfrom
octalign:upstream-pr
Jul 21, 2026
Merged

Update file structure to conform with new skills behavior#10
miguelangaranocurrents merged 2 commits into
currents-dev:mainfrom
octalign:upstream-pr

Conversation

@WikiRik

@WikiRik WikiRik commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Fixes #8 and #9 without relying on updates of https://github.com/vercel-labs/skills

Feel free to comment if the updated version number is preferred or not, I can always update.

Summary by CodeRabbit

  • Documentation / Chores
    • Updated the skill metadata version in the SKILL file from 1.1 to 1.2.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 26bea843-85e5-4735-86ae-9713631ec878

📥 Commits

Reviewing files that changed from the base of the PR and between a79cf1d and 539798d.

📒 Files selected for processing (1)
  • playwright-best-practices/SKILL.md

📝 Walkthrough

Walkthrough

Updated the version field in the metadata block of playwright-best-practices/SKILL.md from "1.1" to "1.2".

Changes

Version Metadata Update

Layer / File(s) Summary
Update version metadata
playwright-best-practices/SKILL.md
The metadata.version value is changed from "1.1" to "1.2".

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR only bumps SKILL.md metadata.version to 1.2 and does not show the fix needed for #8's update-removal bug. Implement the packaging or file-structure change that preserves installed skill files during npx skills update, and verify the update flow end-to-end.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is broadly related to the skills behavior update, though it is more generic than the actual version bump.
Out of Scope Changes check ✅ Passed The only change is a version metadata bump, which is consistent with the stated skills-behavior work and not out of scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@WikiRik

WikiRik commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

I'm keeping this open so that the .github/.agnix.toml etc don't get included in the skill when installing, but the skill works again without this PR

Comment thread playwright-best-practices/SKILL.md Outdated
@miguelangaranocurrents
miguelangaranocurrents merged commit 283d5cb into currents-dev:main Jul 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npx skills update the skill

2 participants