Move skill into subdirectory so referenced docs install (v1.2) - #12
Closed
miguelangaranocurrents wants to merge 2 commits into
Closed
Move skill into subdirectory so referenced docs install (v1.2)#12miguelangaranocurrents wants to merge 2 commits into
miguelangaranocurrents wants to merge 2 commits into
Conversation
The restructure is a non-breaking packaging fix (files moved into a subdirectory so 'npx skills add' installs referenced docs; content unchanged). A minor bump reflects that better than a major 2.0 bump. Co-authored-by: miguelangaranocurrents <miguelangaranocurrents@users.noreply.github.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8 and #9 without relying on updates of https://github.com/vercel-labs/skills.
This is an equivalent of #10 (by @WikiRik, from the
octalignfork), preserving the original restructure commit, but with the metadata version set to1.2instead of2.0.Why 1.2 and not 2.0
The change is a non-breaking packaging fix: the skill's guidance files are byte-identical and only moved into a
playwright-best-practices/subdirectory sonpx skills addcopies the referenced docs (not justSKILL.md). No content or interface change, nothing breaks for consumers — so a minor bump fits better than a major2.0. The bump is still needed so theskillsupdate mechanism recognizes the new version.Changes
playwright-best-practices/(58 pure renames, byte-identical content).SKILL.mdmetadataversionfrom1.1to1.2.Original restructure authored by @WikiRik; version-value adjustment added on top.