Repository navigation
feat(core): ToolApprovalRequestOutput.inputSchemaInput (phase 1 unit 1.2) - #12
Open
cunninghamcard-bit wants to merge 13 commits into
Open
cunninghamcard-bit wants to merge 13 commits into
cunninghamcard-bit wants to merge 13 commits into
Conversation
…assed through to response messages (1.2)
…t part, written only when it differs from toolCall.input (1.2 rework)
Only pull_request runs cancel in-progress runs in the same group; master push runs are never cancelled. Note: with push limited to master (previous commit), direct pushes to exp/restart no longer run CI separately; exp/** branches are covered only via pull_request.
…oval-input-schema-input
9 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1 unit 1.2 (reworked per the corrected reading: arcships#200:1952 is about the model-message content parts).
ContentPart::ToolApprovalRequest(aimux-core/src/content.rs:48-63), which is the prompt / model-message part read bylanguage_model_message.rs, already has optional camelCaseinputSchemaInput. A new round-trip test covers it with the field (object and raw-string values) and without it.ToolApprovalRequestOutput(result.rs) carriesinput_schema_inputinternally only (#[serde(skip)],#[ts(skip)]). Its public JSON and the ts-rs binding are unchanged from the base; a test checks the field is neither read from nor written to JSON.response_messages.rswritesinputSchemaInputinto thetool-approval-requestpart only when it is not deep-equal totoolCall.input, mirroring AI SDKto-response-messages.ts:134-144(isDeepEqualData). Unit tests cover unequal (present), equal (absent) and none (absent).None(docs: full-chain AI SDK alignment design and impact map arcships/aimux#200 §0.4 Q1, pass-through only).Hand-written bindings (D20 corrected). No gap. Every prompt / content part already carries
inputSchemaInput: KotlinTypes.kt:485, JavaTypes.java:1510, SwiftTypes.swift:651, Fluttertypes.dart:832, Pythonwrapper.py:662. The locations previously listed are all output / stream types, which by design carry noinputSchemaInput, matching the Rust output JSON:Types.kt:1087StreamPart.ToolApprovalRequestTypes.swift:900ToolApprovalRequestOutputtypes.dart:1900StreamPartToolApprovalRequestwrapper.py:370-376_ApprovalRequestTypes.java:4497StreamPart.ToolApprovalRequestNote: this branch is cut from
exp/unit2-ciso that CI triggers, so the diff againstexp/restartalso includes unit 2'sci.ymlchange.