Repository navigation
1.13: isDeepEqualData semantics for inputSchemaInput comparison - #18
Open
cunninghamcard-bit wants to merge 15 commits into
Open
cunninghamcard-bit wants to merge 15 commits into
cunninghamcard-bit wants to merge 15 commits into
Conversation
…assed through to response messages (1.2)
…t part, written only when it differs from toolCall.input (1.2 rework)
…mber semantics (1.13)
Only pull_request runs cancel in-progress runs in the same group; master push runs are never cancelled. Note: with push limited to master (previous commit), direct pushes to exp/restart no longer run CI separately; exp/** branches are covered only via pull_request.
9 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit 1.13. Based on PR #12 head
054b4bc0(exp/u1.2-approval-input-schema-input), so this diff against exp/restart also contains #12 and unit 2's ci.yml change; review only the top commit.response_messages.rsdecided whether to writeinputSchemaInputwithserde_json::Value ==. That differs from AI SDKisDeepEqualData(ai/src/util/is-deep-equal-data.ts:8-48), where numbers are JS doubles. Addedis_deep_equal_data: numbers compare viaas_f64, arrays elementwise, objects by key set (order-insensitive), everything else by==.Test
deep_equal_data_matches_javascriptasserts 13 pairs both ways. Expected values come from node running the pinnedai@7.0.127source onJSON.parseinputs:{"a":1}vs{"a":1.0}→ true (old==: false)-0.0vs0→ true (also nested)9007199254740993vs9007199254740992→ true (both round to 2^53), also inside an array and at the u64 max vs 2^64[]/{},null/{},"1"/1,{"a":null}/{}, and nested mismatches → falsePlus an end-to-end builder test: when only the number spelling differs,
inputSchemaInputis omitted.