Skip to content

llvm: test switched-resume coroutine lowering - #3

Merged
cpunion merged 1 commit into
llvm-corofrom
coro/presplit-smoke
Jul 15, 2026
Merged

llvm: test switched-resume coroutine lowering#3
cpunion merged 1 commit into
llvm-corofrom
coro/presplit-smoke

Conversation

@cpunion

@cpunion cpunion commented Jul 15, 2026

Copy link
Copy Markdown
Owner

Summary

  • construct a canonical switched-resume coroutine through the public Go bindings
  • verify both the explicit coroutine pass pipeline and the production default<O0> pipeline
  • cover target-width frame intrinsics plus the LLVM 14/18/22 attribute and coro.end ABI differences

This is a test-only change; it does not add or change production bindings.

Testing

  • go test ./...
  • go vet ./...
  • focused test with LLVM 14, 18, 19, 20, and the LLVM 22 forward-compatibility path
  • GitHub CI covers the actual LLVM 21 matrix entry

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new test file coroutine_test.go to verify coroutine lowering pipelines in the LLVM Go bindings. Feedback was provided to initialize all LLVM targets instead of just the native target, ensuring the tests run robustly in cross-compilation environments where the default target triple might not match the host's native architecture.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread coroutine_test.go Outdated
@cpunion
cpunion force-pushed the coro/presplit-smoke branch from a90bf2c to 7eed3da Compare July 15, 2026 17:00
@cpunion
cpunion force-pushed the coro/presplit-smoke branch from 7eed3da to d1bc0d8 Compare July 15, 2026 17:01
@cpunion
cpunion merged commit eac1b3d into llvm-coro Jul 15, 2026
4 checks passed
@cpunion
cpunion deleted the coro/presplit-smoke branch July 15, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant