compiler: add structured LLVM coroutine builder - #12
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces ssa/coro.go and its corresponding tests in ssa/coro_test.go. It implements CoroBuilder and related configurations to emit target-independent LLVM switched-resume coroutine control flow and frame allocation. I have no feedback to provide as there are no review comments to assess.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This slice only builds the selected coroutine primary. It does not add a synchronous twin, dynamic dispatch, scheduler policy, or a fixed runtime frame ABI. The binding-level switched-resume smoke coverage is merged in cpunion/llvm#3.
Testing
go test ./ssa -count=1go test -race ./ssa -run ^'TestCoroBuilder' -count=1\n-go vet -copylocks=false ./ssa\n-go test -tags=llgo ./ssa -run ^'$'\n- focused local runs with LLVM 14, 18, 19, 20, and LLVM 22 forward compatibility\n-actionlint .github/workflows/coroutine.yml\n