runtime/wasm: stop all workers for garbage collection (based on #119) - #123
Draft
cpunion wants to merge 3 commits into
Draft
runtime/wasm: stop all workers for garbage collection (based on #119)#123cpunion wants to merge 3 commits into
cpunion wants to merge 3 commits into
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This was referenced Aug 1, 2026
LLGo baseline benchmarks
Program measurements
Core language and compiler benchmarks
Compared only with the latest matching platform in the main series. Warning
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #119.
Problem
The bounded Web worker scheduler can execute Go code on several native wasm threads, but the non-moving wasm collector was still single-threaded:
Enabling the collector in that state can miss roots or race heap metadata updates.
Changes
The compiler only enables TLS roots for
wasm GC + workers. Runtime implementations are selected by wasm build tags; native, embedded, single-worker wasm, and wasm without GC retain their existing paths.Validation
ssa,cl, andinternal/buildsuites pass; fullruntime/...passes.runtime/...pass.-O0; J64-O3 -lto=thin; J64-O3 -lto=fullpass.140/0/10.git diff --checkpasses.Independent diff from #119: 34 files,
+687/-120.