[Based on #123] test/wasm: harden runtime lifecycle and host boundaries - #125
Draft
cpunion wants to merge 4 commits into
Draft
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This was referenced Aug 2, 2026
Open
LLGo baseline benchmarks
Program measurements
Core language and compiler benchmarks
Compared only with the latest matching platform in the main series. Warning
|
This was referenced Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #123.
Problem
The refreshed wasm runtime can schedule, block, wake timers, collect suspended roots, and stop multiple workers, but its lifecycle acceptance coverage did not exercise several boundaries together. In particular, importing
osin a J32/J64/P1 program failed to link because wasm did not provideos.runtime_args.Changes
os.runtime_argsruntime contract;The independent diff over #123 is 10 files, +366/-4. The rejected prototype raised Emscripten maximum memory to 4 GiB; it is not included because 10,000 simultaneously blocked goroutines pass with the existing default configuration, so hardening adds no default wasm, native, or embedded artifact cost.
Validation
go test -timeout 30m -p=1 ./internal/build -count=1(953.050s)go test -p=1 ./internal/crosscompile ./internal/buildfocused source-selection tests on Go 1.26.5; the Go 1.24 selection test also passesgo test -p=1 ./...in the runtime module on macOS arm64 and Ubuntu amd64 (2 CPUs, 6 GiB)-O0,-O3, ThinLTO, and full LTO hardening execution