Skip to content

fix(modal): mobile touch-target sizing for footer action buttons #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CaitlinEverett wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(modal): mobile touch-target sizing for footer action buttons #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/primitives/src/components/Modal/Modal.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,20 @@
cursor: not-allowed;
}

/* ── Mobile footer touch targets (phone widths — see scilence
_viewport-bands.css / admin-shell.js syncViewportDataset()). Desktop
padding alone renders footer action buttons well under the 44px
minimum; every openModal() / modal.confirm() / modal.confirmDanger()
caller shares this via .s-modal__btn. ── */
@media (max-width: 767px) {
html[data-viewport^="mobile-"] .s-modal__btn {
display: inline-flex;
align-items: center;
justify-content: center;
min-height: var(--s-size-touch-target-min);
}
}

/* ── Optional-region hidden-state fix ────────────────────────────────────
Each optional slot region above declares an explicit `display: flex`
(needed so it lays out correctly when the slot IS present). Modal.ts
Expand Down