fix(modal): mobile touch-target sizing for footer action buttons - #12
Open
CaitlinEverett wants to merge 1 commit into
Open
fix(modal): mobile touch-target sizing for footer action buttons#12CaitlinEverett wants to merge 1 commit into
CaitlinEverett wants to merge 1 commit into
Conversation
.s-modal__btn had no phone rule anywhere in Modal.css — footer action buttons rendered under the 44px --s-size-touch-target-min minimum on mobile widths. Adds a mobile block matching the guide-side notification-center.css precedent (mobile-lg breakpoint, data-viewport scoping). Companion fix in the GUIDE mirror: commonscience/steamco-workspace#1273. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.s-modal__btn(the shared footer button used by every consumer of the Modal primitive's footer slot) had no mobile rule anywhere inModal.css— footer buttons render under the 44px--s-size-touch-target-minminimum on phone widths.@media (max-width: 767px) { html[data-viewport^="mobile-"] .s-modal__btn { ... } }, matching the established GUIDE-sidenotification-center.cssprecedent (mobile-lg breakpoint boundary,data-viewportscoping).guide/shell/css/components/modal.cssin thecommonscience/steamco-workspacerepo: commonscience/steamco-workspace#1273 (kept in sync manually until scilence is a real npm dependency, per this file's own header comment).Test plan
--s-size-touch-target-min: 44pxin_interactive.css,--s-vp-mobile-lg-max: 767pxin_viewport-bands.css) to confirm the breakpoint and target size are correct.🤖 Generated with Claude Code