Skip to content

fix: Stop StyledVideo from loading both video files #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
curlyfriesplease merged 2 commits into from
Apr 21, 2026
+18 −4
Merged

fix: Stop StyledVideo from loading both video files #875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f82de81
Limits the ability of the StyledVideo component to load in both video…
curlyfriesplease Apr 20, 2026
85e1e0c
fix: Empty commit to trigger CI
curlyfriesplease Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/components/Atoms/AmbientVideo/AmbientVideo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ import {
// Normalise webpack module object ({ default }) or string to video URL
const normaliseSrc = value => (typeof value === 'string' ? value : value?.default);

const belowLBreakpointMediaString = `(max-width: ${breakpointValues.L - 1}px)`;

const AmbientVideo = ({
src,
srcMobile,
Expand All @@ -32,8 +34,9 @@ const AmbientVideo = ({
const videoRef = useRef(null);
const [isPlaying, setIsPlaying] = useState(true);
const isBelowL = useMediaQuery({ maxWidth: breakpointValues.L - 1 });
const rawSrc = srcMobile && isBelowL ? srcMobile : src;
const effectiveSrc = normaliseSrc(rawSrc);
const desktopSrc = normaliseSrc(src);
const mobileSrc = srcMobile ? normaliseSrc(srcMobile) : null;
// <video> only supports one poster URL; keep JS breakpoint for poster / fallback stills.
const rawPoster = posterMobile && isBelowL ? posterMobile : poster;
const effectivePoster = rawPoster ? normaliseSrc(rawPoster) : undefined;

Expand Down Expand Up @@ -72,7 +75,6 @@ const AmbientVideo = ({
<VideoWrapper>
<StyledVideo
ref={videoRef}
src={effectiveSrc}
poster={effectivePoster}
controls={showFullControls}
controlsList={showFullControls ? 'nodownload nofullscreen noremoteplayback' : undefined}
Expand All @@ -82,6 +84,10 @@ const AmbientVideo = ({
onPlay={handlePlay}
onPause={handlePause}
>
{mobileSrc ? (
<source src={mobileSrc} type="video/mp4" media={belowLBreakpointMediaString} />
) : null}
<source src={desktopSrc} type="video/mp4" />
{effectivePoster ? (
<FallbackImg src={effectivePoster} alt="Video playback not supported" />
) : (
Expand Down
10 changes: 9 additions & 1 deletion src/components/Molecules/PictureOrVideo/__snapshots__/PictureOrVideo.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,16 @@ exports[`renders AmbientVideo when video props are provided correctly 1`] = `
onPlay={[Function]}
playsInline={true}
poster="//images.ctfassets.net/zsfivwzfgl3t/Yq59XdwwQgjNOxky93K1Q/17c2d80dce99067b0b3508f33075cbe3/funding_4-3_2x.jpg?w=200&h=150&q=50 200w,//images.ctfassets.net/zsfivwzfgl3t/Yq59XdwwQgjNOxky93K1Q/17c2d80dce99067b0b3508f33075cbe3/funding_4-3_2x.jpg?w=400&h=300&q=50 400w,//images.ctfassets.net/zsfivwzfgl3t/Yq59XdwwQgjNOxky93K1Q/17c2d80dce99067b0b3508f33075cbe3/funding_4-3_2x.jpg?w=800&h=600&q=50 800w,//images.ctfassets.net/zsfivwzfgl3t/Yq59XdwwQgjNOxky93K1Q/17c2d80dce99067b0b3508f33075cbe3/funding_4-3_2x.jpg?w=1200&h=900&q=50 1200w,//images.ctfassets.net/zsfivwzfgl3t/Yq59XdwwQgjNOxky93K1Q/17c2d80dce99067b0b3508f33075cbe3/funding_4-3_2x.jpg?w=1440&h=1080&q=50 1440w"
src="https://example.com/video-desktop.mp4"
>
<source
media="(max-width: 1023px)"
src="https://example.com/video-mobile.mp4"
type="video/mp4"
/>
<source
src="https://example.com/video-desktop.mp4"
type="video/mp4"
/>
<img
alt="Video playback not supported"
className="c3"
Expand Down
Loading