fix: Stop StyledVideo from loading both video files#875
Merged
curlyfriesplease merged 2 commits intomasterfrom Apr 21, 2026
Merged
fix: Stop StyledVideo from loading both video files#875curlyfriesplease merged 2 commits intomasterfrom
curlyfriesplease merged 2 commits intomasterfrom
Conversation
curlyfriesplease
changed the title
Contributor
Nicely sussed-out, mate; I can indeed see that it was working as expected purely within the CL example here. |
AndyEPhipps
approved these changes
Apr 21, 2026
|
🎉 This PR is included in version 8.71.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
What is it doing?
Addresses an issue where mobile users were loading in both video files.
I believe it's because Gatsby compiles its files not knowing the viewport size, and went with the default desktop URL. Once rendered, react recalculates with the real viewport, and switches the video to mobile. This meant the user was downloading both files.
Now, the AmbientVideo component makes use of
<source>. There are two in order and the browser will use the first one that's valid.This should mean that React won't need to recompute anything. The browser will know what to do correctly when it first loads.
I've given it a test on CRCom and it appears to fix the bug.
Why is this required?
Bugfix, optimisation.
link to Jira ticket:
ENG-5050
Quick Checklist:
My PR title follows the Conventional Commit spec.
I have filled out the PR description as per the template above.
I have added tests to cover new or changed behaviour.
I have updated any relevant documentation.
Important! - lastly, make sure to squash merge...