Skip to content

feat(core): filter tags, metadata strings and source, and report masked updates (#1464, part 2c) - #1511

Merged
ajianaz merged 2 commits into
developfrom
feat/privacy-remaining-paths
Oct 21, 2026
Merged

ajianaz merged 2 commits into
developfrom
feat/privacy-remaining-paths

Conversation

@ajianaz

@ajianaz ajianaz commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

What

Closes the gaps listed in the 2b-1 CHANGELOG entry. The privacy filter now also covers the tags, every string inside the metadata and the source on remember, remember_with_contradiction, room remember, update, import, set_source and room consolidation (ConsolidationStore::insert_memory); counts are merged into redactions and strict mode refuses the write (the HTTP and CLI source is checked before anything is stored). New update_memory_detailed returns an UpdateOutcome (what was masked); update_memory keeps its signature. PUT /memory returns redacted and uteke_update over MCP says when it masked something. Importing a structural export (export --full) restores a backup as it was and is deliberately not filtered; this is documented.

Why

Part of #1464: a secret in a tag, a metadata string or a source would otherwise still be persisted and indexed. Refs #1464.

Testing

  • clippy -D warnings, fmt, cargo test --workspace and cargo run -p docgen (no diff) pass
  • new tests: 6 in privacy_field_tests.rs (tags and metadata on remember, strict, update, source, import), 1 consolidation, 1 server (PUT redacted, strict source and metadata) and 1 MCP (masked update)
  • reviewed locally with the Cora MCP agent reviewer before opening

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

🔍 Cora AI Code Review

✅ No issues found. Code looks good!


Review powered by cora-code · BYOK · MIT

@ajianaz
ajianaz merged commit aa35ccb into develop Oct 21, 2026
15 checks passed
@ajianaz
ajianaz deleted the feat/privacy-remaining-paths branch October 21, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant