Repository navigation
feat(server): redacted on the write responses and 400 secret_detected in strict mode (#1464, part 2b-2b) - #1509
Merged
Merged
Conversation
… in strict mode (#1464, part 2b-2b)
ajianaz
force-pushed
the
feat/privacy-reporting
branch
from
October 21, 2026 07:29
e48e03b to
cd7ca64
Compare
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
HTTP reporting for the privacy filter, as agreed with cloud in uteke-cloud#218:
POST /rememberandPOST /room/rememberreturnredacted(boolean, additive); in strict mode a write with a secret is refused with400 {"error": "secret_detected", "message": ..., "kinds": [...]}(alsoPUT /memory), and the value is never echoed.POST /importreportsredactedandrejected_secret;ImportResultgains the two counters (also counted inskipped).Why
Part of #1464. Before this, strict mode would surface as a 500 and clients could not tell that the stored text differs from what they sent. MCP and CLI reporting follow in 2b-2c. Refs #1464.
Testing
-D warnings, fmt,cargo test --workspaceandcargo run -p docgen(no diff) pass/rememberresponse now includesredacted