Repository navigation
feat(mcp,cli): report masked and rejected secrets (#1464, part 2b-2c) - #1510
Merged
Merged
Conversation
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reporting of the privacy filter outside HTTP.
uteke rememberprints which kinds were masked and its--jsonoutput gainsredacted;uteke importprints masked and rejected row counts (the--jsonresult already carries the new counters).uteke_rememberover MCP says what was masked in its result; in strict modeuteke_rememberanduteke_updatefail with a tool error that starts withsecret_detected:and names the kinds, never the value (the MCP counterpart of the HTTP 400 from #1509). New helperRememberOutcome::redaction_summary.Why
Last piece of #1464 part 2b-2: a user or agent has to be able to tell that the stored text differs from what was sent, and why a strict write failed. Refs #1464.
Testing
-D warnings, fmt,cargo test --workspacepass;cargo run -p docgenchanges nothingredaction_summary