Repository navigation
feat(server): dedicated signing key and signed expiry for GET render URLs - #132
Merged
Merged
Conversation
ajianaz
force-pushed
the
perf/render-pipeline
branch
from
October 7, 2026 07:09
aec4846 to
82bc054
Compare
ajianaz
force-pushed
the
feat/signing-key-expiry
branch
from
October 7, 2026 07:16
a0ee090 to
5c321ca
Compare
…URLs Closes #129 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
ajianaz
force-pushed
the
feat/signing-key-expiry
branch
from
October 7, 2026 07:19
5c321ca to
43123bd
Compare
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Dedicated --signing-key / COSY_SIGNING_KEY for signed GET render URLs and optional signed exp expiry. Stacked on #131.
Why
Signed URLs reused the API key as HMAC key (leaking one leaks both) and never expired. Closes #129.
How
Signing key falls back to API key for compatibility; exp is part of the signed payload so it cannot be stripped or injected; Cache-Control capped to remaining lifetime.
Testing
cargo testpassescargo fmt --all -- --checkpassescargo clippy --all-targets -- -D warningspassescargo build --releasepasses (CI)cosy servebefore the fix; regression tests added.Related Issues
Closes #129
Checklist
develop🤖 Generated with Claude Code