Repository navigation
fix(scan): run the same deterministic family as review; scan judge seam (#645) - #653
Merged
Merged
Conversation
This was referenced Oct 15, 2026
…am (#645) deterministic::run_files serves whole files (scan, MCP snippet check) the way run serves diffs, so built-in and custom rules now fire in scan. ScanJudge (HttpScanJudge, NoJudge) makes the batch loop testable without a network. DEFAULT_BATCH_TOKEN_BUDGET is renamed to CHAR_BUDGET and the docs state which review flags scan lacks. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: ajianaz <ajianaz@users.noreply.github.com>
ajianaz
force-pushed
the
fix/645-scan-deterministic-family
branch
from
October 15, 2026 05:24
1537e11 to
1c8bccb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #645. Part 4/6. Stacked on #652 (#644) → #651 (#649) → #650 (#648): earlier commits here are those PRs; the diff shrinks as they merge.
What
deterministic::run_files(files, config): rules + secrets + security over whole files, the counterpart ofdeterministic::runfor diffs.postprocess(Source::Files) uses it, socora scanand MCPcora.check_snippetnow run the rules engine (built-in and custom rules), which scan silently skipped.judge::ScanJudge(HttpScanJudge,NoJudge) andjudge_batchesincommands/scan.rs: the batch loop no longer needs a network to be tested.DEFAULT_BATCH_TOKEN_BUDGET→DEFAULT_BATCH_CHAR_BUDGET(it always measured characters).docs/cli-reference.mdstates what scan runs and which review flags it does not have (--ci,--severity,--quiet,--stream,--output-file,--no-cache, quality gate).Why
Rules reached
cora reviewonly. Scan owned a private copy of the deterministic orchestration and was untestable without a live LLM.Testing
cargo fmt --check,cargo clippy --all-targets --features tree-sitter -- -D warnings,cargo test --features tree-sitter(1162 passed; new: rules fire in scan, disabled engine stays off, judge batch admitted/skipped/aborted,NoJudge).bug-todo) that it previously never reported;rules_engine.enabled: falseturns them off.