Repository navigation
feat(cli): run review/scan without an API key (select_judge, --no-llm) (#646) - #654
Merged
Merged
Conversation
#646) A missing API key now selects the deterministic judge instead of failing: checks run, a stderr notice is printed, and the summary (and SARIF invocation) says no LLM judged. --no-llm forces it. The judge is chosen once at the entry point. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: ajianaz <ajianaz@users.noreply.github.com>
ajianaz
force-pushed
the
feat/646-select-judge
branch
from
October 15, 2026 05:29
a8f9228 to
8b44e4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #646. Part 5/6. Stacked on #653 (#645) → #652 (#644) → #651 (#649) → #650 (#648): earlier commits here are those PRs; the diff shrinks as they merge.
What
judge::JudgeChoice { Llm, Deterministic }andjudge::select_judge: the judge is chosen once incmd_review/cmd_scan. A missing API key (NoApiKey) selectsDeterministic(stderr notice) instead of failing; other config errors still fail.--no-llmoncora reviewandcora scan: forces it, silent.cora.judge = "none"even with zero results.review::review_diff_with_judgedispatches; review (single + chunked) and scan take aJudgeChoice.cora commitand MCPcora.review_diffkeep requiring a key.Why
LLM configuration was a precondition of every command, so a missing key killed the part that needs no LLM. First run, git hooks and key-less CI could not use cora at all.
Testing
cargo fmt --check,cargo clippy --all-targets --features tree-sitter -- -D warnings,cargo test --features tree-sitter(1169 passed; new:choosekey/no-key/flag/other-error, deterministic scan blocks without a network, SARIF marker with and without results).HOMEand noCORA_*env,cora review/cora scanprint the notice and find the secret and command injection (before:Error: no API key found);--no-llmis silent; SARIF showscora.judge: none; with a key it still calls the LLM.